* Allow setting the VS Code build target For the NPM package (and tests, at least for now), we will still use linux-x64, but this is going to allow using the platform build targets for our standalone releases so we can avoid having to copy all the packaging steps (like cleaning up modules). This does mean that the NPM package when installed will be missing those cleanup steps. Possibly we can try to break out the packaging step into a something that can be ran standalone (which will also require installing dev dependencies like gulp) but not sure how much work this would be. * Preserve dependencies for e2e tests To avoid having to install them again. Also moved an env block to the root of the job. * Refactor releases to use VS Code packaging Instead of building the linux-x64 package, stripping the modules, then installing them again, we build the correct target and use the modules as they are. This means we do not have to copy all the post-processing steps like the ones that delete unnecessary modules. For the NPM package we still publish the linux-x64 package (without modules of course). This means npm installations do not get that same post-processing. Another advantage of this is that we can run the release immediately without having to wait for the build step, or on a commit that no longer has a build artifact, since they all build individually now. We could try sharing the core-ci build step, but leaving that alone for now. I also converted the macOS jobs into a matrix. Deleted the CI readme because it was out of date and seemed to just repeat what should be described in the scripts anyway. Removed a section about Homebrew since we do not maintain that anymore. It looks like there is no need to symlink node_modules.asar anymore.
10 KiB
Contributing
Requirements
The prerequisites for contributing to code-server are almost the same as those for VS Code. Here is what is needed:
nodev22.xgitv2.x or greatergit-lfsnpm- Used to install JS packages and run scripts
nfpm- Used to build
.deband.rpmpackages
- Used to build
jq- Used to build code-server releases
gnupg- All commits must be signed and verified; see GitHub's Managing commit signature verification or follow this tutorial
quilt- Used to manage patches to Code
rsyncandunzip- Used for code-server releases
bats- Used to run script unit tests
Linux-specific requirements
If you're developing code-server on Linux, make sure you have installed or install the following dependencies:
sudo apt-get install build-essential g++ libx11-dev libxkbfile-dev libsecret-1-dev libkrb5-dev python-is-python3
These are required by Code. See their Wiki for more information.
Development workflow
git clone https://github.com/coder/code-server.git- Clonecode-servergit submodule update --init- Clonevscodesubmodulequilt push -a- Apply patches to thevscodesubmodule.npm install- Install dependenciesnpm run watch- Launch code-server localhost:8080. code-server will be live reloaded when changes are made; the browser needs to be refreshed manually.
When pulling down changes that include modifications to the patches you will
need to apply them with quilt. If you pull down changes that update the
vscode submodule you will need to run git submodule update --init and
re-apply the patches.
When you make a change that affects people deploying the marketplace please update the changelog as part of your PR.
Note that building code-server takes a very, very long time, and loading it in the browser in development mode also takes a very, very long time.
Display language (Spanish, etc) support only works in a full build; it will not work in development mode.
Generally we prefer that PRs be squashed into main but you can rebase or merge
if it is important to keep the individual commits (make sure to clean up the
commits first if you are doing this).
Version updates to Code
- Remove any patches with
quilt pop -a. - Update the
lib/vscodesubmodule to the desired upstream version branch.cd lib/vscode && git checkout release/1.66 && cd ../..git add lib && git commit -m "chore: update to Code <version>"
- Apply the patches one at a time (
quilt push). If the application succeeds but the lines changed, update the patch withquilt refresh. If there are conflicts, then force apply withquilt push -f, manually add back the rejected code, then runquilt refresh. - From the code-server project root, run
npm install. - Check the Node.js version that's used by Electron (which is shipped with VS Code. If necessary, update our version of Node.js to match.
Patching Code
- You can go through the patch stack with
quilt pushandquilt pop. - Create a new patch (
quilt new {name}.diff) or use an existing patch. - Add the file(s) you are patching (
quilt add [-P patch] {file}). A file must be added before you make changes to it. - Make your changes. Patches do not need to be independent of each other but each patch must result in a working code-server without any broken in-between states otherwise they are difficult to test and modify.
- Add your changes to the patch (
quilt refresh) - Add a comment in the patch about the reason for the patch and how to reproduce the behavior it fixes or adds. Every patch should have an e2e test as well.
Build
You can build a full production release as follows:
git submodule update --init
quilt push -a
npm install
npm run build
VERSION=0.0.0 npm run build:vscode
KEEP_MODULES=1 npm run release
You can omit KEEP_MODULES if you intend to use this in a platform-agnostic way
(like for publishing to NPM), but since the VS Code build process does
post-processing deletion of the modules, it is recommended to keep the modules
when possible, since if you install them later you will have more than is
required. KEEP_MODULES will also bundle Node and the code-server entry script.
Run your build:
./release/bin/code-server
Or if you omitted KEEP_MODULES:
cd release
npm install --omit=dev
node .
Then, to package the release:
npm run package
On Linux, the currently running distro will become the minimum supported version. In our GitHub Actions CI, we use CentOS 8 for maximum compatibility. If you need your builds to support older distros, run the build commands inside a Docker container with all the build requirements installed.
Troubleshooting
I see "Forbidden access" when I load code-server in the browser
This means your patches didn't apply correctly. We have a patch to remove the auth from vanilla Code because we use our own.
Try popping off the patches with quilt pop -a and reapplying with quilt push -a.
"Can only have one anonymous define call per script"
Code might be trying to use a dev or prod HTML in the wrong context. You can try
re-running code-server and setting VSCODE_DEV=1.
Help
If you get stuck or need help, you can always start a new GitHub Discussion here. One of the maintainers will respond and help you out.
Test
There are four kinds of tests in code-server:
- Unit tests
- Script tests
- Integration tests
- End-to-end tests
Unit tests
Our unit tests are written in TypeScript and run using Jest, the testing framework].
These live under test/unit.
We use unit tests for functions and things that can be tested in isolation. The
file structure is modeled closely after /src so it's easy for people to know
where test files should live.
Script tests
Our script tests are written in bash and run using bats.
These tests live under test/scripts.
We use these to test anything related to our scripts (most of which live under
ci).
Integration tests
These are a work in progress. We build code-server and run tests with npm run test:integration, which ensures that code-server builds work on their
respective platforms.
Our integration tests look at components that rely on one another. For example, testing the CLI requires us to build and package code-server.
End-to-end tests
The end-to-end (e2e) tests are written in TypeScript and run using Playwright.
These live under test/e2e.
Before the e2e tests run, we run globalSetup, which eliminates the need to log
in before each test by preserving the authentication state.
Take a look at codeServer.test.ts to see how you would use it (see
test.use).
We also have a model where you can create helpers to use within tests. See models/CodeServer.ts for an example.
Structure
code-server essentially serves as an HTTP API for logging in and starting a remote Code process.
The CLI code is in src/node and the HTTP routes are implemented in src/node/routes.
Most of the meaty parts are in the Code portion of the codebase under lib/vscode, which we describe next.
Modifications to Code
Our modifications to Code can be found in the patches directory. We pull in Code as a submodule pointing to an upstream release branch.
In v1 of code-server, we had Code as a submodule and used a single massive patch that split the codebase into a front-end and a server. The front-end consisted of the UI code, while the server ran the extensions and exposed an API to the front-end for file access and all UI needs.
Over time, Microsoft added support to Code to run it on the web. They had made the front-end open source, but not the server. As such, code-server v2 (and later) uses the Code front-end and implements the server. We did this by using a Git subtree to fork and modify Code.
Microsoft eventually made the server open source and we were able to reduce our
changes significantly. Some time later we moved back to a submodule and patches
(managed by quilt this time instead of the mega-patch).
As the web portion of Code continues to mature, we'll be able to shrink and possibly eliminate our patches. In the meantime, upgrading the Code version requires us to ensure that our changes are still applied correctly and work as intended. In the future, we'd like to run Code unit tests against our builds to ensure that features work as expected.
We have extension docs on the CI and build system.
If the functionality you're working on does NOT depend on code from Code, please move it out and into code-server.
Currently Known Issues
- Creating custom Code extensions and debugging them doesn't work
- Extension profiling and tips are currently disabled