Commit graph

11061 commits

Author SHA1 Message Date
Alok Saboo
f655cd24c2 Add youtube tag source 2023-05-12 09:58:04 -04:00
Benedikt
8fc3ddee27
Merge pull request #4775 from wisp3rwind/pr_update_ci_python
CI: update python versions
2023-05-07 19:22:33 +02:00
wisp3rwind
89b7e1d864 dbcore: bail out if the database does't support multi-threading
which we rely on. This test doesn't actually work for Python < 3.11,
since Python used to hardcode the threadsafety value to 1
2023-05-07 18:43:43 +02:00
wisp3rwind
7169ac81f5 tests: close library in ParentalDirCreation test 2023-05-07 18:43:43 +02:00
wisp3rwind
5de1d12610 tests: address some warnings
- some helper functions were incorrectly detected as being tests due to
  their name
- use of the deprecated assertEquals alias
2023-05-07 18:43:43 +02:00
wisp3rwind
6f0d305489 tests: more explicit sqlite3 connection close()ing 2023-05-07 18:43:43 +02:00
wisp3rwind
0d1fa172de tests: explicitly close sqlite3 connections
on Python 3.11, the Windows CI started crashing due to the database file
remainig open unexpectly in test shutdown; this attemps to fix that
2023-05-07 18:43:43 +02:00
wisp3rwind
74e1acf6e3 ci: update python versions
(try to) use semver x-ranges in order to avoid needing manual updates of
this in the future
2023-05-07 18:43:43 +02:00
Adrian Sampson
0485cb357a
Merge pull request #4781 from wisp3rwind/pr_partial_revert_4774
fetchart: revert a cleanup from #4774 that could break plugins
2023-05-07 08:33:10 -07:00
wisp3rwind
f5b20114b4 fetchart: revert a cleanup from 4774 that could break plugins
cf. @arogl's comment 254bb297c8 (commitcomment-111922347)

> Now that this has been merged, external plugins that add to the fetchart plugin now fail with:
>
> ```AttributeError: module 'beetsplug.fetchart' has no attribute 'SOURCES_ALL'``
2023-05-05 20:36:28 +02:00
J0J0 Todos
cad9c42c5a
Merge pull request #4779 from arsaboo/fix_reimports 2023-05-02 14:41:06 +02:00
Alok Saboo
e1cf230cc2 Fix #4776 2023-05-02 08:25:52 -04:00
Adrian Sampson
0753f47e3e
Merge pull request #4774 from wisp3rwind/pr_fetchart_cleanup
fetchart: Move some source-specific code from base plugin into source classes
2023-05-01 21:20:08 -07:00
wisp3rwind
d236747587 fetchart: add add_default_config() method to sources
in order to move the remaining source-specific code out of plugin
initialization and into the source classes
2023-04-30 10:15:40 +02:00
wisp3rwind
254bb297c8 fetchart: add available() method to sources
in order to move (some of) the source-specific code out of plugin
initialization and into the source classes
2023-04-30 10:04:54 +02:00
Benedikt
843fbcbaa0
Merge pull request #4771 from arsaboo/spotify_fetch
Add spotify as a fetchart source
2023-04-30 09:32:42 +02:00
Alok Saboo
44751b020e Merge remote-tracking branch 'upstream/master' into spotify_fetch 2023-04-29 08:45:15 -04:00
Benedikt
567c3f06f7
Merge pull request #4772 from wisp3rwind/pr_fix_web
web: fix for breaking werkzeug change
2023-04-29 11:48:52 +02:00
wisp3rwind
4ae1e8278c web: fix for breaking werkzeug change
cf. https://github.com/pallets/werkzeug/issues/2506

didn't check when part_isolating was introduced, but presumably, it
should be harmless to set this attribute for old werkzeug versions that
didn't have it yet
2023-04-29 11:37:46 +02:00
Alok Saboo
d4eb3a6b82 Update fetchart.py 2023-04-28 18:05:27 -04:00
Alok Saboo
067a3633d3 Change error handling 2023-04-28 18:02:17 -04:00
Alok Saboo
731015b6d5 Update docs 2023-04-28 11:05:26 -04:00
Alok Saboo
718f682d76 Update changelog.rst 2023-04-28 08:57:29 -04:00
Alok Saboo
34fe9344ae change preposition 2023-04-28 08:50:01 -04:00
Alok Saboo
654b57f50a Make beautifulsoup optional 2023-04-28 08:47:32 -04:00
Alok Saboo
036667c51e change variable to lower case 2023-04-27 18:13:39 -04:00
Alok Saboo
18bcadcfdc Add spotify art source 2023-04-27 18:10:09 -04:00
J0J0 Todos
2bcf16b10c Fix linter error in test_embedart 2023-04-22 08:23:38 +02:00
J0J0 Todos
997e8a8440 Fix m3u8 wikipedia link in convert plugin docs 2023-04-21 22:12:17 +02:00
J0J0 Todos
8af31058e8 Fix a typo in test_embedart 2023-04-21 21:56:42 +02:00
J0J0 Todos
f6b0311221
Merge pull request #4719 from arsaboo/embedart_url
Added option to embedart using an image URL [small PR]
2023-04-21 21:52:04 +02:00
J0J0 Todos
56adba719b Fix text/html file ending in embedart -u test
Makes it more clear what we are doing.
2023-04-21 21:22:27 +02:00
J0J0 Todos
f3d4929638 Fix embedart -u test names
and shorten second and third test a little by providing -y cli flag. Enough to
test with interactive input once. Move all 3 tests to the very bottom of the
test class.
2023-04-21 20:12:16 +02:00
Alok Saboo
47cb11bad7 Add test for invalid URL 2023-04-21 08:31:36 -04:00
Alok Saboo
919f326400 Add test for png image 2023-04-21 08:23:12 -04:00
Alok Saboo
d48eab9ac1 Updated language 2023-04-21 07:58:37 -04:00
J0J0 Todos
3dd32c93dc Add test for embedart -u fetching jpeg from url 2023-04-21 07:59:16 +02:00
Alok Saboo
bb2ce02e07 Remove logging 2023-04-18 20:54:43 -04:00
J0J0 Todos
6e38ba68f8
Merge pull request #4735 from JOJ0/flex_attr_preserve
Fix data_source not updated on re-import and refactor `reimport_metadata`
2023-04-18 14:03:43 +02:00
J0J0 Todos
9f71e42c80 Fix album vs. item magic in reimport_metadata helper 2023-04-18 13:50:42 +02:00
J0J0 Todos
3f72e28606 Finalize reimport_metadata refactor
- Decide on final logging output wording and streamline code formatting
- Slightly shorten helper function docstring
2023-04-18 12:32:19 +02:00
Alok Saboo
0492f1f214 Address comments 2023-04-14 08:10:13 -04:00
Alok Saboo
1e3fee8495 Use temp folder instead of cwd 2023-04-14 08:08:59 -04:00
J0J0 Todos
8bac74480c Helper function for reimport flex attr preserving
Flexible attribute keys listed in REIMPORT_FRESH_FIELDS_* are now removed from
the original LazyConvertDict in a separate function which is used for both
album and item level fields.
2023-04-14 06:11:42 +02:00
J0J0 Todos
04628ada96 Module-level constants for reimport_metadata() 2023-04-13 20:43:14 +02:00
J0J0 Todos
1bde0dabf2 Add changelog for #4735 2023-04-11 07:11:20 +02:00
J0J0 Todos
af7a4258c5 Improve logging in reimport_metadata, early exits
- Early exits in loops when no new value is incoming.
- Streamline and improve log messages:
  - "Reimported" vs. "Not reimported"
  - Album/Item ID at the beginning.
  - Path at very end.
  - Separate regular attrs from flex attrs.
2023-04-11 07:11:20 +02:00
J0J0 Todos
efc88193f9 Add test_reimported_album_not_preserves_flexattr
Checks if a reimported album flexible attribute "data_source" will be updated
correctly from the match being applied.
2023-04-11 07:11:20 +02:00
J0J0 Todos
42aa989e2d Refactor reimport_metadata, fix data_source update
- Refactor preserving of flexible attributes in the importer's
  reimport_metadata() method.
- New logging message when flex attrs are excluded from the preserving process.
- Fix data_source album/item flex attr not updated on a reimport.
2023-04-11 07:11:20 +02:00
Alok Saboo
023f3d7df7 Merge remote-tracking branch 'upstream/master' into embedart_url 2023-04-09 15:11:21 -04:00