Commit graph

7351 commits

Author SHA1 Message Date
nathdwek@laptop
e94676e322 Refactor match_by_id:
* Drop reduce
* Readability
2016-10-22 10:37:53 +02:00
Dang Mai
f91362a069 Cosmetic refactors based on feedback 2016-10-21 16:56:03 -04:00
Dang Mai
8d07bfe693 Documentation for new flag 2016-10-20 23:33:20 -04:00
Dang Mai
f42f558db2 Fix long line for flake8 2016-10-20 21:21:50 -04:00
Dang Mai
406f3ce843 Add tests and make sure they pass 2016-10-20 21:07:12 -04:00
Dang Mai
f17601e4cd Fix update test failures 2016-10-20 20:25:38 -04:00
Dang Mai
679918f191 Fix some test failures 2016-10-20 00:28:28 -04:00
Dang Mai
acd2b0ef77 First attempt for selective field updates 2016-10-20 00:04:07 -04:00
Diego M. Rodríguez
6402e05d5a Merge pull request #2228 from diego-plan9/discogs-disc0
discogs: set `track.medium` correctly for single medium albums
2016-10-19 14:58:55 +02:00
Diego Moreda
2604bc8e73 discogs: update changelog for medium 2016-10-17 20:02:39 +02:00
kooimens
373cf19f8b Fix discogs disc field is set to zero
Fixes #587. The disc field is only zero when there is only one medium, so I think this will do the trick. I wasn't able to reproduce the real problem within the code. This is just a small workaround.
2016-10-17 19:51:03 +02:00
Diego Moreda
fc9f061574 discogs: add tests for medium, medium_total
Add three tests for the setting of tracks' medium and medium_total on
the discogs plugin. test_parse_medium_numbers_single_medium is meant
to fail due to #587.
2016-10-17 19:48:06 +02:00
Diego M. Rodríguez
89c40914a5 Merge pull request #2222 from diego-plan9/discogs-fixes
Several discogs fixes
2016-10-17 16:55:43 +02:00
vapniks
44f33cabc7 Update _beet
update documentation
2016-10-10 19:45:03 +01:00
Diego Moreda
1f4bef9e61 discogs: docstring style fix 2016-10-10 20:30:21 +02:00
Diego Moreda
c5ae9c5bee discogs: update changelog 2016-10-10 20:27:42 +02:00
Diego Moreda
f4907ca5d0 discogs: handle nested subtracks, add try block
Modify coalesce_tracks() in order to handle the case where subtracks
are defined inside an index track (as `sub_tracks` attribute),
reorganizing the if logic to avoid duplicated code.

Add a try..catch block enclosing the call to clean_tracklist, as a
measure for avoiding side effects (and reverting to just parsing the
raw_list if there are any problems).
2016-10-10 19:59:42 +02:00
Diego Moreda
fb398c5f2c discogs: add medium_total to tracks (#415) 2016-10-10 17:46:41 +02:00
Diego Moreda
1148acaaf1 discogs: revise position regexp, add tests, tox
Revise the regular expression used for extracting information from a
discogs position, making the subtrack_index only be matched if one of
the other groups is matched as well. Split the definition into several
lines in order to try to document it a bit more clearly.
Add unit tests for position parsing and non standard positions.
Fix the underscore on tox dependency.
2016-10-10 17:42:27 +02:00
Diego Moreda
e7f2a111e4 discogs: add test dependencies, fix spelling 2016-10-09 17:57:36 +02:00
Adrian Sampson
13cf1bff8f Tiny text simplifications (#2223) 2016-10-08 18:41:16 -04:00
Nathan Dwek
4b88a879eb Merge pull request #2223 from beetbox/doc-play-small-fixes
Misc fixes to play documentation.
2016-10-08 20:44:26 +02:00
nath@home
8bd6181c6a doc-play: Fix a header level. 2016-10-08 14:47:38 +02:00
nath@home
f30c5da2ab doc-play: Fix an error and clarity:
{} is not used any more to determine the location of parameters
passed with --args.
Fix two sentences for clarity/fluidity. Display the plugin's
abilities in the intro.
2016-10-08 14:37:57 +02:00
Diego Moreda
be223d966e discogs: coalesce subtracks (#1543)
Detect subtracks and merge them into a single track, taking into account
the index tracks if present. This includes a revision of the regular
expression used for converting a discogs "position" into medium, medium
index and subtrack index pieces, following the standard discogs
positions (12.2.9).
2016-10-07 19:09:09 +02:00
Diego Moreda
c55885c9e8 discogs: take into account two-sided media (#1762)
Revise the discogs plugin so two-sided mediums are taking into account
and each pair of consecutive *sides* is treated as single *medium*.
2016-10-07 19:01:50 +02:00
Diego Moreda
1c63d0bbab discogs: add more unit tests
Add unit tests covering the discogs standard positions (12.2.9). Clean
up a bit the helper methods (unused parameters, documentation).

https://www.discogs.com/help/submission-guidelines-release-trk.html#Position
2016-10-07 18:44:55 +02:00
Diego Moreda
911117ef49 discogs: set media on tracks (#1921)
Set the media for all the tracks when fetching a release using discogs,
as autotag.apply_metadata requires it in order to work properly.
2016-10-06 19:49:43 +02:00
Diego Moreda
9c88998a5d discogs: add initial unit test skeleton
Add a first skeleton for providing unit tests for the discogs plugin,
heavily inspired by test_mb, which adds a couple of method for creating
very simple and not comprehensive Bags that mimic discogs_client.Release
and discogs_client.Track.
Add a test for checking the problem of setting media for the Tracks.
2016-10-06 19:31:55 +02:00
Diego M. Rodríguez
9dcd4f7367 Merge pull request #2213 from diego-plan9/template-comma-behaviour
Revise comma handling on templates
2016-10-04 18:17:49 +02:00
Diego Moreda
f0a14bfdd5 Fix documentation issues for %first
Fix a formatting problem related to sphinx not allowing spaces at the
beginning or end of an inline literal, and removed an extra sentence
at th end of the %first template function documentation.
2016-10-04 16:20:52 +02:00
Diego Moreda
0eb0353453 Revise documentation for commas in Parser 2016-10-04 16:17:26 +02:00
Diego Moreda
550206adb5 Add changelog for unescaped commas in Parser 2016-10-03 23:31:47 +02:00
Diego Moreda
c5da6296c4 Use flag instead of subclass for comma in Parser
Use a `in_argument` flag on Parser constructor for specifying if the
parser should treat commas as a special character, including the logic
in parse_expression.
2016-10-03 23:01:50 +02:00
Diego M. Rodríguez
36bc800309 Merge pull request #2215 from diego-plan9/types_queries
Do not attempt matching unset fields on DateQuery
2016-10-03 20:58:20 +02:00
Diego Moreda
b9b6dc47d1 Add changelog for #1938 2016-10-03 20:43:35 +02:00
Diego Moreda
bc8f422433 Do not attempt matching unset fields on DateQuery
Add a comparison at DateQuery.match in order to avoid comparing if the
field is not in the item.
Revise the existing types_plugin unit tests for explicitely checking the
behaviour when the values are unset.
2016-10-03 19:52:44 +02:00
vapniks
8671c83817 Delete _beet_cached 2016-10-02 19:54:39 +01:00
vapniks
5282d2882e Automatically generate cache file
This makes updating cache files easier; you just delete the old one and try completing again.
2016-10-02 19:54:10 +01:00
Diego Moreda
3e82007036 Add ArgumentParser, taking into account commas
Add ArgumentParser as a subclass of Parser that considers ARG_SEP a
special character (ie. always needs escaping, terminates a block); and
use it for parsing the substring that contains the list of arguments at
parse_argument_list().
2016-10-02 19:44:13 +02:00
Diego Moreda
657a711f17 Remove comma from special chars, class variables
Remove ARG_SEP from Parser.special_chars, and promote some groups of
characters used in parse_expression to class variables.
ARG_SEP is still considered an "escapable" character, pending a decision
on whether both escaped ('$,') and unescaped (',') syntax would be
allowed.
2016-10-02 19:36:32 +02:00
Diego Moreda
518c6b8801 Add tests for comma outside functions in templates
Add unit tests for the use of the separator special character (comma)
outside a function argument.
2016-10-02 19:17:56 +02:00
vapniks
be69f52b69 Update _beet_cached 2016-10-02 16:31:02 +01:00
vapniks
873a6251af Update comments in _beet_cached 2016-10-02 16:29:36 +01:00
vapniks
df3a4317a6 Cached completion file (faster)
A cached completion file for faster initial completions.
Completes the following plugins: fuzzy play info lyrics fromfilename check lastgenre badfiles chroma edit smartplaylist
2016-10-02 16:27:22 +01:00
vapniks
9dc79950d3 Update comments section of _beet
More accurate instructions on how to create a cached completion file (previous instructions where incorrect)
2016-10-02 16:20:55 +01:00
Johnny Robeson
8d7a626074 Move timeout config getter to library from dbcore
I wanted to move it up even higher, but I wanted to hold off on that
for a bit longer.
2016-10-01 05:01:55 -04:00
vapniks
c1e04ac039 Update _beet
Some fixes to make it work with new plugins
2016-09-29 15:05:50 +01:00
Adrian Sampson
4ae02e0d27 Merge pull request #2211 from heylookltsme/better-genre
Proposal: Add specificity option to lastgenre plugin
2016-09-27 09:07:39 -04:00
Corinne Hoener
a7e3bf2d0b third time's a charm 2016-09-27 06:21:51 -04:00