Commit graph

7351 commits

Author SHA1 Message Date
xarph
edd34267c6 modify DestinationTest.test_asciify_and_replace to include unicode
titles that decode to path separator.

Added an empty .mp3 file with problematic characters for asciify_paths
in id3v2 tags for future tests if needed.
2016-12-03 15:29:27 -08:00
xarph
fcc6c6bc80 Merge branch 'master' of https://github.com/beetbox/beets 2016-12-03 14:53:02 -08:00
Adrian Sampson
991c9936fd Fix #2299: non-Unicode logging in badfiles 2016-12-03 11:20:06 -05:00
Adrian Sampson
957bfacf21 Fix Backbone.js link 2016-11-30 08:40:15 -05:00
Adrian Sampson
d08baa4c91 Merge pull request #2295 from musoke/patch-1
Fix rst syntax error in docs
2016-11-28 18:12:38 -05:00
Nathan Musoke
0701e66391 Fix rst syntax error in docs 2016-11-29 12:11:12 +13:00
xarph
c3e63084d2 fix for unidecode converting ¢ into C/, ruining paths. 2016-11-26 23:08:35 -08:00
Adrian Sampson
9de27c6b70 Sync up with separate MediaFile repository 2016-11-26 20:48:12 -05:00
Adrian Sampson
d8c0a42e6c Avoid TestHelper dependency in MediaFile tests
Part of #1966. This also introduces a nicer, more lightweight way to create and
destroy temporary directories, decoupling that functionality from the
giant morass that is TestHelper.
2016-11-26 18:55:58 -05:00
Adrian Sampson
a88682e7bb Undo from _common import unittest indirection
This was a vestige from when we used to need the unittest2 library for pre-2.7
compatibility. Now that we require Python 2.7, we aren't using that library
and this indirection wasn't doing any good.
2016-11-26 18:46:44 -05:00
Adrian Sampson
24940c0de7 In MediaFile tests, use simpler import path
This will make it easier to copy these tests into their own repository.
2016-11-26 18:27:20 -05:00
Adrian Sampson
788654736d Obviate the need for a beets utility in MF tests
Even more on #1966.
2016-11-26 18:26:18 -05:00
Adrian Sampson
47049e1ff1 Avoid one last beets utility in MediaFile tests
This is a little dirty, what with the hard-coded encoding, but I don't feel
too bad about it because we're only manipulating our test fixtures and
temporary directory that way.

More on #1966.
2016-11-26 18:23:46 -05:00
Adrian Sampson
54cb0b2a15 Separate beets-specific MediaFile tests
Part of the #1966 separation effort.
2016-11-26 18:08:00 -05:00
Adrian Sampson
2cc1a61ea4 MediaFile: Remove one last utility function (#1966) 2016-11-26 17:40:40 -05:00
Adrian Sampson
075a4b6b85 MediaFile: Avoid using some beets utilities
Modularization: #1966
2016-11-26 17:37:01 -05:00
Adrian Sampson
c70a9bb873 Enable Python 3 tests by default in Tox config
Now that we're supporting it, I plan to run the Python 3 tests as part of
my normal coding workflow.
2016-11-26 17:32:49 -05:00
Adrian Sampson
fc6658c110 Add a missing __future__ import 2016-11-26 17:31:54 -05:00
Adrian Sampson
692dea39e8 MediaFile: Use stock logging
This is part of the effort to separate MediaFile from beets (#1966). It avoids
using the beets-specific logging infrastructure. This commit is part of
fdebab657d6e85de56b3996e8fdece09796940ae from the new MediaFile repository.
2016-11-26 17:30:02 -05:00
Adrian Sampson
cf5fa501e2 Version bump: 1.4.2 2016-11-25 22:16:03 -05:00
Adrian Sampson
839a316673 Change released version to 1.4.1
Sadly, I uploaded the wrong file to PyPI for 1.4.0. Once you do this, PyPI
never lets you change the file associated with a given released version. So we
need to use 1.4.1 instead. 😢
2016-11-25 22:13:54 -05:00
Adrian Sampson
60ec732e10 Version bump: 1.4.1 2016-11-25 21:38:06 -05:00
Adrian Sampson
d99b46612f Fix version bumping in release.py 2016-11-25 21:37:25 -05:00
Adrian Sampson
d54ef99ea5 Fix a forgotten test 2016-11-25 21:33:44 -05:00
Adrian Sampson
8d902c0da3 Release date for 1.4.0 2016-11-25 21:29:06 -05:00
Adrian Sampson
9fb358d3c0 Even more little changelog fixes 2016-11-25 21:28:41 -05:00
Adrian Sampson
e15bee15f5 More changelog proofreading 2016-11-25 21:11:54 -05:00
Adrian Sampson
55d9233e39 Capitalize Python 2016-11-25 21:06:01 -05:00
Adrian Sampson
bdfa53c503 Changelog updates and proofreading 2016-11-25 21:05:34 -05:00
Adrian Sampson
f31e6110e6 Simplify #2280 docs
I've backed out the FAQ entry, since the main docs seem like the right place
for this.
2016-11-24 23:59:00 -05:00
Adrian Sampson
d6b15f4eaa Remove duplicated line in docs (#2280)
For consistency: we don't show the aliases here for the other commands.
2016-11-24 23:51:10 -05:00
Adrian Sampson
5d74e1c07e Merge pull request #2280 from pkess/selective_modify_doc
Extra documentation for #1843
2016-11-24 23:50:43 -05:00
Peter Kessen
488225d837 Added documentation and FAQ for selective modify 2016-11-24 19:41:31 +01:00
Peter Kessen
9f48338291 Corrected docs for modify command
added short form ´mod´ and added switch ´-f´
2016-11-24 19:04:42 +01:00
Nathan Dwek
31b23207a8 Merge pull request #2249 from beetbox/generators-decorators-core
[WIP]Use generators and decorators to match items:
2016-11-21 23:19:18 +01:00
nathdwek@laptop
7dc458aaf5 tagger: finish generator-decorator simplifications
* Propagate generators upwards without realizing them
* Use plugins.notify_info_yielded decorator
2016-11-21 13:43:00 +01:00
nathdwek@laptop
6e3a9d9bc5 collect search results from plugins with yield 2016-11-21 13:39:44 +01:00
nathdwek@laptop
a7fed5b2c4 plugins: document notify_info_yielded 2016-11-21 10:15:51 +01:00
nathdwek@laptop
2b468c1872 plugins: make the signature of notify_info_yielded clearer 2016-11-21 10:15:51 +01:00
nathdwek@laptop
91d1aa9763 plugins: rename notify_info_received->notify_info_yielded 2016-11-21 10:15:51 +01:00
nathdwek@laptop
18a14e8005 Use generators and decorators to match items:
The easy parts
2016-11-21 10:15:51 +01:00
Nathan Dwek
871a815281 Merge pull request #2251 from beetbox/drop-reduce
acousticbrainz: refactor plugin
2016-11-20 23:03:41 +01:00
nath@home
147ced9eaa acousticbrainz: latest adjustments
* Readability and consistency
* Better logging: warn by default for attributes that were not found,
  but don't drown user with info when everything is going well.
2016-11-20 22:45:07 +01:00
nathdwek@laptop
eb1ea6177d acousticbrainz: drop DefaultList, be explicitly careful
* I don't see DefaultList be really helpful in many other cases, so having
  a beets.util.collections module (which could also conflict with the collections
  module from standard library) with only that in it is a little silly.
* It was elegant and concise, but there are implementation issues: it is not
  recommended to subclass builtin types, but the alternatives differ between python
  2 and 3 (subclass sequence or container or collections.abc?), moreover,
  interpreters can differ in the way they map syntaxic sugar to magic functions.
* Also, slicing and negative indexing could do weird things, so the class wouldn't
  be really intuitive and simple at the same time
2016-11-20 22:03:41 +01:00
nathdwek@laptop
51243240f6 acousticbrainz: Test _map_data_to_scheme with real data 2016-11-20 22:03:41 +01:00
nath@home
4586e2df5a acousticbrainz: Add unit tests 2016-11-20 22:03:41 +01:00
nathdwek@laptop
1d972b9907 acousticbrainz: rewrite _map_dict_to_scheme:
* Less lazy names
* Separate root function from childs more naturally
* Actually use defaultdict
2016-11-20 22:03:41 +01:00
nathdwek@laptop
324c67191d acousticbrainz: log fetched attributes and values as info 2016-11-20 22:03:41 +01:00
nathdwek@laptop
3979619f9f acousticbrainz: remove redundant comments 2016-11-20 22:03:41 +01:00
nath@home
7a676400dc acousticbrainz: Refactor the json handling part 2016-11-20 22:03:41 +01:00