Commit graph

7351 commits

Author SHA1 Message Date
Johnny Robeson
38ec80b35e functemplate AST: only encode ident names on py2
They are passed as `unicode` types, but the AST only accepts py2
strings.
2016-08-30 03:42:29 -04:00
Johnny Robeson
4b7a44a9b5 functemplate AST: use py2/3 compatible string type
It was previously forced to `unicode`, but now uses the appropriate
string type for the executing Python version.
2016-08-30 03:40:51 -04:00
Adrian Sampson
65c65ae8f7 Merge pull request #2179 from stefanor/tyop
Correct a typo
2016-08-29 16:34:08 -07:00
Stefano Rivera
bcb1f8036a Correct a typo
Spotted by lintian which runs spellchecks on man pages.
2016-08-29 16:29:32 -07:00
Johnny Robeson
cda239a06d pass arguments to FunctionDef as keyword args
This makes it a lot easier to read.
2016-08-29 18:31:43 -04:00
Johnny Robeson
15be20c701 Compare case insensitive paths with SUBSTR and BYTELOWER
Create a custom `bytelower` sqlite function so we can compare bytestrings in a semi
case insensitive fashion.  This is to work around sqlite builds are that compiled
with `-DSQLITE_LIKE_DOESNT_MATCH_BLOBS`.

See https://github.com/beetbox/beets/issues/2172 for details.
2016-08-29 17:24:53 -04:00
nathdwek@laptop
ed0adc2b63 Add more doc and changelog for #2175 2016-08-26 18:18:35 +02:00
nathdwek@laptop
3acd44260a Apply #2175 to mpdstats to keep consistency 2016-08-26 18:17:37 +02:00
Nathan Dwek
c872adf5ca Merge pull request #2175 from tarruda/mpdupdate-use-mpd_host
mpdupdate: Use `$MPD_HOST` environment variable.
2016-08-26 16:57:24 +02:00
Thiago de Arruda
9963fd0432 mpdupdate: Support $MPD_HOST environment variable.
This environment variable is also used by mpc. See
http://linux.die.net/man/1/mpc for details.
2016-08-26 11:36:39 -03:00
Marvin Steadfast
5592499b31 embyupdate: backwards compatible hostname
`host` takes `localhost`, `http://localhost` and `https://`.
2016-08-26 12:28:48 +02:00
Marvin Steadfast
a282d4abc5 embyupdate: Fix authentication header problem
There was a problem with the authentication header in the latest
versions. The header creation function changed to fix that. Username and
passwort authentication should work again.

The `host` config variable takes now a full hostname. For example
`http://localhost` instead of just `localhost`. This makes it easier to
use https hosts.
2016-08-26 10:29:08 +02:00
Johnny Robeson
78171ee560 remove byte literals from art.py commands args
I'm not sure how i forgot these!
2016-08-25 04:08:05 -04:00
Johnny Robeson
6bedbd84df removebyte conversion/literals for command args
Paths are obviously untouched.

We definitely don't need these as they are entirely ascii.
2016-08-25 03:37:30 -04:00
Adrian Sampson
774d9c33b2 Merge pull request #2173 from stefanor/bundle-zsh
Include extra bits in the source distribution
2016-08-24 13:00:14 -07:00
Stefano Rivera
972ee4c5c5 Include extra bits in the source distribution 2016-08-22 23:54:36 -07:00
Johnny Robeson
4c4d8cff60 s/get(list)/as_str_seq() for keys in duplicates plugin
stolen from @sampsyo in the click branch
2016-08-17 02:18:48 -04:00
Adrian Sampson
e1d598aced Less verbose metavariable in --search-id help 2016-08-16 20:48:46 -04:00
Adrian Sampson
7061f7ff47 Use byte path consistently in hidden test (#2168) 2016-08-13 10:11:52 -04:00
Adrian Sampson
162bf6a594 Fix path handling in hidden module
Probably fixes #2168.
2016-08-13 09:54:25 -04:00
Adrian Sampson
0833c82075 web: Fix a crash related to byte paths on Python 3 2016-08-12 19:59:07 +00:00
Johnny Robeson
644cb86b24 Merge pull request #2167 from arogl/patch-1
Spelling update toke -> token
2016-08-12 02:24:21 -04:00
arogl
86d2129c52 Spelling update 2016-08-12 14:48:55 +10:00
Johnny Robeson
a98412bc0e Merge pull request #2151 from jrobeson/python3-windows-tests-test
Pass the tests on Windows
2016-08-11 22:31:06 -04:00
Johnny Robeson
72a55957a9 remove allow_failures for python 3.x from appveyor 2016-08-11 21:58:58 -04:00
Johnny Robeson
c26266cab0 convert byte args to string on PY3 in command_output
The strings are surrogateescaped to make sure we can get the bytes
representation back
2016-08-11 21:58:58 -04:00
Johnny Robeson
10d7a6f46a add -y to cinst command in appveyor.yml
[ci skip]
2016-08-10 21:29:08 -04:00
Johnny Robeson
bcc77f747b encode args before decode in convert_stub.py for py 3
We encode the args from `sys.argv` with `util.arg_encoding` to
make sure we have paths that cleanly open when running
`convert_stub.py` on Windows
2016-08-10 05:18:39 -04:00
Johnny Robeson
fb78830788 fix incorrect bytes() usages in replaygain
We encode the method and gain offset values to ascii.
2016-08-09 05:17:53 -04:00
Johnny Robeson
d32aa00154 remove bytes() on maxwidth in artresizer
This would definitely break on py3.
2016-08-09 04:34:40 -04:00
Johnny Robeson
d41949d326 close files we open, but forgot to close
This fixes all the obvious `ResourceWarning`s seen in the tests
2016-08-09 01:15:28 -04:00
Johnny Robeson
fcbfce3984 replace deprecated log.warn() with log.warning() 2016-08-09 00:33:38 -04:00
Johnny Robeson
5abbd3e590 Merge pull request #2163 from jrobeson/fix-edit-plugin-unicode-warning
decode yaml dumped data as utf-8 in edit plugin for PY2
2016-08-09 00:11:47 -04:00
Johnny Robeson
47bddb394c decode yaml dumped data as utf-8 in edit plugin for PY2
Yaml doesn't return a true unicode string even with `allow_unicode`
passed to `safe_dump_all`.
2016-08-08 23:59:54 -04:00
Johnny Robeson
19240f3ba8 Merge pull request #2159 from jrobeson/utf8-edit-plugin-yaml
Read and write edit plugin yaml as utf-8
2016-08-07 16:01:43 -04:00
Adrian Sampson
4c710e2bb6 Merge pull request #2156 from jrobeson/add-flake8-coding
add flake8-coding to our tox config
2016-08-07 14:39:51 -04:00
Johnny Robeson
303627e44f Read and write edit plugin yaml as utf-8 2016-08-07 06:12:48 -04:00
Johnny Robeson
08cd22834b add flake8-coding to our tox config
Now we can enforce that all py files have the coding magic comment with
utf-8.
2016-08-07 04:09:58 -04:00
Johnny Robeson
5b3cd44608 add coding: utf-8 magic comment to every .py file 2016-08-07 04:09:17 -04:00
Johnny Robeson
f04d928c6e Merge pull request #2154 from jrobeson/move-_arg_encoding-to-util
Move ui._arg_encoding to util.arg_encoding
2016-08-04 23:00:39 -04:00
Johnny Robeson
304df82361 rename/move ui._arg_encoding to util.arg_encoding
We use this for more than ui concerns, so it should be in util.

It is also no longer marked as a "private" method.
2016-08-04 17:16:11 -04:00
Adrian Sampson
f001c0c532 Require Mutagen 1.33
This simplifies the exception-handling story. It also clarifies exactly what's
going on, which I didn't fully realize before: Mutagen *never* raises IOError
anymore, even for IO-related errors, so MediaFile doesn't either.
2016-08-02 08:39:14 -04:00
Adrian Sampson
3d7c8810e7 Deduplicate Mutagen error handling code 2016-08-02 08:24:37 -04:00
Johnny Robeson
70b58c1905 use normpath() in all cases for assert_equal_path
This fixes issues with comparing string (via syspath) and bytestring paths on Windows.
2016-08-01 18:33:59 -04:00
Johnny Robeson
bb58a85083 Merge pull request #2146 from jrobeson/add-imagemagick-to-appveyor
install imagemagick on appveyor (via cholatey)
2016-07-31 21:16:46 -04:00
Adrian Sampson
39430764f3 Install command for NixOS (fix #2150) 2016-07-31 12:36:23 -04:00
Johnny Robeson
86cfe24d79 depend on six>=1.9 as it adds functions we need
1.9.0 is the release that added the `@py2_unicode_compatible` and the
3.x compatible unittest aliases we rely on
2016-07-31 03:59:44 -04:00
Johnny Robeson
8b21346fdd add changelog entry for python ver in beet --version 2016-07-31 02:56:26 -04:00
Johnny Robeson
15a8409535 add python version to beet --version 2016-07-31 02:48:07 -04:00
Johnny Robeson
ae21d3dcf5 install imagemagick on appveyor (via cholatey) 2016-07-30 23:14:09 -04:00