Bruno Cauet
bd29ab21e1
Delete outdated disabled test in test_library.py
...
TemplateTest.album_fields_override_item_values() never ran because of
its name (missing 'test_' prefix). When run it now fails for it targets
outdated functionality.
2015-01-25 21:38:29 +01:00
Adrian Sampson
258b63c566
Changelog for #1266
2015-01-24 10:39:06 -08:00
Adrian Sampson
bd81eb1660
Merge pull request #1266 from djl/playlistmkdirs
...
Fix bug where playlists were not created in subdirs.
2015-01-24 10:37:54 -08:00
David Logie
29de697a8d
Fix bug where playlists were not created in subdirs.
...
Playlist names containing path separators would cause beets to crash if
the parent directories for the playlist didn't already exist.
2015-01-24 13:00:25 +00:00
mried
54432d1698
Changelog for #1258 (file name of extracted art is taken from art_filename)
2015-01-24 10:46:32 +01:00
Adrian Sampson
07065b27b3
Merge pull request #1263 from brunal/embedart-better-extract
...
embedart: try extracting from items until success
Conflicts:
beetsplug/embedart.py
2015-01-23 11:00:49 -08:00
Adrian Sampson
1a48185b80
Changelog and style for #1260
2015-01-23 10:37:05 -08:00
Adrian Sampson
3336f56a6e
Merge pull request #1260 from kiefermat/index_error_on_unknown_cover_type
...
Fixed IndexError on reading embedded cover art with invalid cover type
2015-01-23 10:34:10 -08:00
Bruno Cauet
b30c6975a1
Embedart extraction: 'cover' is already the default
...
'cover' is already the default filename (in the absence of a custom
config) so there is no need to re-write that value in the embertart
plugin.
Improve #1258
2015-01-23 18:12:17 +01:00
Bruno Cauet
4a27f83223
embedart: try extracting from items until success
...
Don't stop at the first item but try them all.
Fix #1261
2015-01-23 17:48:37 +01:00
Malte Ried
b3803d3472
Extractart uses the configured art_filename. Closes #1258
2015-01-23 17:14:14 +01:00
Matthias Kiefer
b16898743d
Fixed IndexError on reading embedded cover art with invalid cover type
2015-01-23 13:44:08 +01:00
Bruno Cauet
268dcb0008
test.helper.log_capture() unicode handling
...
Except unicode message instead of bytes.
Fix #1253
2015-01-21 19:18:57 +01:00
Adrian Sampson
9655775b0b
Docs capitalization
2015-01-21 10:17:15 -08:00
Adrian Sampson
b3eca334eb
Merge branch 'master' of github.com:sampsyo/beets
2015-01-21 10:12:27 -08:00
Adrian Sampson
070d4feb62
Remove unused import
2015-01-21 10:10:47 -08:00
Bruno Cauet
d36ebf3e29
test_embedart: fix imports
2015-01-21 19:09:25 +01:00
Bruno
1eac878667
Doc: chroma plugin & virtualenvs
...
Mention --system-site-packages for the chroma plugin to work in virtualenvs.
2015-01-21 18:53:41 +01:00
Adrian Sampson
be7ffd9758
Merge pull request #1254 from andremiller/master
...
Replace print with _log.info() in CORS support
2015-01-21 09:38:37 -08:00
Adrian Sampson
6b11c6326e
embedart: Fix test for 433d6b7 ( #1252 )
2015-01-21 09:35:36 -08:00
Andre Miller
96e3d8b451
Replaced print with log.info
2015-01-21 19:31:02 +02:00
Adrian Sampson
77f51133aa
Fiddle with CORS dependency docs ( #1237 )
2015-01-21 09:17:53 -08:00
Adrian Sampson
433d6b7485
embedart: Error on non-existent -f file
...
Fixes #1252 .
2015-01-21 09:07:59 -08:00
Adrian Sampson
e0a48c6cf9
Expand changelog for #1246
2015-01-21 09:02:08 -08:00
David Logie
8ccd385d85
Add a note to the docs and changelog about the new -f/--format option for mbsync.
2015-01-21 08:08:34 +00:00
David Logie
f458549e4e
mbsync: Set default album/item format for tests.
2015-01-21 08:05:27 +00:00
David Logie
28f616f75d
mbsync: Remove unnecessary decorators.
2015-01-21 08:05:27 +00:00
David Logie
99e89a29e2
mbsync: Don't overwrite the format built-in.
2015-01-21 08:05:27 +00:00
David Logie
11a21e149e
mbsync: Improve tests.
...
* Move the "skipped item" tests to their own method.
* Add a test for the default format
2015-01-21 08:05:27 +00:00
David Logie
7db3e1d80c
mbsync: Fix bug where singletons always used the album format.
2015-01-21 08:05:27 +00:00
David Logie
3e9f716b68
Remove unused variable.
2015-01-21 08:05:27 +00:00
David Logie
1380ee79dc
Add basic test for custom mbsync formats.
2015-01-21 08:05:27 +00:00
David Logie
2fae94a93a
Make the Template object an attribute.
2015-01-21 08:05:26 +00:00
David Logie
3317580296
mbsync: Support custom output format.
2015-01-21 08:05:26 +00:00
Adrian Sampson
7e21c68487
Logging: pass through non-problematic values
...
9b83cef was a little too aggressive; we need most objects to go through
unconverted so '{0.title}' and such still work in format strings. This is now
just a targeted workaround for the case I encountered.
2015-01-20 16:28:42 -08:00
Adrian Sampson
9b83cef0de
Handle encoding misfortunes in logging ( #1248 )
...
The beets loggers now, as proposed in #1044 , do their utmost to avoid crashing
when logged values are not valid Unicode or Unicode-convertible. This came up
urgently when a `CalledProcessError` could not be logged with `'u{}'.format()`
(!!!) so we needed to some manner of conversion, but it should be possible to
log paths without `displayable_path`. In fact, it may be time to retire
`displayable_path` for the most part.
2015-01-20 16:17:59 -08:00
Adrian Sampson
770ffad638
Require mutagen 1.27
...
Avoid incorrect reporting of audio properties for MPEG-4 on earlier versions,
as in #1243 .
2015-01-20 15:30:28 -08:00
Adrian Sampson
1a151c2272
Remove redundant config rest in tests
...
teardown_beets resets the configuration already.
2015-01-20 15:22:59 -08:00
Adrian Sampson
f617d162cf
keyfinder: Better output parsing ( #1248 )
...
We were being sloppy about bytes output from the process. Also, it seems like
the tools outputs the path also, so it's necessary to break on whitespace to
actually get the key name.
2015-01-20 15:17:21 -08:00
Adrian Sampson
dae1776165
Reasonable logging for keyfinder command
...
Previously the command was completely silent.
2015-01-20 15:12:26 -08:00
Adrian Sampson
5586fcee67
keyfinder: Only write on import when asked to
...
This should really be standard machinery.
2015-01-20 15:11:13 -08:00
Adrian Sampson
b737102008
One-byte typo fix
2015-01-20 15:02:13 -08:00
Adrian Sampson
899365c4a9
Finish changing plugin name in docs ( #1186 )
2015-01-20 15:00:28 -08:00
Adrian Sampson
ea2474277a
Changelog/typo fix for filefilter ( #1186 )
2015-01-20 14:55:50 -08:00
Adrian Sampson
07f99e6ab7
Fix up tests for import_task_created ( #1186 )
2015-01-20 14:51:26 -08:00
Adrian Sampson
8e94419c2a
Fix filefilter ( #1186 ) tests for consistent colons
...
I added this to the pretend output a few commits ago.
2015-01-20 14:34:42 -08:00
Adrian Sampson
0a8dcadb75
Rename regexfilefilter to filefilter ( #1186 )
2015-01-20 14:32:22 -08:00
Adrian Sampson
ebc065ecec
Merge branch 'mried-import-filefilter'
...
Merge of PR #1186 .
2015-01-20 14:22:55 -08:00
Adrian Sampson
ec21fb8af1
Revert #1186 changes to beets core
...
The changes were:
- Return values from events.
- A new `import_task_created` event.
Both were added preemptively to master.
2015-01-20 14:22:43 -08:00
Adrian Sampson
a82f6c2d76
Docs tweaks and changelog for #1237 , fix #1236
2015-01-20 14:10:33 -08:00