Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2025-12-15 21:14:19 +01:00
Code Issues Projects Releases Wiki Activity

Fixed IndexError on reading embedded cover art with invalid cover type

Browse source
This commit is contained in:
Matthias Kiefer 2015-01-23 13:44:08 +01:00
parent 268dcb0008
commit b16898743d
3 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
beets/mediafile.py
View file

@ -326,7 +326,11 @@ class Image(object):
self.data = data
self.desc = desc
if isinstance(type, int):
type = list(ImageType)[type]
try:
type = list(ImageType)[type]
except IndexError:
log.warn("ignoring unknown image type index {}", type)
type = ImageType.other
self.type = type
@property

BIN
test/rsrc/image_unknown_type.mp3 Executable file
View file

Binary file not shown.

4
test/test_mediafile.py
View file

@ -730,6 +730,10 @@ class MP3Test(ReadWriteTestBase, PartialTestMixin,
'channels': 1,
}
def test_unknown_apic_type(self):
mediafile = self._mediafile_fixture('image_unknown_type')
self.assertEqual(mediafile.images[0].type, ImageType.other)
class MP4Test(ReadWriteTestBase, PartialTestMixin,
ImageStructureTestMixin, unittest.TestCase):