Adrian Sampson
1dc61491c6
Remove a bogus bash-completion path ( #2038 )
2016-06-08 09:36:00 -07:00
Adrian Sampson
77b0c17448
Merge pull request #2038 from bismark/patch-1
...
Support Homebrew's bash-completion2
2016-06-08 09:35:07 -07:00
Johnny Robeson
7c39462ae6
add a __bool__ to Results in db.py
2016-06-08 00:58:57 -04:00
Johnny Robeson
790b1b5153
replace some filter/map calls with list comps
...
These are places where the surrounding/calling code needs a list, not an iter.
2016-06-08 00:17:18 -04:00
Johnny Robeson
be474b3f52
wrap a call to filter in a list()
...
There are other filters like this in the master branch, but
2to3 converts them into list comprehensions. We'll deal with those
later
2016-06-06 17:26:06 -04:00
Johnny Robeson
f7f249f6c6
wrap map() in a list() where necessary for py3
...
It's slightly more inefficient during the py3 transition, but
I still think it's worth minimizing the diff for.
2016-06-06 17:10:21 -04:00
Adrian Sampson
8b62aa828c
Fix KeyFinder test assertion
2016-06-06 12:17:17 -07:00
Adrian Sampson
94372e87a8
Merge branch 'master' of github.com:sampsyo/beets
2016-06-06 11:54:33 -07:00
Adrian Sampson
90f4c77ea0
Skip permissions tests on Windows
2016-06-06 11:54:23 -07:00
Adrian Sampson
2322962cf8
Fix another sys.platform check
2016-06-06 11:51:32 -07:00
Adrian Sampson
8bf1f868fa
Fix comparison in a library type test
2016-06-06 11:46:51 -07:00
Adrian Sampson
a5b7489dd1
Use new assertion in config tests
2016-06-06 11:40:04 -07:00
Adrian Sampson
8359b9e90f
Tests: path equality assertion
2016-06-06 11:30:38 -07:00
Adrian Sampson
00dece4dc2
Shorter default envlist for tox ( #2035 )
...
Now just typing `tox` or `detox` runs some sensible defaults. (This excludes
Python 3 and coverage.) You can request other environments explicitly with
`-e`.
2016-06-06 11:22:53 -07:00
Adrian Sampson
b9845f29db
Capture convert's stderr
...
We were leaking errors to the console without this.
2016-06-06 11:16:50 -07:00
Adrian Sampson
1c1c73b062
Check for convert failures
2016-06-06 11:01:10 -07:00
Adrian Sampson
ad74da1149
Refactor similarity tests
...
The upshot is we can now compare the two Popen invocations
independently.
2016-06-06 10:58:25 -07:00
Adrian Sampson
a9573cea0c
Avoid Windows path prefix for ImageMagick
2016-06-06 10:21:30 -07:00
Adrian Sampson
bfa56b1d8d
Tests: fix mocking of art.extract
2016-06-06 10:08:30 -07:00
Ryan Johnson
2fed1cf3f2
formatting
2016-06-06 17:11:09 +01:00
Ryan Johnson
cf397277d2
Support Homebrew's bash-completion2
2016-06-06 12:23:42 +01:00
Adrian Sampson
5db8f69bc1
Fix invocation signature for check_art_similarity
...
The second argument is an Item, not a filename.
2016-06-05 12:37:05 -07:00
Adrian Sampson
746aecad2b
Fix a sys.platform check in hidden test
2016-06-05 12:28:47 -07:00
Adrian Sampson
60b4172a59
Tests: don't use None as a path stand-in
...
This triggered a crash in `syspath` on Windows.
2016-06-05 12:26:51 -07:00
Adrian Sampson
2021c82a8b
Remove an unused variable
...
That's what I get for coding on Windows without my flake8 plugin!
2016-06-05 12:23:40 -07:00
Adrian Sampson
b752a58ed6
Improve a couple of docstrings
2016-06-05 12:16:41 -07:00
Adrian Sampson
f1b81bc60c
Close all threads' connections
2016-06-05 12:14:50 -07:00
Adrian Sampson
574f3bc732
Main function closes its library
2016-06-05 12:03:30 -07:00
Adrian Sampson
2f9aa41614
Clean up SQLite connections in test harness
...
Windows complains that we can't remove the test database file if open
connections remain.
2016-06-05 11:56:09 -07:00
Johnny Robeson
42d642f1f6
use codecs module to decode to hex in _sc_decode
...
'hex' doesn't exist as a decoder for bytes in py3
2016-06-03 16:18:58 -04:00
Johnny Robeson
7ab0964826
add C901 (function complexity)to flake8 ignore list
...
I'm adding this both as a TODO item and to work around flake8 preferring
global ($HOME) configuration over project
2016-06-03 16:10:31 -04:00
Jack Wilsdon
96dfa37e40
Merge pull request #2035 from jackwilsdon/improve-tox-configuration
...
Update tox configuration
2016-06-03 14:02:07 +01:00
Adrian Sampson
a1030195f7
Expand changelog to cover 581fba6
2016-06-02 22:16:29 -07:00
Adrian Sampson
0051bdb506
lyrics: Avoid a spurious warning
2016-06-02 21:33:33 -07:00
Jack Wilsdon
fa7afba327
Remove basepython so any version can be used
2016-06-03 02:47:19 +01:00
Jack Wilsdon
10ce4fa8c5
Re-add min-version for flake8 in setup.cfg
2016-06-03 02:44:37 +01:00
Jack Wilsdon
bd93d66c47
Remove unneeded environment variables in tests
2016-06-03 02:42:50 +01:00
Johnny Robeson
e7f70c896d
check imagemagick output with bytes regex too
2016-06-02 21:34:35 -04:00
Jack Wilsdon
85864eb747
Add specific versions for environments in tox
2016-06-03 02:32:09 +01:00
Johnny Robeson
7467ebaaca
check for imagemagick in command_output with b\'
2016-06-02 21:27:09 -04:00
Adrian Sampson
d5f4c80894
Merge pull request #2034 from jrobeson/replace-__cmp__-with-rich-comparisons
...
Replace __cmp__ with rich comparisons for Distance
2016-06-02 17:17:37 -07:00
Jack Wilsdon
89088ad750
Remove unused pypy3 test ignore
2016-06-03 00:51:53 +01:00
Jack Wilsdon
82df8d18df
Update tox configuration
...
- Add support for Python 3 testing.
- Add Python 3.3, 3.4 and 3.5 tests to Travis and AppVeyor.
- Allow arguments to be passed to tox from test matrix.
- Simplify tox configuration so that we now only have `test`, `flake8`
and `docs` tasks.
2016-06-03 00:46:02 +01:00
Johnny Robeson
6c661c4327
Replace __cmp__ with rich comparisons for Distance
2016-06-02 19:27:22 -04:00
Adrian Sampson
ae7990322a
Merge pull request #2032 from pszxzsd/bs1770
...
make bs1770gain calculate sample peak instead of true peak
2016-06-02 16:17:04 -07:00
Johnny Robeson
9ed9faf246
add some b' to paths in sort tests
2016-06-02 18:52:32 -04:00
Adrian Sampson
581fba6288
lyrics: Avoid crash when enabling google
...
If you *both* haven't set an API key *and* BeautifulSoup wasn't
installed, the list.remove() call would crash. (This came up when
running the tests on a fresh machine without many dependencies.)
2016-06-02 11:58:14 -07:00
Adrian Sampson
2228e0e8e1
More binary-mode open in tests
2016-06-02 11:52:56 -07:00
Adrian Sampson
82640260c2
Tests: don't unload the beetsplug module
...
This was added in 1666f883e3 back in 2013. I'm
not sure why this *ever* worked to get beetsplug to point to the right
directory, but I believe it was superseded by the path manipulation in
aa07eb9551 , added in 2014. And now, it's causing
problems on Windows, where for some reason it's causing `import beetsplug.x`
to silently succeed but yield an empty `beetsplug`, without `x` in the
namespace.
2016-06-02 11:41:25 -07:00
Adrian Sampson
07c95a1bf1
Require an imaging backend for fuzzy ratio tests
...
These fail outright if we don't have a way to get image sizes (e.g.,
ImageMagick).
2016-06-02 11:39:05 -07:00