Johnny Robeson
bc88dae726
rework basestring check in BytesQuery
...
This makes it possible for this query to work in both py2 and py3,
since strings are bytes in py2
2016-06-18 02:35:43 -04:00
Johnny Robeson
33d451ed2d
switch basestring for bytes in HumanReadableException
...
We already check for unicode first, so this shouldn't cause any issues
on py2
2016-06-18 02:14:05 -04:00
Johnny Robeson
66431ab4de
treat tag values as strings in ReadWriteTestBase
2016-06-17 23:58:35 -04:00
Johnny Robeson
a1609ec548
use strings for *StorageStyle keys, not bytes
2016-06-17 23:39:17 -04:00
Johnny Robeson
ab27031360
handle byte values when _safe_cast out_type is float
2016-06-17 23:04:14 -04:00
Johnny Robeson
93e510c1c7
remove an unnecessary b' in test_fetchart
2016-06-17 05:26:21 -04:00
Johnny Robeson
4e2c2a9a2e
add noqa to py3 type checks
...
This prevents `F821 undefined name` warnings
2016-06-17 04:03:41 -04:00
Johnny Robeson
1c761c60fb
bytstringify extra cover_names in fetchart
2016-06-17 03:37:28 -04:00
Johnny Robeson
7dcf160d0b
make sure extract() in art handles bytestring paths
2016-06-17 02:37:08 -04:00
Johnny Robeson
fda3911323
bytestringify touch call in PathQueryTest
2016-06-17 02:00:20 -04:00
Johnny Robeson
4bbfe85c66
is_path_query takes unicode, so do that test_query
...
This fixes all but one instance that I'm not yet sure how to fix
2016-06-17 01:48:47 -04:00
Johnny Robeson
a0a9e2f22d
mark itunes library files as bytestrings
2016-06-17 01:40:16 -04:00
Johnny Robeson
60a961a751
remove an unnecessary .encode() in create_item_fixture
2016-06-17 01:20:42 -04:00
Johnny Robeson
cf5ab2617a
reorient bytestring_path code in convert replace_ext
2016-06-17 01:20:42 -04:00
Johnny Robeson
fff0439b06
add missing blank line in mpdstats
2016-06-17 00:09:22 -04:00
Johnny Robeson
12136e1d32
adapt is_url checking for bytestring paths
2016-06-17 00:00:08 -04:00
Johnny Robeson
1088df7242
bytestringify some more paths in test helper
2016-06-16 23:41:21 -04:00
Johnny Robeson
411e4957b0
bytestringify replace_ext in convert plugin
2016-06-16 23:40:59 -04:00
Johnny Robeson
3184599faa
compare bytes to bytes in library TemplateTest
2016-06-16 23:18:24 -04:00
Johnny Robeson
b602faabb8
more bytestringification in thumbnails plugin
2016-06-16 23:11:16 -04:00
Johnny Robeson
15c07613bf
decode the filename written to .desktop file
2016-06-16 23:04:52 -04:00
Johnny Robeson
52f2ab2547
encode uri passed to hashlib in thumbnails plugin
2016-06-16 23:00:45 -04:00
Johnny Robeson
a903b57dae
encode the passwords passed to hashlib in embyupdate
2016-06-16 21:47:10 -04:00
Johnny Robeson
36b3b20422
bytestringify test_lyrics
2016-06-16 21:34:52 -04:00
Jack Wilsdon
cb5db71a61
Merge pull request #2054 from Gondlar/patch-1
...
Clarify which fields are searched by default
2016-06-16 22:07:13 +01:00
Gondlar
3ea9706f4e
Clarify which fields are searched by default
2016-06-16 18:53:55 +02:00
Johnny Robeson
d3d52da012
bytestringify paths in filefilter plugin
2016-06-16 04:08:49 -04:00
Johnny Robeson
fd01faa241
add missing bytestring_path import :(
2016-06-16 04:02:19 -04:00
Johnny Robeson
4e5ac89b2a
bytstringify path in _mediafile_fixture
2016-06-16 04:00:43 -04:00
Johnny Robeson
167544bcbe
add F405 to flake8 ignore list
2016-06-16 02:43:01 -04:00
Johnny Robeson
cb54955485
more bytecasting in smartplaylist plugin
2016-06-15 23:55:17 -04:00
Johnny Robeson
7c77201857
bytestringify clutter/ignore paths in utils/__init__
2016-06-15 04:15:36 -04:00
Johnny Robeson
a02a1f0201
cast year ints to str, not bytes in bucket plugin
...
This seems to work equally well in py2/3
2016-06-15 03:34:03 -04:00
Johnny Robeson
7df59d5e30
catch codecs hex encoding errors too (from binascii)
...
binascii is used internally by codecs, and I didn't initially know that
2016-06-15 01:13:49 -04:00
Johnny Robeson
0385937647
complete more bytestrings in test_art
2016-06-15 00:10:20 -04:00
Johnny Robeson
be942c4595
complete more bytestrings in test_embedart
2016-06-15 00:10:01 -04:00
Johnny Robeson
4fbad7dd67
bytestringify path in file_filter
2016-06-14 23:17:08 -04:00
Johnny Robeson
a1314b7bda
move spotify test json to json files
2016-06-14 21:51:27 -04:00
Johnny Robeson
ba2cfcd329
bytestringify subdir paths in importer.albums_in_dir
2016-06-14 04:32:54 -04:00
Johnny Robeson
44380db6e8
If the permission is an int, then simply return it
...
It doesn't seem necessary to convert it, and if it does, then
we're missing a test
2016-06-14 03:50:29 -04:00
Johnny Robeson
8e1bc16228
set default perms as strings in perms plugin itself
...
I originally changed them to octal in my py3 branch,
but they are gonna end up as strings anyways, so I figured we should
just use them that way by default.
2016-06-14 03:47:59 -04:00
Johnny Robeson
0a5c6ce4c0
open tempfile in edit plugin in text mode
2016-06-14 03:38:21 -04:00
Johnny Robeson
4413e2ed94
make Distance a hashable object
...
It previously was hashable, until we added `__eq__`, so we must now do
it explicitly
2016-06-14 02:01:58 -04:00
Johnny Robeson
4b2c4ced6c
wrap extra_ops.keys() in a list in ui/commands
2016-06-14 01:55:47 -04:00
Johnny Robeson
ebff5a599c
treat filenames as bytestrings in perm plugin tests
2016-06-14 01:29:35 -04:00
Johnny Robeson
ef727854f1
treat default perms as str in permission plugin tests
2016-06-14 01:28:13 -04:00
Johnny Robeson
3112a18463
treat ctypes .value as bytes in thumbnails plugin
2016-06-14 00:51:12 -04:00
Johnny Robeson
8fa71f78fe
decode bytes from .encode() in lyrics plugin
2016-06-14 00:44:43 -04:00
Johnny Robeson
0f4b907ff5
wrap filter()s in a list() in replaygain plugin
2016-06-14 00:28:46 -04:00
Johnny Robeson
622945e2a9
wrap importer match keys in list() since we need one
2016-06-14 00:28:00 -04:00