Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2026-01-30 12:02:41 +01:00
Code Issues Projects Releases Wiki Activity

Fix invocation signature for check_art_similarity

Browse source 
The second argument is an Item, not a filename.
This commit is contained in:
Adrian Sampson 2016-06-05 12:37:05 -07:00
parent 746aecad2b
commit 5db8f69bc1
1 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
test/test_embedart.py
View file

@ -171,30 +171,31 @@ class ArtSimilarityTest(unittest.TestCase):
mock_extract.return_value = True
proc = mock_subprocess.Popen.return_value
log = logging.getLogger('beets.embedart')
item = _common.item()
# everything is fine
proc.returncode = 0
proc.communicate.return_value = "10", "tagada"
self.assertTrue(art.check_art_similarity(log, b'path', b'path', 20))
self.assertFalse(art.check_art_similarity(log, b'path', b'path', 5))
self.assertTrue(art.check_art_similarity(log, item, b'path', 20))
self.assertFalse(art.check_art_similarity(log, item, b'path', 5))
# small failure
proc.returncode = 1
proc.communicate.return_value = "tagada", "10"
self.assertTrue(art.check_art_similarity(log, b'path', b'path', 20))
self.assertFalse(art.check_art_similarity(log, b'path', b'path', 5))
self.assertTrue(art.check_art_similarity(log, item, b'path', 20))
self.assertFalse(art.check_art_similarity(log, item, b'path', 5))
# bigger failure
proc.returncode = 2
self.assertIsNone(art.check_art_similarity(log, b'path', b'path', 20))
self.assertIsNone(art.check_art_similarity(log, item, b'path', 20))
# IM result parsing problems
proc.returncode = 0
proc.communicate.return_value = "foo", "bar"
self.assertIsNone(art.check_art_similarity(log, b'path', b'path', 20))
self.assertIsNone(art.check_art_similarity(log, item, b'path', 20))
proc.returncode = 1
self.assertIsNone(art.check_art_similarity(log, b'path', b'path', 20))
self.assertIsNone(art.check_art_similarity(log, item, b'path', 20))
def suite():