Commit graph

13088 commits

Author SHA1 Message Date
Alok Saboo
34fe9344ae change preposition 2023-04-28 08:50:01 -04:00
Alok Saboo
654b57f50a Make beautifulsoup optional 2023-04-28 08:47:32 -04:00
Alok Saboo
036667c51e change variable to lower case 2023-04-27 18:13:39 -04:00
Alok Saboo
18bcadcfdc Add spotify art source 2023-04-27 18:10:09 -04:00
J0J0 Todos
2bcf16b10c Fix linter error in test_embedart 2023-04-22 08:23:38 +02:00
J0J0 Todos
997e8a8440 Fix m3u8 wikipedia link in convert plugin docs 2023-04-21 22:12:17 +02:00
J0J0 Todos
8af31058e8 Fix a typo in test_embedart 2023-04-21 21:56:42 +02:00
J0J0 Todos
f6b0311221
Merge pull request #4719 from arsaboo/embedart_url
Added option to embedart using an image URL [small PR]
2023-04-21 21:52:04 +02:00
J0J0 Todos
56adba719b Fix text/html file ending in embedart -u test
Makes it more clear what we are doing.
2023-04-21 21:22:27 +02:00
J0J0 Todos
f3d4929638 Fix embedart -u test names
and shorten second and third test a little by providing -y cli flag. Enough to
test with interactive input once. Move all 3 tests to the very bottom of the
test class.
2023-04-21 20:12:16 +02:00
Alok Saboo
47cb11bad7 Add test for invalid URL 2023-04-21 08:31:36 -04:00
Alok Saboo
919f326400 Add test for png image 2023-04-21 08:23:12 -04:00
Alok Saboo
d48eab9ac1 Updated language 2023-04-21 07:58:37 -04:00
J0J0 Todos
3dd32c93dc Add test for embedart -u fetching jpeg from url 2023-04-21 07:59:16 +02:00
Alok Saboo
bb2ce02e07 Remove logging 2023-04-18 20:54:43 -04:00
J0J0 Todos
6e38ba68f8
Merge pull request #4735 from JOJ0/flex_attr_preserve
Fix data_source not updated on re-import and refactor `reimport_metadata`
2023-04-18 14:03:43 +02:00
J0J0 Todos
9f71e42c80 Fix album vs. item magic in reimport_metadata helper 2023-04-18 13:50:42 +02:00
J0J0 Todos
3f72e28606 Finalize reimport_metadata refactor
- Decide on final logging output wording and streamline code formatting
- Slightly shorten helper function docstring
2023-04-18 12:32:19 +02:00
Alok Saboo
0492f1f214 Address comments 2023-04-14 08:10:13 -04:00
Alok Saboo
1e3fee8495 Use temp folder instead of cwd 2023-04-14 08:08:59 -04:00
J0J0 Todos
8bac74480c Helper function for reimport flex attr preserving
Flexible attribute keys listed in REIMPORT_FRESH_FIELDS_* are now removed from
the original LazyConvertDict in a separate function which is used for both
album and item level fields.
2023-04-14 06:11:42 +02:00
J0J0 Todos
04628ada96 Module-level constants for reimport_metadata() 2023-04-13 20:43:14 +02:00
J0J0 Todos
1bde0dabf2 Add changelog for #4735 2023-04-11 07:11:20 +02:00
J0J0 Todos
af7a4258c5 Improve logging in reimport_metadata, early exits
- Early exits in loops when no new value is incoming.
- Streamline and improve log messages:
  - "Reimported" vs. "Not reimported"
  - Album/Item ID at the beginning.
  - Path at very end.
  - Separate regular attrs from flex attrs.
2023-04-11 07:11:20 +02:00
J0J0 Todos
efc88193f9 Add test_reimported_album_not_preserves_flexattr
Checks if a reimported album flexible attribute "data_source" will be updated
correctly from the match being applied.
2023-04-11 07:11:20 +02:00
J0J0 Todos
42aa989e2d Refactor reimport_metadata, fix data_source update
- Refactor preserving of flexible attributes in the importer's
  reimport_metadata() method.
- New logging message when flex attrs are excluded from the preserving process.
- Fix data_source album/item flex attr not updated on a reimport.
2023-04-11 07:11:20 +02:00
Alok Saboo
023f3d7df7 Merge remote-tracking branch 'upstream/master' into embedart_url 2023-04-09 15:11:21 -04:00
Šarūnas Nejus
d05c34ec4e
Merge pull request #4741 from snejus/use-regex-for-path-lookup
Perform regex and `bareasc` lookups using SQL

- Define a custom function which performs regex lookups natively in SQL. This improves
performance of lookups like beet list path::hello.
- Define a SQL function which runs unidecode for the bareasc lookups
2023-04-09 19:27:30 +01:00
Alok Saboo
3a1e4bd845 Remove temporary logging 2023-04-09 14:07:55 -04:00
Alok Saboo
8357617f02 Change indentation 2023-04-09 14:02:10 -04:00
Alok Saboo
4d39b4037a Merge remote-tracking branch 'upstream/master' into embedart_url 2023-04-09 13:59:42 -04:00
Alok Saboo
34a4e7be5f Move away from PIL and use mimetypes instead 2023-04-09 13:58:26 -04:00
Šarūnas Nejus
b5b1afbfff
Also perform bareasc queries in SQL 2023-04-09 18:43:33 +01:00
Šarūnas Nejus
0f1b5d6f7c
Perform regex lookup in SQL
This improves performance of some string field lookups, for example
`beet list path::aa`
2023-04-09 18:43:32 +01:00
Adrian Sampson
5f7a6aa669
Merge pull request #4744 from snejus/define-singleton-query
Define SingletonQuery to perform filtering through SQL
2023-04-09 10:38:45 -07:00
Šarūnas Nejus
699e12bd88
Add explanatory docstring 2023-04-09 18:22:32 +01:00
Alok Saboo
99ca3e96d4 Add more error handling for the img.save function 2023-04-09 09:58:31 -04:00
Alok Saboo
9c3f4a4ac8 Change image format to PNG 2023-04-08 22:03:59 -04:00
Alok Saboo
b3008b74b8 Remove unused imports 2023-04-08 21:12:23 -04:00
Alok Saboo
23b42e80e2 Merge remote-tracking branch 'upstream/master' into embedart_url 2023-04-08 21:07:41 -04:00
Alok Saboo
93f4068cca Address review comments 2023-04-08 21:01:10 -04:00
Šarūnas Nejus
724b06a77d
Define SingletonQuery to perform filtering through SQL
This slightly speeds up the queries and there's a nice side-effect where
`singleton:1` and `singleton:0` now work fine!

This is ultimately building towards replacing as many python-only
queries with SQL equivalents.
2023-04-08 06:15:04 +01:00
Adrian Sampson
6955c53349
Merge pull request #4730 from elyang0214/master
Enforced utf-8 encoding on imported files
2023-04-07 12:19:19 -07:00
J0J0 Todos
8705457d24
Merge pull request #4399 from JOJ0/convert_playlist
convert: New feature "Write m3u playlist to destination folder"
2023-04-03 07:21:06 +02:00
J0J0 Todos
94784c2c29 convert: playlist: Documentation overhaul 2023-04-02 21:14:50 +02:00
J0J0 Todos
86929eb6a0 convert: playlist: Adapt code comments
- Remove initial comment around playlist entry condition (which is better
  suited for user docs anyway, and stated there already)
- Add explanation above the items_paths playlist contents creation list
  comprehension.
2023-04-02 19:34:13 +02:00
elyang0214
09de7909ce Merge branch 'master' of https://github.com/elyang0214/beets 2023-04-02 11:14:52 -04:00
elyang0214
b3b26efe88 Updated documentation to be less redundant in docs/referece/cli.rst and more accurate in docs/changelog.rst. 2023-04-02 11:13:53 -04:00
elyang0214
fbd665a417
Merge branch 'beetbox:master' into master 2023-04-02 11:06:13 -04:00
J0J0 Todos
16e361baf3 convert: playlist: item_paths relative to playlist
Ensure entries in items_paths are generated with a path relative to the
location of the playlist file.
2023-04-02 13:10:14 +02:00