Commit graph

10861 commits

Author SHA1 Message Date
Jonathan Matthews
41f9ecc73b Introduce new DB type: DelimeteredString 2023-02-27 13:28:29 +01:00
wisp3rwind
7aa7df2a93 Merge branch 'pr_autotag_typing_fixes' 2023-02-22 20:04:35 +01:00
J0J0 Todos
2b285c72a5
Merge pull request #4636 from trolley/topic/deprecate-acousticbrainz
Deprecate `absubmit` and `acousticbrainz` plugins
2023-02-21 17:42:25 +01:00
Adrian Sampson
1ccad26437
Merge pull request #4678 from beetbox/tutorial-link
Docs: Add a link to the walkthrough from the main tutorial guide
2023-02-20 17:56:45 -08:00
Mark Trolley
55255b0087
Deprecate absubmit and update acousticbrainz plugins
Fixes #4627.

AcousticBrainz is shutting down as of early 2023. Deprecate the absubmit
plugin and update the acousticbrainz plugin to require configuration of
an AcousticBrainz server instance.
2023-02-20 17:42:07 -05:00
wisp3rwind
c389087319 autotag: style fixes 2023-02-19 13:32:52 +01:00
wisp3rwind
0b4091166a typing: fixes according to mypy for autotag.*
tighten/loosen/fix some types as required and to the extent that we're
actually able to name the relevant types. Used a bunch of `cast(T, value)`
to help the type checker, in particular around confuse (that should probably
be fixed by typing confuse) and around getters for Item fields (not sure
whether we can do anything about that. We could add runtime checks (but what
the error handling do?))
2023-02-19 13:08:14 +01:00
wisp3rwind
5a2ce43fa8 Merge branch 'serene_arc_autotag_typings' 2023-02-19 11:58:59 +01:00
Benedikt
22ca6eff82
Merge pull request #4374 from wisp3rwind/pr_drop_old_python
Drop Python 3.6, some Python 2 + Python <= 3.6 cleanup
2023-02-19 10:19:36 +01:00
Serene-Arc
11a797fb94 Fix typing 2023-02-19 17:51:12 +10:00
Adrian Sampson
0f013f53ef
Link to walkthrough on blog
Closes #4382.
2023-02-18 20:37:48 -08:00
Adrian Sampson
36b6fb5498
Change some "read more" links 2023-02-18 20:33:16 -08:00
Adrian Sampson
c4b7bdfb70
Merge pull request #4677 from trolley/topic/fix-fetchart-suffix
Fix cover art archive fetching
2023-02-17 18:56:25 -08:00
Mark Trolley
13ce920fd1
Fix cover art archive fetching
PR #3748 changed the way cover art is fetched from the cover art
archive, but the manual addition of a `-` to the width suffix that was
needed when the image URI was being constructed manually was not
removed. Because of this the plugin would try to look up the property
under `thumbnails` that didn't exist (for example `-1200` instead of
`1200`), which would fail.
2023-02-17 19:01:20 -05:00
Serene-Arc
c0587cef31 Implement PEP 56v3 to avoid circular import 2023-02-16 16:59:01 +10:00
Serene-Arc
ef760feada Fix style errors 2023-02-13 13:51:40 +10:00
Serene-Arc
b33c3ce957 Fix some typings 2023-02-13 13:17:12 +10:00
Serene-Arc
24c0665142 Fix some typings 2023-02-13 10:00:06 +10:00
wisp3rwind
a666057fdf drop old Python: simplify and improve case_sensitive()
- some cleanup for recent Python which has samefile() on Windows
- also, fix this function by only upper-/lower-casing one path component
  at a time. It is unclear to me how this could have ever worked.
2023-02-12 16:16:43 +01:00
wisp3rwind
427bfe8cbf library/PathQuery: fix lower-casing 2023-02-12 16:16:43 +01:00
wisp3rwind
9052854e50 library/PathQuery: remove useless bytestring_path()
normpath already applies bytestring_path() to its output
2023-02-12 16:16:43 +01:00
wisp3rwind
e6fd038b0e tests: robustify path query / case_sensitive tests
- samefile exists on all platforms for recent python
- don't rely on monkey-patching os/os.path and on specifics on the
  implementation: as a result of doing so, the tests start failing in
  obscure ways as soon as the implementation (and its usage of
  os.path.exists and os.path.samefile) is changed
2023-02-12 16:16:43 +01:00
Benedikt
12e99f7cc6
Merge pull request #4675 from wisp3rwind/syspath_at_api_boundary
permissions: Move syspath conversion to the actual API boundary
2023-02-12 14:18:53 +01:00
wisp3rwind
12173d30a8 permissions: Move syspath conversion to the actual API boundary 2023-02-12 14:04:24 +01:00
Benedikt
0e29a4ffdc
Merge pull request #4579 from night199uk/fix_permissions
Avoid calling chmod in some scenarios.
2023-02-12 13:53:24 +01:00
night199uk
23598df155 Avoid calling chmod in some scenarios.
This guards the os.chmod calls so it's only called IF the
permissions need changing. This guards against an exception in
certain complex library setups.
2023-02-11 19:28:52 -08:00
J0J0 Todos
aabd1636aa
Merge pull request #4573 from JOJ0/splupdate_dry_run
Add --pretend option to splupdate command
2023-02-01 08:07:17 +01:00
Adrian Sampson
e504968e27
Merge pull request #4663 from katedickey/fix/cascade-flex-deletes
Fix album store method to cascade flex field deletions to items
2023-01-31 08:36:49 -08:00
Katelyn Dickey
f0359007a5
Code style fixes 2023-01-31 11:26:22 -05:00
Katelyn Dickey
2c43adf463
Fix album store method to cascade flex field deletions to items 2023-01-31 01:31:53 -05:00
J0J0 Todos
527052e13d
Merge branch 'master' into splupdate_dry_run 2023-01-31 07:07:09 +01:00
J0J0 Todos
6abcc20df0
Merge pull request #4634 from ghbrown/discogs_s_ic
Implement item_candidates for Discogs plugin
2023-01-31 06:24:05 +01:00
ghbrown
429dfb3e7a Fix docs phrasing; fix changelog formatting 2023-01-28 18:11:22 -06:00
Adrian Sampson
cc33c9c8b8
Merge pull request #4647 from Steffo99/definition-list
Use definition lists with the plugins' names in the documentation
2023-01-26 15:23:47 -08:00
Adrian Sampson
3ba973de31
Merge pull request #4646 from Steffo99/docs-plugin-discogs
Improve formatting in the `plugins/discogs` documentation page
2023-01-26 15:23:36 -08:00
Adrian Sampson
cf37ee37e5
Merge pull request #4645 from Steffo99/docs-plugin-plexupdate
Improve formatting in the `plugins/plexupdate` documentation page
2023-01-26 15:22:59 -08:00
Adrian Sampson
6aa562e2ae
Merge pull request #4650 from jcjordyn130/patch-1
config.rst: Remove extraneous for
2023-01-26 08:55:56 -08:00
Stefano Pigozzi
e76fe01212
Add missing space 2023-01-22 15:02:18 +01:00
Stefano Pigozzi
2b600fa151
Revert the configuration section back to how it was before 2023-01-22 14:56:23 +01:00
Stefano Pigozzi
566579b5f8
Revert the configuration section back to how it was before 2023-01-22 14:37:45 +01:00
Jordyn
7f3f522973
config.rst: Remove extraneous for 2023-01-21 22:08:03 -06:00
ghbrown
47fe387de1 Docs and changelog 2023-01-21 20:56:44 -06:00
ghbrown
bdb1024648 Merge master to avoid merge conflict in docs 2023-01-21 20:45:21 -06:00
ghbrown
a99eb77337 Improve where an how data added to tracks of album 2023-01-20 22:15:50 -06:00
ghbrown
cbb1b21408 Use tracks field in item_candidates; add more info to tracks of AlbumInfo 2023-01-20 21:07:15 -06:00
Stefano Pigozzi
ca320527c8
Improve formatting in the plugins/plexupdate page 2023-01-20 13:10:15 +01:00
Stefano Pigozzi
54aa095882
Specify the language of a code-block 2023-01-20 13:01:23 +01:00
Stefano Pigozzi
bc379850b2
Improve formatting in the plugins/discogs page 2023-01-20 12:47:43 +01:00
Stefano Pigozzi
21bf37befa
Use definition lists with the plugins' names
So that they are easier to find when knowing the name of an enabled plugin
2023-01-20 12:36:44 +01:00
Serene-Arc
7f5a28348c Add some typings 2023-01-20 13:20:15 +10:00