Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2025-12-29 12:02:44 +01:00
Code Issues Projects Releases Wiki Activity

Merge pull request #4579 from night199uk/fix_permissions

Browse source 
Avoid calling chmod in some scenarios.
This commit is contained in:
Benedikt 2023-02-12 13:53:24 +01:00 committed by GitHub
commit 0e29a4ffdc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
beetsplug/permissions.py
View file

@ -6,6 +6,7 @@ like the following in your config.yaml to configure:
dir: 755
"""
import os
import stat
from beets import config, util
from beets.plugins import BeetsPlugin
from beets.util import ancestry
@ -25,7 +26,7 @@ def check_permissions(path, permission):
"""Check whether the file's permissions equal the given vector.
Return a boolean.
"""
return oct(os.stat(path).st_mode & 0o777) == oct(permission)
return oct(stat.S_IMODE(os.stat(path).st_mode)) == oct(permission)
def assert_permissions(path, permission, log):
@ -103,7 +104,8 @@ class Permissions(BeetsPlugin):
'setting file permissions on {}',
util.displayable_path(path),
)
os.chmod(util.syspath(path), file_perm)
if not check_permissions(util.syspath(path), file_perm):
os.chmod(util.syspath(path), file_perm)
# Checks if the destination path has the permissions configured.
assert_permissions(path, file_perm, self._log)
@ -115,7 +117,8 @@ class Permissions(BeetsPlugin):
'setting directory permissions on {}',
util.displayable_path(path),
)
os.chmod(util.syspath(path), dir_perm)
if not check_permissions(util.syspath(path), dir_perm):
os.chmod(util.syspath(path), dir_perm)
# Checks if the destination path has the permissions configured.
assert_permissions(path, dir_perm, self._log)