wordofglass
2db1530ef8
fetchart: flake8 fixes
2016-06-25 21:55:55 +02:00
wordofglass
5d00ca8bda
fetchart: do not unnecessarily reset Candidate.path on download failure
2016-06-25 14:10:55 +02:00
wordofglass
697291b04e
fetchart: improve error resilience of the Content-Type detection by file magic
2016-06-25 14:10:50 +02:00
wordofglass
9968288358
fetchart: update comments
2016-06-25 13:49:15 +02:00
wordofglass
c789d31614
fetchart: fix and add tests for the new behaviour
2016-06-23 17:38:01 +02:00
wordofglass
34cdf0f3f3
fetchart: complain about unsupported images only after validating the Content-Type
2016-06-23 17:38:01 +02:00
wordofglass
d47182a3e5
fetchart: do not rely on the server-provided Content-Type, but determine the image format from the file magic
2016-06-23 17:37:55 +02:00
Johnny Robeson
cc6465d31e
convert Item.destination() fragment to a string
2016-06-23 04:35:26 -04:00
Johannes Baiter
ed2580d5b1
Fix bugs in beatport plugin ( #2076 )
...
* Fix naming bug
* Fix another minor bug
* Remove debugger statement
* Another fix for developer clumsiness in beatport plugin
* Fix typo in error description
2016-06-23 08:51:26 +02:00
Johnny Robeson
ea02269dee
remove ext encode from fetchart (py3 fix for #2068 )
2016-06-23 02:29:53 -04:00
Johnny Robeson
c7a4d261e2
fix a comment typo in ui/__init__.py
2016-06-23 01:29:46 -04:00
Johnny Robeson
2836877c35
use as_string to get mediafile properties as str
2016-06-23 01:06:15 -04:00
Adrian Sampson
d3928008e1
Merge pull request #2068 from beetbox/fetchart_mime_extension
...
Fix fetchart hardcoding the image extension
2016-06-22 10:19:12 -07:00
wordofglass
f07e6265ee
Changelog for the Content-Type based image extension detection
2016-06-22 13:02:15 +02:00
Johnny Robeson
0b17666b55
Revert "check for encoding attr before set in test_helper"
...
This doesn't actually help us, since the property is there, but not
writeable
This reverts commit 4c98edc588
2016-06-22 00:51:10 -04:00
Johnny Robeson
ab1e3ce87c
use as_string to get str result from root_parser name
2016-06-22 00:12:15 -04:00
Johnny Robeson
5b590f75f0
use as_string to get str results from unidecode
2016-06-22 00:11:48 -04:00
Johnny Robeson
4c98edc588
check for encoding attr before set in test_helper
...
This makes it work equivalently in py2 and py3
2016-06-21 23:44:24 -04:00
Adrian Sampson
133c82b1ab
Fix #2063 : properly decode format CLI argument
2016-06-21 15:15:24 -07:00
Adrian Sampson
5909c9ee89
Fix #2051 : don't try to sort None
...
I found the point in the test harnesses where None was introduced as a value
for `TrackInfo.index`. Just using zero works fine.
2016-06-21 15:02:05 -07:00
Adrian Sampson
829c4318f0
Changelog for #2067 (revived Beatport plugin)
2016-06-21 14:35:44 -07:00
Adrian Sampson
5e7ba73f5e
Merge pull request #2067 from jbaiter/beatport
...
Revive Beatport plugin with support for OAuth API (#1989 )
2016-06-21 14:33:34 -07:00
Adrian Sampson
351b6f8c9d
Remove raw Unicode literals ( fix #2069 )
...
PEP 414 didn't add `ur"..."` literals to Python 3. So for hybrid 2/3
compatibility, these had to be replaced with ordinary Unicode string literals.
This was only painful for one string; the others were only raw strings by
convention. (All were regexes.)
2016-06-21 14:29:14 -07:00
Johannes Baiter
7f98b456fc
Include beatport docs in plugin index
2016-06-21 22:22:18 +02:00
Johannes Baiter
00bce6de2c
Documentation for beatport plugin
2016-06-21 21:46:53 +02:00
Johannes Baiter
ae0269372c
Docstrings for beatport.BeatportClient
2016-06-21 21:39:25 +02:00
Johannes Baiter
c4835336a5
Fix PEP8 checks
2016-06-21 11:20:16 +02:00
Johannes Baiter
85d6ef4a80
Revive Beatport plugin with support for OAuth API ( #1989 )
2016-06-21 11:02:16 +02:00
wordofglass
c4617c2c1f
fetchart: do not hardcode the downloaded extension to jpg, fixes #2053
2016-06-21 10:57:45 +02:00
wordofglass
08c9bd84d8
fetchart: testcase for wrong server-side extensions ( #2053 )
2016-06-21 02:30:20 +02:00
Adrian Sampson
7fa3188396
Docs tweaks for #2062
2016-06-20 10:32:38 -07:00
Adrian Sampson
f925eec073
Merge pull request #2062 from philippbeckmann/bpd_gst10
...
bpd: Updated to GStreamer 1.0
2016-06-20 10:09:11 -07:00
Philipp Beckmann
a48a4c9a7c
bpd: edited the changelog and updated the requirements in the plugin docs
2016-06-20 18:56:11 +02:00
Philipp Beckmann
f9ed53a096
Multiple corrections as advised in the codereview
2016-06-20 18:44:37 +02:00
Philipp Beckmann
7b154cedd7
Added double line spacings between definitions
2016-06-20 18:29:46 +02:00
Philipp Beckmann
9fd227c8cc
Fixed flake8 errors
2016-06-20 18:22:07 +02:00
Philipp Beckmann
0a3d18c5c4
Merge remote-tracking branch 'upstream/master' into bpd_gst10
2016-06-20 18:11:11 +02:00
Philipp Beckmann
5613d9d4ea
bpd: Added correct error check for query_position/query_duration
2016-06-20 18:09:37 +02:00
Johnny Robeson
5208cfcaed
Revert "add six as a new dependency for beets" for now
...
It will return after the next bugfix release
This reverts commit 705557a5d2
2016-06-20 00:16:18 -04:00
Johnny Robeson
ae4fd64d3a
Revert "use six.integer_types in library" for now
...
It will return post bugfix release
This reverts commit 196176f180
2016-06-20 00:15:28 -04:00
Johnny Robeson
196176f180
use six.integer_types in library
2016-06-19 22:56:14 -04:00
Johnny Robeson
705557a5d2
add six as a new dependency for beets
2016-06-19 22:55:31 -04:00
Johnny Robeson
e1ede6827b
replace a filter() on search_ids with a list comp
2016-06-19 22:33:40 -04:00
Johnny Robeson
09322530ca
replace 2 map() calls with a list comprehension
2016-06-19 22:30:58 -04:00
Adrian Sampson
b5e1ac7dbf
Merge pull request #2056 from dixoncx/fix_issue_185
...
Fix issue #185
2016-06-19 13:10:57 -07:00
Philipp Beckmann
0917e675d7
bpg: Converted gstplayer.py to GStreamer 1.0
2016-06-19 22:06:55 +02:00
Dixon Xavier
4d75d4c063
Fix lint error
2016-06-20 00:52:09 +05:30
Dixon Xavier
366a6d7fb2
add validation for configuration
2016-06-20 00:35:47 +05:30
Dixon Xavier
80ca527f76
Fix typo in documentation
2016-06-19 13:20:54 +05:30
Dixon Xavier
fbcc8dbf1e
Update changelog and documentation
2016-06-19 12:54:27 +05:30
