Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2025-12-16 05:34:47 +01:00
Code Issues Projects Releases Wiki Activity

fetchart: update comments

Browse source
This commit is contained in:
wordofglass 2016-06-25 13:25:29 +02:00
parent c789d31614
commit 9968288358
1 changed files with 14 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
beetsplug/fetchart.py
View file

@ -232,20 +232,25 @@ class RemoteArtSource(ArtSource):
message=u'downloading image')) as resp:
ct = resp.headers.get('Content-Type', None)
# Generate a temporary file and guess the extension based on
# the Content-Type header. This may be wrong for badly
# configured servers. E.g. fanart.tv only allows .jpg uploads
# and ALWAYS returns a image/jpeg Content-Type, but other
# formats with a erroneous .jp(e)g extension apparently can
# sneak through the upload filter. Therefore validate the type
# using the file magic.
# Download the image to a temporary file. As some servers
# (notably fanart.tv) have proven to return wrong Content-Types
# when images were uploaded with a bad file extension, do not
# rely on it. Instead validate the type using the file magic
# and only then determine the extension.
data = resp.iter_content(chunk_size=1024)
try:
# stream only a small part of the image to get its header
chunk = next(data)
except StopIteration:
pass
else:
real_ct = _image_mime_type(chunk)
if real_ct is None:
# detection by file magic failed, fall back to the
# server-supplied Content-Type
# Is our type detection failsafe enough to drop this?
real_ct = ct
if real_ct not in CONTENT_TYPES:
self._log.debug(u'not a supported image: {}',
real_ct or u'unknown content type')
@ -260,7 +265,9 @@ class RemoteArtSource(ArtSource):
ct, real_ct, ext)
with NamedTemporaryFile(suffix=ext, delete=False) as fh:
# write the first already loaded part of the image
fh.write(chunk)
# download the remaining part of the image
for chunk in data:
fh.write(chunk)
self._log.debug(u'downloaded art to: {0}',