mirror of
https://github.com/stashapp/stash.git
synced 2026-01-26 18:12:32 +01:00
45f700d6ea
* Upgrade gqlgen to v0.17.2 This enables builds on Go 1.18. github.com/vektah/gqlparser is upgraded to the newest version too. Getting this to work is a bit of a hazzle. I had to first remove vendoring from the repository, perform the upgrade and then re-introduce the vendor directory. I think gqlgens analysis went wrong for some reason on the upgrade. It would seem a clean-room installation fixed it. * Bump project to 1.18 * Update all packages, address gqlgenc breaking changes * Let `go mod tidy` handle the go.mod file * Upgrade linter to 1.45.2 * Introduce v1.45.2 of the linter The linter now correctly warns on `strings.Title` because it isn't unicode-aware. Fix this by using the suggested fix from x/text/cases to produce unicode-aware strings. The mapping isn't entirely 1-1 as this new approach has a larger iface: it spans all of unicode rather than just ASCII. It coincides for ASCII however, so things should be largely the same. * Ready ourselves for errchkjson and contextcheck. * Revert dockerfile golang version changes for now Co-authored-by: Kermie <kermie@isinthe.house> Co-authored-by: WithoutPants <53250216+WithoutPants@users.noreply.github.com>
50 lines
2 KiB
Markdown
50 lines
2 KiB
Markdown
# Contributing to Cobra
|
|
|
|
Thank you so much for contributing to Cobra. We appreciate your time and help.
|
|
Here are some guidelines to help you get started.
|
|
|
|
## Code of Conduct
|
|
|
|
Be kind and respectful to the members of the community. Take time to educate
|
|
others who are seeking help. Harassment of any kind will not be tolerated.
|
|
|
|
## Questions
|
|
|
|
If you have questions regarding Cobra, feel free to ask it in the community
|
|
[#cobra Slack channel][cobra-slack]
|
|
|
|
## Filing a bug or feature
|
|
|
|
1. Before filing an issue, please check the existing issues to see if a
|
|
similar one was already opened. If there is one already opened, feel free
|
|
to comment on it.
|
|
1. If you believe you've found a bug, please provide detailed steps of
|
|
reproduction, the version of Cobra and anything else you believe will be
|
|
useful to help troubleshoot it (e.g. OS environment, environment variables,
|
|
etc...). Also state the current behavior vs. the expected behavior.
|
|
1. If you'd like to see a feature or an enhancement please open an issue with
|
|
a clear title and description of what the feature is and why it would be
|
|
beneficial to the project and its users.
|
|
|
|
## Submitting changes
|
|
|
|
1. CLA: Upon submitting a Pull Request (PR), contributors will be prompted to
|
|
sign a CLA. Please sign the CLA :slightly_smiling_face:
|
|
1. Tests: If you are submitting code, please ensure you have adequate tests
|
|
for the feature. Tests can be run via `go test ./...` or `make test`.
|
|
1. Since this is golang project, ensure the new code is properly formatted to
|
|
ensure code consistency. Run `make all`.
|
|
|
|
### Quick steps to contribute
|
|
|
|
1. Fork the project.
|
|
1. Download your fork to your PC (`git clone https://github.com/your_username/cobra && cd cobra`)
|
|
1. Create your feature branch (`git checkout -b my-new-feature`)
|
|
1. Make changes and run tests (`make test`)
|
|
1. Add them to staging (`git add .`)
|
|
1. Commit your changes (`git commit -m 'Add some feature'`)
|
|
1. Push to the branch (`git push origin my-new-feature`)
|
|
1. Create new pull request
|
|
|
|
<!-- Links -->
|
|
[cobra-slack]: https://gophers.slack.com/archives/CD3LP1199
|