Commit graph

7114 commits

Author SHA1 Message Date
Adrian Sampson
f941fd42de Always use SSL on servers that don't require SNI
I did a little audit using the `openssl` command-line tool to find the servers
that don't require SNI. Here's what I found:

icbrainz.org: SNI
images.weserv.nl: inconclusive, but docs say yes SNI
coverartarchive.org: SNI
webservice.fanart.tv: *no* SNI
dbpedia.org: *no* SNI
en.wikipedia.org: *no* SNI
ws.audioscrobbler.com: *no* SNI
api.microsofttranslator.com: *no* SNI

In summary, *only* MusicBrainz and CoverArtArchive were found to require SNI.
So I'm using SSL unconditionally on all the other sites.
2017-01-02 20:39:10 -05:00
Tigran Kostandyan
1c5c74f1d7 Fix a typo 2016-12-31 18:46:01 +03:00
tigranl
dd115b1310 Add ui import 2016-12-11 00:35:51 +03:00
tigranl
5ca664e4aa Fix typos 2016-12-11 00:25:37 +03:00
tigranl
471f875dc1 Fix typo 2016-12-10 21:26:51 +03:00
tigranl
0868299e92 PEP8 corrections 2016-12-10 20:08:27 +03:00
tigranl
68b4a03ecd Add tests for https 2016-12-10 19:54:44 +03:00
tigranl
b65a7da8e2 Add SNI_SUPPORTED 2016-12-08 19:20:18 +03:00
tigranl
21208b8c39 Add SNI_SUPPORTED 2016-12-08 19:09:15 +03:00
tigranl
9bba178b5c Add tests for https 2016-12-08 18:44:17 +03:00
tigranl
420c451928 Add SNI_SUPPORTED
Add SNI_SUPPORTED

Add SNI_SUPPORTED
2016-12-06 20:07:00 +03:00
tigranl
efa90416a0 Add SNI_SUPPORTED
Add SNI_SUPPORTED
2016-12-06 19:51:15 +03:00
tigranl
91819b2c80 Add SNI_SUPPORTED 2016-12-06 19:31:42 +03:00
tigranl
25ebf8948f Revert "Add SNI_SUPPORTED variable for https check"
This reverts commit f60c911ffc.
2016-12-06 19:27:43 +03:00
tigranl
5ae13764d8 Add SNI_SUPPORTED variable for https check 2016-12-06 18:52:00 +03:00
tigranl
d065b33a81 Add SNI_SUPPORTED variable for https check 2016-12-06 18:42:01 +03:00
tigranl
73a7a4ff67 Add SNI_SUPPORTED variable for https check 2016-12-06 18:38:26 +03:00
tigranl
f60c911ffc Add SNI_SUPPORTED variable for https check 2016-12-06 17:10:35 +03:00
tigranl
0fb19cfa10 Merge branch 'master' of github.com:beetbox/beets into https_fix 2016-12-06 16:20:54 +03:00
tigranl
6ba5099034 Python version check for lyrics.py 2016-12-06 16:17:25 +03:00
tigranl
43fcb3d908 Check python version and enable https where it's possible 2016-12-05 22:01:33 +03:00
Adrian Sampson
ae5e55cad6 Always use syspath to construct MediaFile
Related to #1966. Previously, we used a `syspath` call inside MediaFile, which
probably wasn't right: the constructor should behave like `open` in that we
need to use pass an OS path.
2016-12-04 21:00:56 -05:00
Adrian Sampson
991c9936fd Fix #2299: non-Unicode logging in badfiles 2016-12-03 11:20:06 -05:00
Adrian Sampson
957bfacf21 Fix Backbone.js link 2016-11-30 08:40:15 -05:00
Adrian Sampson
d08baa4c91 Merge pull request #2295 from musoke/patch-1
Fix rst syntax error in docs
2016-11-28 18:12:38 -05:00
Nathan Musoke
0701e66391 Fix rst syntax error in docs 2016-11-29 12:11:12 +13:00
Adrian Sampson
9de27c6b70 Sync up with separate MediaFile repository 2016-11-26 20:48:12 -05:00
Adrian Sampson
d8c0a42e6c Avoid TestHelper dependency in MediaFile tests
Part of #1966. This also introduces a nicer, more lightweight way to create and
destroy temporary directories, decoupling that functionality from the
giant morass that is TestHelper.
2016-11-26 18:55:58 -05:00
Adrian Sampson
a88682e7bb Undo from _common import unittest indirection
This was a vestige from when we used to need the unittest2 library for pre-2.7
compatibility. Now that we require Python 2.7, we aren't using that library
and this indirection wasn't doing any good.
2016-11-26 18:46:44 -05:00
Adrian Sampson
24940c0de7 In MediaFile tests, use simpler import path
This will make it easier to copy these tests into their own repository.
2016-11-26 18:27:20 -05:00
Adrian Sampson
788654736d Obviate the need for a beets utility in MF tests
Even more on #1966.
2016-11-26 18:26:18 -05:00
Adrian Sampson
47049e1ff1 Avoid one last beets utility in MediaFile tests
This is a little dirty, what with the hard-coded encoding, but I don't feel
too bad about it because we're only manipulating our test fixtures and
temporary directory that way.

More on #1966.
2016-11-26 18:23:46 -05:00
Adrian Sampson
54cb0b2a15 Separate beets-specific MediaFile tests
Part of the #1966 separation effort.
2016-11-26 18:08:00 -05:00
Adrian Sampson
2cc1a61ea4 MediaFile: Remove one last utility function (#1966) 2016-11-26 17:40:40 -05:00
Adrian Sampson
075a4b6b85 MediaFile: Avoid using some beets utilities
Modularization: #1966
2016-11-26 17:37:01 -05:00
Adrian Sampson
c70a9bb873 Enable Python 3 tests by default in Tox config
Now that we're supporting it, I plan to run the Python 3 tests as part of
my normal coding workflow.
2016-11-26 17:32:49 -05:00
Adrian Sampson
fc6658c110 Add a missing __future__ import 2016-11-26 17:31:54 -05:00
Adrian Sampson
692dea39e8 MediaFile: Use stock logging
This is part of the effort to separate MediaFile from beets (#1966). It avoids
using the beets-specific logging infrastructure. This commit is part of
fdebab657d6e85de56b3996e8fdece09796940ae from the new MediaFile repository.
2016-11-26 17:30:02 -05:00
Adrian Sampson
cf5fa501e2 Version bump: 1.4.2 2016-11-25 22:16:03 -05:00
Adrian Sampson
839a316673 Change released version to 1.4.1
Sadly, I uploaded the wrong file to PyPI for 1.4.0. Once you do this, PyPI
never lets you change the file associated with a given released version. So we
need to use 1.4.1 instead. 😢
2016-11-25 22:13:54 -05:00
Adrian Sampson
60ec732e10 Version bump: 1.4.1 2016-11-25 21:38:06 -05:00
Adrian Sampson
d99b46612f Fix version bumping in release.py 2016-11-25 21:37:25 -05:00
Adrian Sampson
d54ef99ea5 Fix a forgotten test 2016-11-25 21:33:44 -05:00
Adrian Sampson
8d902c0da3 Release date for 1.4.0 2016-11-25 21:29:06 -05:00
Adrian Sampson
9fb358d3c0 Even more little changelog fixes 2016-11-25 21:28:41 -05:00
Adrian Sampson
e15bee15f5 More changelog proofreading 2016-11-25 21:11:54 -05:00
Adrian Sampson
55d9233e39 Capitalize Python 2016-11-25 21:06:01 -05:00
Adrian Sampson
bdfa53c503 Changelog updates and proofreading 2016-11-25 21:05:34 -05:00
Adrian Sampson
f31e6110e6 Simplify #2280 docs
I've backed out the FAQ entry, since the main docs seem like the right place
for this.
2016-11-24 23:59:00 -05:00
Adrian Sampson
d6b15f4eaa Remove duplicated line in docs (#2280)
For consistency: we don't show the aliases here for the other commands.
2016-11-24 23:51:10 -05:00