Adrian Sampson
15e2a0f631
Merge pull request #2696 from Sjlver/bpd-fix
...
Update GStreamer installation instructions for Mac OS X.
2017-09-22 14:59:06 -04:00
Adrian Sampson
97a0c21f9a
Merge pull request #2695 from Sjlver/master
...
Fix the --key option in the `duplicates` plugin.
2017-09-22 14:52:03 -04:00
Jonas Wagner
d7abf0b8e1
Update GStreamer installation instructions for Mac OS X.
2017-09-22 20:32:45 +02:00
Jonas Wagner
114a6f80da
Fix the --key option in the duplicates plugin.
...
During a refactoring, the "dest='keys'" parameter was lost. This caused
the option to not have any effect.
2017-09-22 20:27:47 +02:00
David Logie
bed003f97b
Use the built-in method of overriding config with cli options.
2017-09-18 18:19:51 +01:00
David Logie
61b0246651
mbcollection: Add support from removing albums.
...
Add a new ``mbcollection.remove`` configuration option (default: None)
and a new ``-r`` (``--remove``) flag which removes albums from
collections that are no longer present in the beets database.
The ``-r`` flag takes precedence over the ``remove`` configuration
option.
2017-09-14 15:49:42 +01:00
Adrian Sampson
0a1db4218f
Merge pull request #2687 from zigarrre/issue2682
...
Refactored move functions for clarity according to #2682
2017-09-12 23:11:58 -04:00
zigarrre
e30513db9b
Added the default ignore list of flake8
...
This fixes the W503 warnings and possibly other, unwanted errors and
warnings in the future.
2017-09-12 18:19:18 +02:00
zigarrre
edd2d42cd0
Shortened two lines that where to long.
2017-09-11 17:29:57 +02:00
zigarrre
b376139663
Refactored move functions for clarity according to #2682
...
The move functions in library.py and manipule_files in importer.py where
changed to use a single parameter for the file operation instead of
multiple boolean flags.
A typo in the documentation of the Album.move and Item.move functions
confusing True and False when describing the store parameter was fixed
as well.
2017-09-11 17:03:44 +02:00
Adrian Sampson
cdd440244b
Merge pull request #2685 from beetbox/mbc-customids
...
mbcollection: Support specifiying collection ID.
2017-09-09 23:33:08 -04:00
David Logie
8eb233331c
Update changelog/docs for new `mbcollection.collection` option.
2017-09-09 21:38:33 +01:00
David Logie
7db09c6aba
Silence pep8 warning.
2017-09-09 19:13:44 +01:00
David Logie
46f7ce78f1
mbcollection: Support specifiying collection ID.
2017-09-09 18:59:25 +01:00
Adrian Sampson
cb2cb00959
Merge pull request #2683 from euri10/master
...
Added a missing switch to the fetchart command
2017-09-05 14:59:12 -04:00
euri10
25fb2453b4
Modified the name of the fetchart plugin switch from missing to quiet
2017-09-05 18:27:47 +02:00
euri10
b2fd274e2c
Added a missing switch to the fetchart command so that only missing albums
...
are displayed
2017-09-05 16:34:26 +02:00
Adrian Sampson
34246a00e7
Fix #2673 : JSON file encoding in absubmit
...
First, it's best to open the file as binary so the JSON module itself
can figure out how to decode it (it will just use UTF-8). Then, we can
use `load` instead of `loads` to avoid needing to read the file
explicitly ourselves.
2017-08-27 10:20:36 -04:00
Adrian Sampson
015aee3662
Fix #2671 : missing syspath on acoustid call
2017-08-26 11:18:27 -04:00
wordofglass
8833fef249
Merge pull request #2668 from wordofglass/edit_logic
...
Edit plugin logic: Regression from previous PR; incorrect diffs
2017-08-25 15:52:40 +02:00
wordofglass
7f12cc0c88
edit, Model.copy: documentation improvements
2017-08-25 15:47:07 +02:00
wordofglass
aa19577464
Merge pull request #2667 from wordofglass/mtime_fixes
...
Mtime fixes
2017-08-25 15:38:44 +02:00
wordofglass
f8a38bd527
Merge branch 'master' into mtime_fixes
2017-08-25 15:38:18 +02:00
wordofglass
024689e781
Changelog entry for the mtime fixes
2017-08-25 15:34:16 +02:00
wordofglass
5f21bd3ccd
test_edit: Add a test for retagging.
2017-08-24 15:03:18 +02:00
wordofglass
352d99cccd
edit: Do not deepcopy objects, finally fixes the regression from #2659
...
Deepcopying fails if a database is attached as Model._db since the
sqlite connection objects it contains are non-copyable
2017-08-24 15:03:18 +02:00
wordofglass
a9a2276774
Implement beets.dbcore.db.Model.copy()
2017-08-24 15:03:01 +02:00
wordofglass
33f7e67943
edit: Fix a regression from #2659 when re-tagging albums
2017-08-24 13:40:50 +02:00
wordofglass
989845199b
edit: Correctly reset the old object, do not reload it from the tags
...
Previously, if continuing to edit (i.e. invoking the $EDITOR) multiple
times in one invocation of EditPlugin.edit_objects, the plugin would
reload the old state from the file tags. The initial 'old state' is
usually only loaded from the database, though. As a consequence, if
database and tags were not in sync, the diffs from first and all
subsequent edits could differ unexpectedly.
2017-08-24 13:40:35 +02:00
wordofglass
c4fb2d1955
Item: Do not reset the mtime in __setitem__ unless the value actually changes
...
Unbreaks the remaining edit plugin tests.
2017-08-22 23:34:35 +02:00
wordofglass
b903b44a0c
test_edit: Fix test that intended to change one item but affected two.
...
This didn't manifest as a testing failure since the plugin (mostly
silently) drops id changes.
2017-08-22 23:34:35 +02:00
wordofglass
c811102eb2
test_edit: Expect mtime to change, unbreaks the multiple-item tests.
2017-08-22 23:34:06 +02:00
wordofglass
18c82cab5f
test_edit: Add a comment explaining why I didn't change the writing behaviour
...
I was midway through writing a test when realizing that it's best
the way it is...
2017-08-22 23:24:33 +02:00
wordofglass
7d4627bb8f
Ensure mtime is non-zero for Items in test fixtures.
...
mtime == 0 is the "this Item contains newer metadata than the file's
tags" marker. Setting this to something else than 0 emulates the state
of Items freshly read from the database.
Breaks 4 of the edit plugin tests.
2017-08-22 23:24:33 +02:00
Adrian Sampson
d87c73efb3
Merge pull request #2662 from natezb/master
...
Fix kodiupdate URL and add better error reporting
2017-08-22 12:59:19 -04:00
Nate Bogdanowicz
9d01ba0af2
Add changelog entry for #2662
2017-08-22 09:56:57 -07:00
Adrian Sampson
e983929e52
Fix a ReST syntax error
2017-08-21 14:30:12 -04:00
Adrian Sampson
2b31b493a6
Refine docs for #2663
2017-08-21 14:29:34 -04:00
Adrian Sampson
40a53513bc
Merge pull request #2663 from tigranl/patch-1
...
Update gmusic.rst
2017-08-21 14:26:30 -04:00
Tigran Kostandyan
bfdcbe2aac
Update gmusic.rst
2017-08-21 11:38:11 +03:00
wordofglass
695c706ae0
Merge pull request #2659 from wordofglass/master
...
Fix the edit plugin displaying bogus data or even crashing on re-imports
2017-08-21 00:36:14 +02:00
wordofglass
109b547f7a
Changelog entry for the edit plugin bugfix
2017-08-21 00:32:46 +02:00
wordofglass
df479d686d
Fix the edit plugin displaying bogus data or even crashing on re-imports
2017-08-21 00:32:03 +02:00
Nate Bogdanowicz
f5dbb7b0c5
Make error handling and logging more detailed
2017-08-20 14:51:03 -07:00
Nate Bogdanowicz
7eb9913391
Fix kodi url
2017-08-20 13:14:48 -07:00
Adrian Sampson
51961bbba2
gmusic: Use Unicode literals ( #2660 )
2017-08-20 13:03:40 -04:00
Adrian Sampson
c89186afac
Changelog for #2467/#2658
2017-08-20 12:52:54 -04:00
David Logie
f909f092fc
Fix importfeeds plugin on Python 3.
2017-08-12 16:45:13 +01:00
Adrian Sampson
598c965b0f
Simplify text for #2653
2017-08-11 14:35:22 -04:00
Adrian Sampson
4fa0827153
Merge pull request #2653 from plittlefield/patch-1
...
Update zero.rst
2017-08-11 14:33:40 -04:00
