Barry Broderick
585d4ba89d
attempted fix for #2740
2017-11-20 09:56:40 -05:00
Adrian Sampson
16592445b0
Link to bug for #2741
2017-11-19 10:51:32 -05:00
Adrian Sampson
60249fdcdb
Merge pull request #2741 from eigengrau/master
...
mediafile._safe_cast: be safer when converting to int
2017-11-19 10:50:51 -05:00
Sebastian Reuße
c40ea4f22a
mediafile._safe_cast: be safer when converting to int
...
The regex «[\+-]?[0-9]*» possibly matches a single minus/plus, which would then
be passed on to int(), raising a ValueError from within _safe_cast. The test
suite covered this for float, but not for int.
We now make sure we actually have a number after the sign by using a Kleene
plus.
2017-11-19 09:21:07 +01:00
David Logie
c10e62f212
mbcollection: Fix default 'remove' value.
...
If the default is not None the value cannot be overriden by the user's
config.yaml.
2017-11-13 15:48:22 +00:00
Adrian Sampson
9657cf612e
Revise importer guide text about merging
2017-11-11 11:07:40 -05:00
Adrian Sampson
0c20147e14
Changelog for #2725
2017-11-11 11:05:43 -05:00
Adrian Sampson
c5ed992638
Merge pull request #2725 from udiboy1209/merge-albums
...
Implement album merging for duplicates
2017-11-11 11:04:37 -05:00
Adrian Sampson
8ca271773b
Merge pull request #2735 from Vrihub/2734-candidates-fetchart
...
Tentative fix for issue 2734: also check for RETAG
2017-11-10 09:57:04 -05:00
test
842f6afd7f
Fix indentation
2017-11-10 14:04:16 +01:00
test
8544b3a830
Fix long line and add changelog entry
2017-11-10 13:46:26 +01:00
test
54297dbab4
Tentative fix for issue 2734: also check for RETAG
2017-11-05 12:04:40 +01:00
Meet Udeshi
a6215f30a7
flake8 fixes
2017-11-05 12:35:32 +05:30
Meet Udeshi
83f2e44936
Mark merged items in session for future tasks
2017-11-05 06:20:48 +05:30
Meet Udeshi
1646da4d9c
Add comments and explain merge feature in config docs and guide
2017-11-04 03:08:53 +05:30
Meet Udeshi
4d4fb504d5
Change to subset check for finding duplicates
...
also implement repeating code as helper functions
2017-11-04 01:33:19 +05:30
Adrian Sampson
0d8d1c3aee
Modify task recommendation and candidates
...
This way, subsequent candidates can be exposed to plugins instead of
just used locally to interact with the user.
2017-11-01 19:13:42 -04:00
Adrian Sampson
7ea3192db7
Mention backups in the main guide
2017-11-01 18:57:43 -04:00
Adrian Sampson
9c6910d167
Merge pull request #2726 from translit/patch-1
...
Update fetchart.rst
2017-11-01 09:57:19 -04:00
translit
abefae12a0
Update fetchart.rst
2017-11-01 08:06:30 +01:00
Meet Udeshi
28fef2e77a
Fix flake8 errors
2017-11-01 02:24:19 +05:30
Meet Udeshi
70f0bc5b6c
Implement album merging for duplicates
...
Fixes #112
2017-11-01 02:00:48 +05:30
Adrian Sampson
2120cf68c6
Merge pull request #2723 from hugovk/patch-1
...
Update classifiers
2017-10-30 09:31:21 -04:00
Adrian Sampson
b87d9736f5
Merge pull request #2722 from hugovk/replace-2.7_with_system_site_packages
...
Use 2.7.13 instead of 2.7_with_system_site_packages
2017-10-30 09:29:58 -04:00
Hugo
5348d5ddc0
Update classifiers
2017-10-30 08:57:00 +02:00
Hugo
0c03d7e1a3
Use 2.7.13 instead of 2.7_with_system_site_packages
2017-10-30 08:41:49 +02:00
Adrian Sampson
d64842ce5b
Travis: more specific Python 2.7 release number
...
Failures were cropping up due to a combination of a Travis problem where
the Python version was reverted to Python 2.7.6:
https://github.com/travis-ci/travis-ci/issues/8097
And a pylast update that called a function only available on Python
2.7.9 and above, discussed here:
https://github.com/pylast/pylast/issues/201
I hope this fixes it...
2017-10-29 22:23:47 -04:00
Adrian Sampson
7c9ce0da7a
Ignore yet another new flake8 error
...
As described in PyCQA/pycodestyle#598 , pycodestyle has exposed a new
error for "ambiguous variable names." I really wish this project were
less eager to add new warnings of questionable value that are enabled by
default...
2017-10-29 16:29:06 -04:00
Adrian Sampson
14476e2f8a
scrub: Handle MutagenError ( fix #2716 )
...
In older versions of Mutagen, an IOError indicated things like
permissions errors. Now, a custom MutagenError is raised. Now we handle
both.
2017-10-20 14:49:53 -04:00
Adrian Sampson
db71710fea
Changelog entry for #2709
...
Closes #2545 . Closes #2246 .
2017-10-09 18:52:46 -04:00
Adrian Sampson
d02bef1aec
Merge pull request #2709 from lmagno/master
...
Fetch lyrics from Genius through scraper
2017-10-09 18:50:58 -04:00
Lucas Magno
fc2d379fb5
Comply with PEP8
2017-10-09 06:22:42 -03:00
Adrian Sampson
1cff500b4b
Changelog for #2708 ( fixes #2427 )
2017-10-08 13:18:50 -04:00
Adrian Sampson
75c668b7d9
Remove a needless warning from docs ( #2708 )
...
No need for caution anymore! 😱 With confirmation, we don't need
this warning.
2017-10-08 13:17:21 -04:00
Adrian Sampson
5b30e12ac5
Merge pull request #2708 from konman2/master
...
Clearart asks for permission before deleting embedded albumart
2017-10-08 13:16:38 -04:00
Lucas Magno
1b35a5df0d
Fetch lyrics from Genius through scraper
2017-10-08 09:13:51 -03:00
konman2
578143ae12
updated to pass pep8 checks
2017-10-07 21:28:33 -07:00
konman2
fdeef05cc9
clearart asks for permission before deleting embedded albumart
2017-10-07 20:42:01 -07:00
Adrian Sampson
e370286c2f
Add bug reference
2017-10-07 12:07:57 -04:00
Adrian Sampson
114a2f8bd4
Merge pull request #2707 from gdtwst/mpdstats_edits
...
mpdstats: update stats when switching from song to stream and when playing a song consecutively
2017-10-07 09:06:51 -07:00
gdtwst
dd32128fd5
Changelog for #2707
2017-10-07 20:04:37 +07:00
gdtwst
e5afc5e0b3
Remove whitespaces from empty line
2017-10-07 19:00:08 +07:00
Adrian Sampson
ce40d85151
Merge pull request #2644 from pprkut/gstreamer
...
Fix album replaygain calculation with gstreamer backend
2017-10-04 14:47:25 -04:00
Heinz Wiesinger
bd6645d135
Fix album replaygain calculation with gstreamer backend.
...
Fixes #2636
2017-10-04 20:22:01 +02:00
gdtwst
c2770a5f6b
Enable play counts for repeated plays of the same song.
2017-10-04 19:10:59 +07:00
gdtwst
eb338d208b
Register song changes when switching from song to stream URL
2017-10-04 16:35:22 +07:00
nath@dp7510
e08f28d865
Changelog for #2702
2017-10-02 09:15:25 +02:00
Nathan Dwek
a1f1e35ba4
Merge pull request #2702 from j000/patch-1
...
[Play plugin]Respect relative paths when using albums
2017-09-28 09:03:48 +02:00
j000
5a82c7ead1
Remove whitespaces from empty line
2017-09-27 23:31:35 +02:00
j000
77e8f21094
[Play plugin]Respect relative paths when using albums
2017-09-26 03:20:00 +02:00
