soergeld
f87f271484
correct mock results of get_work_by_id
2020-07-13 22:22:16 +02:00
soergeld
55995a32cb
correct force check, correct arguments for get_work_by_id
2020-07-13 22:17:24 +02:00
soergeld
df91813609
pep-8
2020-07-13 22:13:49 +02:00
soergeld
a4a9f0daa9
different way of mocking
2020-07-13 22:12:13 +02:00
soergeld
82411c67cf
minor fixes
2020-07-13 21:51:45 +02:00
soergeld
1cb23e5c5c
no hybrid mocking, two classes
2020-07-13 21:48:06 +02:00
soergeld
dba2e2320d
hybrid mocking
2020-07-13 21:41:10 +02:00
soergeld
d71ee6bc31
exchanged tests with and without MB
2020-07-13 21:38:02 +02:00
soergeld
58b11d9d3c
make tests both with MB and without
2020-07-13 21:34:24 +02:00
soergeld
94dd7cee70
unused library
2020-07-13 21:20:18 +02:00
soergeld
2d756df5b7
second try
2020-07-13 21:16:51 +02:00
soergeld
e943486da9
first try at mocking get_work_by_id
2020-07-13 21:11:30 +02:00
Adrian Sampson
9c054e9588
Merge pull request #3668 from wisp3rwind/pr_fix_bad_triggers
...
Fix a regression in the heuristic for detecting valid lyrics from the google source
2020-07-12 16:46:46 -04:00
wisp3rwind
44e4d558c9
lyrics: fix bad_triggers in the google plugin
...
regression from 117d16f
2020-07-12 22:23:17 +02:00
jtpavlock
16fddbaef6
add line break to stale-bot comments
2020-07-11 17:27:37 -05:00
jtpavlock
cc9f4ab251
Add a stale-bot ( #3659 )
...
will apply the `stale` label to any issues and pull requests with >60/120 days inactivity respectively
2020-07-11 15:59:34 -05:00
Adrian Sampson
97378c6c90
Merge pull request #3418 from RollingStar/patch-1
...
Clarify getitem docstring. Log when falling back.
2020-07-11 10:04:42 -04:00
Adrian Sampson
d230b3b870
Roll back logging changes
2020-07-11 10:04:00 -04:00
jtpavlock
8b8156c493
Merge pull request #3661 from jtpavlock/testing-cleanup
...
Testing cleanup & nose -> pytest
2020-07-09 18:53:09 -05:00
Jacob Pavlock
f6855cb284
add py_colors to all github workflows
2020-07-07 19:58:27 -07:00
Jacob Pavlock
7280ab2be0
remove nosetest.xml from .gitignore
2020-07-07 19:54:12 -07:00
Jacob Pavlock
7427bfbc58
clean github workflows
2020-07-07 19:54:01 -07:00
Jacob Pavlock
f2e7b3fdd7
remove references to nose
2020-07-07 15:28:38 -07:00
Jacob Pavlock
d5e5be5c8e
simplify tox.ini
2020-07-07 15:05:40 -07:00
Jacob Pavlock
25c6843c28
classify integration tests in test_parentwork.py
2020-07-07 15:05:21 -07:00
Jacob Pavlock
917c7def4e
test commit for windows ci
...
windows seems to be having issues with tox installing depencies
via `.[test]` this is a test to see if removing the inline comment changes anything
2020-07-07 09:37:22 -07:00
Adrian Sampson
32e54a29fa
Merge pull request #3655 from aereaux/add_parentwork_date
...
Get the date of the parentwork, which may be different from the date of the child work.
2020-07-07 07:48:23 -04:00
Jacob Pavlock
e4284cff55
reverting change to ci for python3.4
...
seems github actions doesn't support python3.4
2020-07-06 18:51:36 -07:00
Jacob Pavlock
dabde74683
nose -> pytest and clean-up tox
2020-07-06 17:03:11 -07:00
Jacob Pavlock
723e04ebb3
deprecate tests_require in favor of extras
2020-07-06 17:02:23 -07:00
jtpavlock
aedd77317f
Merge pull request #3658 from jtpavlock/integration_tests
...
Add weekly integration test github action
2020-07-06 11:37:46 -05:00
jtpavlock
45abc9ed7a
Clean up code and tests for Genius Lyrics plugin backend ( #3641 )
...
* clean-up code & add tests for genius lyrics backend
* add genius fetch tests
* organize imports: standard lib -> pip -> local
* check in sample genius lyrics page
* fix mock import
* force utf-8 encoding for opened files
* use io.open to force utf-8 encoding w/ python2.7
2020-07-06 08:41:27 -05:00
Jacob Pavlock
06553cc37c
adjust test_lyrics.py to work with integration tests
2020-07-05 21:41:31 -07:00
Jacob Pavlock
c05ba5c814
add integration test github action
2020-07-05 21:41:22 -07:00
Aidan Epstein
27199abac8
Get the date of the parentwork, which may be different from the date of the child work.
...
Also add a changelog entry and docs.
2020-07-03 09:35:15 -07:00
Adrian Sampson
cb668ccdab
Merge pull request #3648 from jtpavlock/patch-2
...
Create pull request template
2020-06-29 09:08:51 -04:00
Adrian Sampson
6411a58c80
Slight formatting/wording improvements
2020-06-29 09:08:25 -04:00
Adrian Sampson
aed81da2fa
Thanks & bug link for #3637
2020-06-28 21:19:35 -04:00
Adrian Sampson
8deef192e6
Merge pull request #3647 from trolley/topic/coverart-thumbs-2
...
fetchart: Use Cover Art Archive thumbnails
2020-06-28 21:18:39 -04:00
jtpavlock
def44e6f88
Update pull_request_template.md
2020-06-28 17:36:40 -05:00
jtpavlock
b458509ba1
spelling
2020-06-28 17:35:08 -05:00
jtpavlock
3282f1565e
Update pull_request_template.md
2020-06-28 17:33:42 -05:00
jtpavlock
c9519c1ef5
Create pull_request_template.md
2020-06-28 17:32:37 -05:00
Mark Trolley
0f767ffa66
fetchart: Use Cover Art Archive thumbnails
...
The Cover Art Archive API offers pre-resized thumbnails of cover
art. If the `maxwidth` option of `fetchart` matches one of the
supported Cover Art Archive thumbnail sizes, and a thumbnail of
that size exists in the Cover Art Archive, fetch it directly
instead of fetching the full size image then resizing it.
2020-06-28 17:18:42 -04:00
Adrian Sampson
533cc88df2
Merge pull request #3639 from trolley/topic/coverart-fallback
...
Revert Cover Art Archive thumbnails
2020-06-27 19:46:45 -04:00
Adrian Sampson
3e32a4fb87
Merge pull request #3635 from jtpavlock/master
...
Fix genius lyrics backend artist matching with hyphens
2020-06-27 19:38:26 -04:00
Jacob Pavlock
685d21a8fb
changelog
2020-06-27 14:10:03 -07:00
Mark Trolley
a4c647be46
Revert "fetchart: Use Cover Art Archive thumbnails"
...
This reverts commit 2131f6f7d9
2020-06-27 16:26:52 -04:00
Mark Trolley
3232a5b8b7
Revert "Indentation fix"
...
This reverts commit 1e527ed4e5
2020-06-27 16:26:20 -04:00
Mark Trolley
71af5c04fc
Revert "Thanks & bug link for #3637 "
...
This reverts commit db181d35fb
2020-06-27 16:26:05 -04:00
