Commit graph

3860 commits

Author SHA1 Message Date
Thomas Scholtes
1526720982 Swap 'if not' and 'else' for readability 2014-09-14 11:49:33 +02:00
Thomas Scholtes
9e9f645e59 convert: add cli flag to skip confirmation
The flag mirrors the `--yes` flag from the modify command.
2014-09-14 11:46:24 +02:00
Thomas Scholtes
75a28de543 Extend and refactor 'never_convert_lossy_files' tests
* Each test function only uses on fixture, so we create fixtures in the
  test functions and not in the `setup()` method.

* We test the effect of the option set to true and false.
2014-09-14 11:35:01 +02:00
Thomas Scholtes
3197795faa convert: Change file extension only if actually transcoded
This makes the tests from a37cabb969
pass.
2014-09-14 11:27:59 +02:00
Thomas Scholtes
a37cabb969 Make 'never_convert_lossy_files' tests more meaningful
We should expect the original file extensions to be preserved since we
do not transcode lossy files. The tests now fail, but a fix is coming
up.
2014-09-14 11:17:43 +02:00
Adrian Sampson
f3e87b5b1b Changelog for #956 2014-09-13 23:49:56 -07:00
Adrian Sampson
af60272cc5 Merge pull request #956 from voidus/master
Added never_convert_lossy_files option to convert plugin
2014-09-13 23:45:16 -07:00
Adrian Sampson
c57439770b Collapse build_sql into _fetch (#953)
This was getting so short that it made sense to go back from whence it came.
2014-09-13 21:35:19 -07:00
Adrian Sampson
85de214399 Remove SQL ORDER BY sorting option
I don't think anything uses this anymore.
2014-09-13 21:19:32 -07:00
Adrian Sampson
2b921b19fd NullSort instead of None
A more descriptive placeholder for "don't sort".
2014-09-13 20:38:31 -07:00
Adrian Sampson
369533d46f Remove special_sorts
These are not extensible anyway; we'll need another mechanism for that.
2014-09-13 19:47:20 -07:00
Adrian Sampson
76c831a1cd Merge branch 'master' of github.com:sampsyo/beets 2014-09-13 17:19:04 -07:00
Adrian Sampson
4870d7e0fa Roll back fast flexible field sorts (#953)
Sad to see them go, but happy be rid of the SQL injection.
2014-09-13 17:16:12 -07:00
Simon Kohlmeyer
ee6f3dba1b fix coding style errors 2014-09-13 19:51:23 +02:00
Simon Kohlmeyer
9d55179d2d Added never_convert_lossy_files option to convert plugin
When set to true, this config option chooses copying over converting when the
source file is in a lossy format. At the moment, everything except ape, flac,
alac and wav is considered lossy.
2014-09-13 19:07:25 +02:00
robotanarchy
68eae9e683 didn't know about flake... 2014-09-13 17:25:10 +02:00
robotanarchy
5b0b3eee45 importfeeds: add new 'echo' type that writes to stdout 2014-09-13 17:11:00 +02:00
Thomas Scholtes
89c82dc63d fetchart: correctly handle path encoding
* Ensure that `config.as_str_seq()` returns a list of unicode objects.
* Map these to bytestring paths so we can compare them to other paths.

Fixes #887
2014-09-13 16:49:34 +02:00
Thomas Scholtes
0bb6348df3 fetchart: Add test that reproduces #887 2014-09-13 16:39:39 +02:00
Adrian Sampson
395be1a0f6 Fix missing super-constructor call 2014-09-12 21:40:00 -07:00
Adrian Sampson
cfb929223e Collapse some duplication in Confit templates 2014-09-12 21:28:32 -07:00
Adrian Sampson
f5b6431488 Flake8 fix 2014-09-12 21:12:44 -07:00
Adrian Sampson
db4e74fd57 Fix mistaken removals 2014-09-12 21:11:53 -07:00
Adrian Sampson
03d0f9dfb3 Fix namedtuple call 2014-09-12 20:59:19 -07:00
Adrian Sampson
bb4082fbfc Style cleanup in sorting 2014-09-12 20:58:25 -07:00
Adrian Sampson
d572bde13b Tiny docs typos
Conflicts:
	docs/plugins/index.rst
2014-09-12 20:58:24 -07:00
Adrian Sampson
ba93d6b176 Move flags back to _raw_main
SubcommandsOptionParser is supposed to be generic.
2014-09-12 20:57:48 -07:00
Thomas Scholtes
7328a09644 Align dispatch of 'version' command with other commands 2014-09-12 17:23:49 +02:00
Adrian Sampson
33da82cd12 Merge pull request #948 from KraYmer/lastgenre-doc
Add a link to whitelist raw file in lastgenre documentation
2014-09-11 23:28:04 -07:00
Fabrice L.
f11bbe6580 fix link 2014-09-12 08:16:01 +02:00
Fabrice L.
469b61689a Link to the internal whitelist raw file content 2014-09-12 07:50:50 +02:00
Thomas Scholtes
fc5f2126bb Add test helper for adding items 2014-09-11 22:47:55 +02:00
Adrian Sampson
4d72643b15 Merge pull request #945 from gwern/master
lastbeats: explain that the whitelist has been modified
2014-09-11 12:21:38 -07:00
Adrian Sampson
524f109339 Changelog for #944 2014-09-11 12:20:45 -07:00
Adrian Sampson
dc8654f4a0 Merge pull request #944 from gwern/patch-1
genres.txt: rm fake genres
2014-09-11 12:19:46 -07:00
gwern
971bff95fa lastbeats: explain that the whitelist has been modified
current description sounds like the whitelist is regularly synced and should not be/has not been edited
2014-09-11 14:38:33 -04:00
gwern
35efa7283f genres.txt: rm fake genres
see issue #943; deleted all suggestions except 'early music' which some people may want/find meaningful
2014-09-11 14:37:01 -04:00
Thomas Scholtes
5279016db4 config: Add suport for 'key in config' syntax
We can use this instead of the cumbersome `config[key].exists()`.
2014-09-11 16:09:26 +02:00
Thomas Scholtes
7958469b25 mediafile: Zero-padded date format
Tag files with '2000-08-01' instead of '2000-8-1'
2014-09-11 11:48:34 +02:00
Adrian Sampson
832f34c46c --version (fix #939) 2014-09-10 19:36:09 -07:00
Adrian Sampson
6dd6d4770e Skip zero-track matches (fix #942) 2014-09-10 19:08:39 -07:00
Adrian Sampson
3de66ccd65 Remove BitBucket references 2014-09-10 11:53:46 -07:00
Thomas Scholtes
9ee794beb7 Model.load() should remove flexible fields 2014-09-10 17:22:23 +02:00
Fabrice L.
5a799c7fbe Merge pull request #924 from nrgetik/patch-1
Update genres-tree.yaml using scraping script <https://github.com/nrgetik/genre-cannon>.
2014-09-10 10:23:56 +02:00
Thomas Scholtes
cfe82e9736 convert: Pipepline stage yields result 2014-09-09 23:41:47 +02:00
Thomas Scholtes
98ae8cbbc9 Make tests conform to PEP8 2014-09-09 22:31:46 +02:00
Thomas Scholtes
114d3f95bd Check conversion against custom format 2014-09-09 22:06:18 +02:00
Thomas Scholtes
8b73681cf3 Remove unused function 2014-09-09 20:23:32 +02:00
e5e4eaeacd39c5cfba4d7c852c48277ae50331e6
d3386df056 Merge remote-tracking branch 'origin/master'
Conflicts:
	beets/importer.py
	beets/ui/commands.py
	beetsplug/lyrics.py
2014-09-09 12:05:38 +10:00
e5e4eaeacd39c5cfba4d7c852c48277ae50331e6
816e4fb152 clean up after rebase 2014-09-09 11:53:44 +10:00