Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2025-12-28 19:42:42 +01:00
Code Issues Projects Releases Wiki Activity

convert: Change file extension only if actually transcoded

Browse source 
This makes the tests from a37cabb969
pass.
This commit is contained in:
Thomas Scholtes 2014-09-14 11:27:59 +02:00
parent a37cabb969
commit 3197795faa
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
beetsplug/convert.py
View file

@ -150,10 +150,9 @@ def convert_item(dest_dir, keep_new, path_formats, format, pretend=False):
# back to its old path or transcode it to a new path.
if keep_new:
original = dest
converted = replace_ext(item.path, ext)
converted = item.path
else:
original = item.path
dest = replace_ext(dest, ext)
converted = dest
# Ensure that only one thread tries to create directories at a
@ -194,6 +193,7 @@ def convert_item(dest_dir, keep_new, path_formats, format, pretend=False):
)
util.copy(original, converted)
else:
converted = replace_ext(converted, ext)
try:
encode(command, original, converted, pretend)
except subprocess.CalledProcessError:
@ -217,7 +217,12 @@ def convert_item(dest_dir, keep_new, path_formats, format, pretend=False):
if album and album.artpath:
embed_item(item, album.artpath, itempath=converted)
plugins.send('after_convert', item=item, dest=dest, keepnew=keep_new)
if keep_new:
plugins.send('after_convert', item=item,
dest=dest, keepnew=True)
else:
plugins.send('after_convert', item=item,
dest=converted, keepnew=False)
def convert_on_import(lib, item):