ybnd
f51a68c7e1
Implement comments
2020-01-30 19:53:05 +01:00
ybnd
65ffca215a
Exception handling in main & worker threads
...
* With `bs1770gain` installed the `Bs1770gainBackend` tests fail, but this should be fixed by https://github.com/beetbox/beets/pull/3480 .
2020-01-30 18:04:20 +01:00
ybnd
b903584163
Fix --threads argument handling
2020-01-30 13:31:14 +01:00
ybnd
b126ecafdd
Clean up single/multithreaded execution selection logic
...
As suggested in https://github.com/beetbox/beets/pull/3478#discussion_r372467445
2020-01-30 12:38:20 +01:00
ybnd
0fede91bbd
Workaround to pass ReplayGainLdnsCliMalformedTest.test_malformed_output ~ Python 3.8
2020-01-30 12:07:42 +01:00
ybnd
79c5535cf6
Open/close pool at begin/end of import session
2020-01-30 09:35:22 +01:00
ybnd
388d2d2c0d
Consolidate ThreadPool checking, opening and closing into methods
2020-01-30 09:35:22 +01:00
ybnd
42e895c239
Match --jobs default & signature to that of convert plugin (--threads)
...
And change local function `func` to `ReplayGainPlugin` method `replaygain_func` so that `self` is passed explicitly
2020-01-30 09:35:22 +01:00
ybnd
d95bb5683b
Analyze replaygain in parallel with multiprocessing.pool.ThreadPool
...
* Add `--jobs` or `-j` to `replaygain`-> set the pool size
* Single-threaded execution by default, if `--jobs` is unset
* If multithreaded, calls `Backend.compute_album_gain` or `Backend.compute_track_gain` asynchronously with metadata storing/writing in the callback
2020-01-28 21:20:21 +01:00
ybnd
a4a0a4bd28
Remove --replaygain flag when checking bs1770gain availability
...
bs1770gain exits with error 1 when called without data, interpreted as unavailable
2020-01-28 09:45:20 +01:00
Adrian Sampson
ca3142b1d9
Merge pull request #3467 from BrainDamage/keyfinder-cli
...
support for keyfinder-cli, which doesn't want the -f flag for paths
2020-01-14 08:24:54 -05:00
BrainDamage
f118314682
support for keyfinder-cli, which doesn't want the -f flag for paths
2020-01-14 05:07:33 +01:00
Adrian Sampson
a08f2315ea
Simplify Confuse usage ( #3463 )
2019-12-26 20:44:14 -05:00
Adrian Sampson
f0eede2ab4
Merge pull request #3463 from mathieupinet/fetchart_highresolution
...
fetchart: New high_resolution config option (#3391 )
2019-12-26 20:43:51 -05:00
Mat
2593a5be34
Use a local var to use high resolution option
2019-12-26 21:55:48 +00:00
Mat
7ad3f7f728
Apply suggestions from code review
...
Fix wording in docs
Co-Authored-By: Adrian Sampson <adrian@radbox.org>
2019-12-26 21:09:26 +00:00
Mat
3570f5cd56
New high_resolution config option in fetchart
2019-12-26 17:36:56 +00:00
Adrian Sampson
a9b19e1678
Merge pull request #3459 from cole-miller/index-tracks
...
discogs: Add `index_tracks` option (closes #3458 )
2019-12-18 15:59:35 -05:00
Cole Miller
ea02890be6
Merge remote-tracking branch 'origin/index-tracks' into index-tracks
2019-12-18 14:46:15 -05:00
Cole Miller
49d9f474a5
Update changelog
2019-12-18 14:44:57 -05:00
Cole Miller
e945ed894d
Add trailing comma
...
Co-Authored-By: Adrian Sampson <adrian@radbox.org>
2019-12-18 14:31:59 -05:00
Cole Miller
6c948764fe
Wrap comment lines
2019-12-17 17:56:56 -05:00
Cole Miller
614289af5f
Remove use of `list.clear()' for compatibility
2019-12-17 17:46:43 -05:00
Cole Miller
3ccafa2495
Fix `str.join' usage
2019-12-17 17:40:16 -05:00
Cole Miller
5f74edf2d9
One more documentation typo
2019-12-17 17:01:34 -05:00
Cole Miller
67e402bbae
Fix typo in new documentation
2019-12-17 16:57:24 -05:00
Cole Miller
90fb79f408
Document `index_tracks' option
2019-12-17 16:54:56 -05:00
Cole Miller
8805ba28fd
Add comments
2019-12-17 16:33:41 -05:00
Cole Miller
02e03be93d
Incorporate divisions into track titles
2019-12-17 15:38:54 -05:00
Cole Miller
e31695b606
Trace hierarchy of index tracks
2019-12-17 15:27:26 -05:00
Cole Miller
6889b9ffdc
Add `index_tracks' configuration option
2019-12-17 13:43:53 -05:00
Adrian Sampson
20630d1947
Merge pull request #3457 from mathieupinet/patch-1
...
Wording/grammar
2019-12-16 17:07:25 -05:00
Mat
e760fc6947
Wording/grammar
2019-12-16 21:47:13 +00:00
Adrian Sampson
bc9e9664fd
Drop Python 3.4; add Travis builds for 3.8
2019-12-10 13:03:53 -05:00
Adrian Sampson
2e24887f53
Changelog for #3449
2019-12-09 15:57:41 -05:00
Adrian Sampson
9739e9be9b
Docs tweaks for #3449
2019-12-09 15:55:31 -05:00
Adrian Sampson
40750cd3e2
Merge pull request #3449 from jef/patch-1
...
Added schema variable and added more logging
2019-12-09 15:50:51 -05:00
Jef LeCompte
89f21d9601
Updated documentation
2019-12-09 07:13:25 -05:00
Jef LeCompte
e18b91da26
Remove example
2019-12-06 18:32:35 -05:00
Jef LeCompte
5a38e1b35c
Refactored token generation and updated comments based on suggestions.
...
Also updated documentation to note the password options.
2019-12-06 18:30:52 -05:00
Jef LeCompte
1690c08e77
Added URL to config and deprecated old configuration
2019-12-06 15:05:36 -05:00
Adrian Sampson
60bba370c0
Credit & bug link for #3437
2019-11-25 08:45:30 -05:00
Adrian Sampson
28fb69a57a
Merge pull request #3437 from aereaux/consume_increment_playlist_version
...
Increment playlist_version when a track is consumed.
2019-11-25 08:44:52 -05:00
Aidan Epstein
9c479659b2
Increment playlist_version when a track is consumed.
...
This fixes the playlist not updating when in consume mode, at least in
ncmpcpp.
2019-11-24 19:27:09 -08:00
Adrian Sampson
6528609eb5
Merge pull request #3427 from timgates42/bugfix/typo_specifying
...
Fix simple typo: speicifying -> specifying
2019-11-11 16:56:39 -05:00
Tim Gates
33c0755aed
Fix simple typo: speicifying -> specifying
2019-11-12 08:07:37 +11:00
Adrian Sampson
cd29b3ce4a
Merge pull request #3422 from regagain/patch-1
...
Fix wrong section name (smartplaylist => playlist)
2019-11-03 13:50:52 -05:00
regagain
41cfe8bbb3
Fix wrong section name (smartplaylist => playlist)
...
See https://discourse.beets.io/t/playlist-vs-smartplaylist-plugins/975/2
2019-11-03 19:07:10 +01:00
Adrian Sampson
1513a5d4ef
Merge pull request #3420 from regisb/regisb/obsessive-compulsive
...
Replace the clinical "obsessive-compulsive" term
2019-11-02 22:00:23 -04:00
Régis Behmo
b489f94b0d
Replace the clinical "obsessive-compulsive" term
...
This is a follow-up on that conversation on gitter:
https://gitter.im/beetbox/beets?at=5d75ac34b3e2fc579379fe25
2019-11-02 23:26:14 +01:00
