Adrian Sampson
f400a2431e
fetchart: Fix path types on Windows
2016-06-08 10:20:25 -07:00
Adrian Sampson
93e614c739
Tests for _{in,out}_encoding ( #2041 )
2016-06-08 09:47:45 -07:00
Johnny Robeson
790b1b5153
replace some filter/map calls with list comps
...
These are places where the surrounding/calling code needs a list, not an iter.
2016-06-08 00:17:18 -04:00
Johnny Robeson
be474b3f52
wrap a call to filter in a list()
...
There are other filters like this in the master branch, but
2to3 converts them into list comprehensions. We'll deal with those
later
2016-06-06 17:26:06 -04:00
Adrian Sampson
8b62aa828c
Fix KeyFinder test assertion
2016-06-06 12:17:17 -07:00
Adrian Sampson
94372e87a8
Merge branch 'master' of github.com:sampsyo/beets
2016-06-06 11:54:33 -07:00
Adrian Sampson
90f4c77ea0
Skip permissions tests on Windows
2016-06-06 11:54:23 -07:00
Adrian Sampson
2322962cf8
Fix another sys.platform check
2016-06-06 11:51:32 -07:00
Adrian Sampson
8bf1f868fa
Fix comparison in a library type test
2016-06-06 11:46:51 -07:00
Adrian Sampson
a5b7489dd1
Use new assertion in config tests
2016-06-06 11:40:04 -07:00
Adrian Sampson
8359b9e90f
Tests: path equality assertion
2016-06-06 11:30:38 -07:00
Adrian Sampson
1c1c73b062
Check for convert failures
2016-06-06 11:01:10 -07:00
Adrian Sampson
ad74da1149
Refactor similarity tests
...
The upshot is we can now compare the two Popen invocations
independently.
2016-06-06 10:58:25 -07:00
Adrian Sampson
bfa56b1d8d
Tests: fix mocking of art.extract
2016-06-06 10:08:30 -07:00
Adrian Sampson
5db8f69bc1
Fix invocation signature for check_art_similarity
...
The second argument is an Item, not a filename.
2016-06-05 12:37:05 -07:00
Adrian Sampson
746aecad2b
Fix a sys.platform check in hidden test
2016-06-05 12:28:47 -07:00
Adrian Sampson
60b4172a59
Tests: don't use None as a path stand-in
...
This triggered a crash in `syspath` on Windows.
2016-06-05 12:26:51 -07:00
Adrian Sampson
2f9aa41614
Clean up SQLite connections in test harness
...
Windows complains that we can't remove the test database file if open
connections remain.
2016-06-05 11:56:09 -07:00
Johnny Robeson
9ed9faf246
add some b' to paths in sort tests
2016-06-02 18:52:32 -04:00
Adrian Sampson
2228e0e8e1
More binary-mode open in tests
2016-06-02 11:52:56 -07:00
Adrian Sampson
82640260c2
Tests: don't unload the beetsplug module
...
This was added in 1666f883e3 back in 2013. I'm
not sure why this *ever* worked to get beetsplug to point to the right
directory, but I believe it was superseded by the path manipulation in
aa07eb9551 , added in 2014. And now, it's causing
problems on Windows, where for some reason it's causing `import beetsplug.x`
to silently succeed but yield an empty `beetsplug`, without `x` in the
namespace.
2016-06-02 11:41:25 -07:00
Adrian Sampson
07c95a1bf1
Require an imaging backend for fuzzy ratio tests
...
These fail outright if we don't have a way to get image sizes (e.g.,
ImageMagick).
2016-06-02 11:39:05 -07:00
Adrian Sampson
e71e17d924
Open image file as binary in tests
2016-06-02 10:17:02 -07:00
Adrian Sampson
9f8b81a5ad
Fix variable reference in stub
2016-05-31 18:13:50 -07:00
Adrian Sampson
e8c8f9fb14
Possibly make the convert stub work on Windows
2016-05-31 18:08:26 -07:00
Adrian Sampson
f96aa24a79
Convert stub: use __future__ imports
...
Even tiny stubs can't escape the wrath of flake8!
2016-05-31 17:55:12 -07:00
Adrian Sampson
fc3f64de95
Convert stub: Python 3 compatibility
...
Important for systems where `python` is 3.x, like Arch, even when beets itself
is running on Python 2.
2016-05-31 17:52:32 -07:00
Adrian Sampson
40369c6ab2
Move convert stub script to its own file
2016-05-31 17:50:54 -07:00
Adrian Sampson
469aee9848
Correctly encode arguments in tests
2016-05-31 15:32:09 -07:00
Adrian Sampson
9e27c9e5ac
Fix duplicated argument in test
2016-05-31 15:19:34 -07:00
Adrian Sampson
17681145c2
Fix a too-long line
2016-05-31 13:52:27 -07:00
Adrian Sampson
6ff7271ea0
Refactor convert command tests
...
This lets us force the use of explicit path: queries on the command line
instead of implicit path queries. This is more robust and works on
Windows, which currently gets confused when path components start with
`c:`.
2016-05-31 13:46:44 -07:00
Adrian Sampson
5b2fb8dcdc
Queries with \ are path queries on Windows
2016-05-31 13:29:00 -07:00
Adrian Sampson
1eb03a0de5
Query tests: use normalized paths
...
Match ordinary beets behavior by storing normalized paths in the
database. This matters on Windows, where normalization adds backslashes
and drive letters.
2016-05-31 13:12:32 -07:00
Adrian Sampson
33a4767eaf
Portable mock command for testing convert plugin
2016-05-31 11:48:29 -07:00
Adrian Sampson
395877d903
Remove the Echo Nest plugin 😢 ( #1920 )
2016-05-30 22:25:58 -07:00
Johnny Robeson
330306bbe2
remove bytes casts from object/method resolution code
2016-05-30 23:21:24 -04:00
Johnny Robeson
35c539b5a4
remove b' from various web request respones
2016-05-30 21:30:17 -04:00
Johnny Robeson
cd1f79340f
remove explicit b' from sql query dict key names
2016-05-30 18:50:11 -04:00
Johnny Robeson
c52394c499
fix the rest of b'__main__':
2016-05-30 01:11:37 -04:00
Adrian Sampson
71b9fd785c
Revert "Do __name__ comparison with bytes and not unicode"
...
This reverts commit 9c41c39913 .
That commit used byte strings for the `if __name__ == '__main__'` pattern,
which was necessary when we were doing unicode_literals. But it is wrong on
Python 3, and now that we're liberated from unicode_literals, we need to go
back to native strings for this comparison.
2016-05-29 19:19:59 -07:00
Johnny Robeson
a37a52633b
replace deprecated assertNotEquals() with assertNotEqual()
2016-05-29 04:03:54 -04:00
Johnny Robeson
c330f3abc3
replace deprecated assert_() with assertTrue()
2016-05-29 03:56:39 -04:00
Johnny Robeson
ce8d7bf9f1
remove unittest2 import (py < 2.7)
2016-05-27 23:46:33 -04:00
Markus Unterwaditzer
0fc07c28bc
Stylefixes
2016-05-28 00:26:57 +02:00
Markus Unterwaditzer
1ae6ce04dd
Run python-modernize across the codebase
2016-05-27 23:13:01 +02:00
Johnny Robeson
b99a6acc54
use next() instead of iter.next() throughout
2016-05-27 17:00:40 -04:00
Johnny Robeson
7f41d5c188
use 0o prefix when we want octal
2016-05-26 22:31:55 -04:00
Johnny Robeson
cede0ed466
remove leading 0 when octal is unwanted
2016-05-26 22:31:25 -04:00
Johnny Robeson
5963595f32
Add safe_cast tests for . and 1.0.0
2016-05-26 00:57:16 -04:00