root
f37df2dbd4
Whitespace for flake8.
2016-11-08 16:56:13 -08:00
root
acd5c6404f
missing plugin, modify "missing" attribute by modifying album_types,
...
making it of type INTEGER. also changelog for above.
2016-11-08 16:23:57 -08:00
Nathan Dwek
ddbad5817d
Merge pull request #2255 from beetbox/fix-2254-1545
...
Rewrite handling of images extensions and mimetype
2016-11-08 20:06:34 +01:00
nath@home
f236816431
embedart: Changelog for #2255
2016-11-08 18:48:44 +01:00
nath@home
3b4b9085ea
utils.collections: rename IdentityUnlessDict to IdentityFallbackDict
2016-11-08 18:48:44 +01:00
nathdwek@laptop
e782885e50
embedart: Adapt tests for #2254
2016-11-08 18:48:44 +01:00
nathdwek@laptop
92ee141662
images: use jpg extensions for jpeg files everywhere
...
fix #2254
2016-11-08 18:48:44 +01:00
nathdwek@laptop
a0877dc092
images: Make sure all jpegs work everywhere
...
Apply #1545 to a public function used everywhere
2016-11-08 18:48:44 +01:00
nathdwek@laptop
3b372c05d6
art: fix a docstring typo
2016-11-07 16:03:56 +01:00
Adrian Sampson
5dd6eedde0
Merge pull request #2240 from maxammann/master
...
Revert "Expose the relative path to the library instead of omitting t…
2016-10-26 18:23:49 -04:00
Max Ammann
7242c5ed03
Revert "Expose the relative path to the library instead of omitting the 'path' variable"
...
This reverts commit 5e8ac9e4a5Resolves #2182 .
2016-10-26 23:08:44 +02:00
Adrian Sampson
bb9a107c56
Slight rewording in docs about SIP
2016-10-26 13:40:45 -04:00
Adrian Sampson
c4a5dc2436
"macOS"
2016-10-26 13:37:09 -04:00
Adrian Sampson
c2dbe8375b
Merge pull request #2239 from claman/master
...
Add workaround for SIP
2016-10-26 13:36:08 -04:00
Alex Claman
ee22165876
Add workaround for SIP
2016-10-26 11:52:45 -05:00
Adrian Sampson
c426b76cce
Changelog/thanks for #2231
2016-10-23 16:38:17 -04:00
Adrian Sampson
dab54043a1
Merge pull request #2231 from dangmai/selective-update
...
Selective field updates
2016-10-23 16:36:33 -04:00
Adrian Sampson
eef5746ae6
Merge pull request #2233 from beetbox/drop-reduce
...
Drop `reduce` imports
2016-10-23 16:16:38 -04:00
Dang Mai
05377ee7c4
Fixing line too long
2016-10-23 16:00:36 -04:00
Dang Mai
04560bd88e
Stop passing in fields to be stored for Item.move and Album.move
2016-10-23 15:52:27 -04:00
nathdwek@laptop
cee6c5fe52
Rewrite match_by_id to fix next vs __next__
2016-10-22 12:37:38 +02:00
nathdwek@laptop
e94676e322
Refactor match_by_id:
...
* Drop reduce
* Readability
2016-10-22 10:37:53 +02:00
Dang Mai
f91362a069
Cosmetic refactors based on feedback
2016-10-21 16:56:03 -04:00
Dang Mai
8d07bfe693
Documentation for new flag
2016-10-20 23:33:20 -04:00
Dang Mai
f42f558db2
Fix long line for flake8
2016-10-20 21:21:50 -04:00
Dang Mai
406f3ce843
Add tests and make sure they pass
2016-10-20 21:07:12 -04:00
Dang Mai
f17601e4cd
Fix update test failures
2016-10-20 20:25:38 -04:00
Dang Mai
679918f191
Fix some test failures
2016-10-20 00:28:28 -04:00
Dang Mai
acd2b0ef77
First attempt for selective field updates
2016-10-20 00:04:07 -04:00
Diego M. Rodríguez
6402e05d5a
Merge pull request #2228 from diego-plan9/discogs-disc0
...
discogs: set `track.medium` correctly for single medium albums
2016-10-19 14:58:55 +02:00
Diego Moreda
2604bc8e73
discogs: update changelog for medium
2016-10-17 20:02:39 +02:00
kooimens
373cf19f8b
Fix discogs disc field is set to zero
...
Fixes #587 . The disc field is only zero when there is only one medium, so I think this will do the trick. I wasn't able to reproduce the real problem within the code. This is just a small workaround.
2016-10-17 19:51:03 +02:00
Diego Moreda
fc9f061574
discogs: add tests for medium, medium_total
...
Add three tests for the setting of tracks' medium and medium_total on
the discogs plugin. test_parse_medium_numbers_single_medium is meant
to fail due to #587 .
2016-10-17 19:48:06 +02:00
Diego M. Rodríguez
89c40914a5
Merge pull request #2222 from diego-plan9/discogs-fixes
...
Several discogs fixes
2016-10-17 16:55:43 +02:00
vapniks
44f33cabc7
Update _beet
...
update documentation
2016-10-10 19:45:03 +01:00
Diego Moreda
1f4bef9e61
discogs: docstring style fix
2016-10-10 20:30:21 +02:00
Diego Moreda
c5ae9c5bee
discogs: update changelog
2016-10-10 20:27:42 +02:00
Diego Moreda
f4907ca5d0
discogs: handle nested subtracks, add try block
...
Modify coalesce_tracks() in order to handle the case where subtracks
are defined inside an index track (as `sub_tracks` attribute),
reorganizing the if logic to avoid duplicated code.
Add a try..catch block enclosing the call to clean_tracklist, as a
measure for avoiding side effects (and reverting to just parsing the
raw_list if there are any problems).
2016-10-10 19:59:42 +02:00
Diego Moreda
fb398c5f2c
discogs: add medium_total to tracks ( #415 )
2016-10-10 17:46:41 +02:00
Diego Moreda
1148acaaf1
discogs: revise position regexp, add tests, tox
...
Revise the regular expression used for extracting information from a
discogs position, making the subtrack_index only be matched if one of
the other groups is matched as well. Split the definition into several
lines in order to try to document it a bit more clearly.
Add unit tests for position parsing and non standard positions.
Fix the underscore on tox dependency.
2016-10-10 17:42:27 +02:00
Diego Moreda
e7f2a111e4
discogs: add test dependencies, fix spelling
2016-10-09 17:57:36 +02:00
Adrian Sampson
13cf1bff8f
Tiny text simplifications ( #2223 )
2016-10-08 18:41:16 -04:00
Nathan Dwek
4b88a879eb
Merge pull request #2223 from beetbox/doc-play-small-fixes
...
Misc fixes to play documentation.
2016-10-08 20:44:26 +02:00
nath@home
8bd6181c6a
doc-play: Fix a header level.
2016-10-08 14:47:38 +02:00
nath@home
f30c5da2ab
doc-play: Fix an error and clarity:
...
{} is not used any more to determine the location of parameters
passed with --args.
Fix two sentences for clarity/fluidity. Display the plugin's
abilities in the intro.
2016-10-08 14:37:57 +02:00
Diego Moreda
be223d966e
discogs: coalesce subtracks ( #1543 )
...
Detect subtracks and merge them into a single track, taking into account
the index tracks if present. This includes a revision of the regular
expression used for converting a discogs "position" into medium, medium
index and subtrack index pieces, following the standard discogs
positions (12.2.9).
2016-10-07 19:09:09 +02:00
Diego Moreda
c55885c9e8
discogs: take into account two-sided media ( #1762 )
...
Revise the discogs plugin so two-sided mediums are taking into account
and each pair of consecutive *sides* is treated as single *medium*.
2016-10-07 19:01:50 +02:00
Diego Moreda
1c63d0bbab
discogs: add more unit tests
...
Add unit tests covering the discogs standard positions (12.2.9). Clean
up a bit the helper methods (unused parameters, documentation).
https://www.discogs.com/help/submission-guidelines-release-trk.html#Position
2016-10-07 18:44:55 +02:00
Diego Moreda
911117ef49
discogs: set media on tracks ( #1921 )
...
Set the media for all the tracks when fetching a release using discogs,
as autotag.apply_metadata requires it in order to work properly.
2016-10-06 19:49:43 +02:00
Diego Moreda
9c88998a5d
discogs: add initial unit test skeleton
...
Add a first skeleton for providing unit tests for the discogs plugin,
heavily inspired by test_mb, which adds a couple of method for creating
very simple and not comprehensive Bags that mimic discogs_client.Release
and discogs_client.Track.
Add a test for checking the problem of setting media for the Tracks.
2016-10-06 19:31:55 +02:00
