Commit graph

3300 commits

Author SHA1 Message Date
Adrian Sampson
b1ae7cb692 whitespace fixes in util 2014-04-03 19:56:59 -07:00
Adrian Sampson
4e2b35f372 avoid use of deprecated os.popen 2014-04-03 19:54:15 -07:00
Adrian Sampson
c5174b3881 use command_output utility in echonest
That's the last direct use of the subprocess calls.
2014-04-03 19:51:50 -07:00
Adrian Sampson
d407db725f convert: catch OSErrors and display error message
This also adds close_fds (only available on Unixes) to the common subprocess
invocation utility.
2014-04-03 19:47:21 -07:00
Thomas Scholtes
eb4c323bcb Plugins can now extend MediaField 2014-04-04 00:48:29 +02:00
Thomas Scholtes
4b1a1e3d65 Remove ITEM_KEYS_WRITABLE 2014-04-04 00:03:40 +02:00
Thomas Scholtes
3c7dd13b72 Add Item.media_fields
This new property controls which fields to read from a media file.
2014-04-03 23:35:33 +02:00
Adrian Sampson
ac99622ec7 Merge branch 'single-files'
Conflicts:
	docs/changelog.rst
2014-04-03 13:20:53 -07:00
Adrian Sampson
7f9e301428 fix tests for cached weights loading 2014-04-03 13:17:38 -07:00
Thomas Scholtes
2011156f8b Add test case for single file import 2014-04-03 22:13:31 +02:00
Adrian Sampson
b814168fb6 Merge branch 'master' of github.com:sampsyo/beets 2014-04-03 13:01:05 -07:00
Adrian Sampson
729e001432 benchmark: customizable album ID 2014-04-03 13:00:20 -07:00
Thomas Scholtes
eaab0bcc6e Enable coverage with tox -e py27 2014-04-03 21:46:54 +02:00
Adrian Sampson
3372fd3066 avoid unnecessarily reloading weights (#609)
In my profiling runs, this was taking 80% of the matching time to recompute
exactly the same dict over and over. Worth optimizing.

`beet bench_match` went from 80 seconds to 17 seconds on my machine with this
change.
2014-04-03 12:13:29 -07:00
Kyle Konrad
7f3092ce5a four space indentation and assertGreater for __gt__ coverage 2014-04-03 12:04:51 -07:00
Adrian Sampson
9285f669e9 style fixes in match.py 2014-04-03 11:58:00 -07:00
Adrian Sampson
cd57c8da7f benchmarking for slow matches
Investigating #609. The culprit seems to be repeated reading of the config's
weight settings.
2014-04-03 11:56:26 -07:00
Thomas Scholtes
c4f0928bf5 Read custom fields into database 2014-04-03 14:01:56 +02:00
Thomas Scholtes
b262edd972 Migrate ITEM_KEYS_META 2014-04-03 14:01:56 +02:00
Thomas Scholtes
43ae730a6a Use readable_fields() to replace ITEM_KEYS_META 2014-04-03 14:01:56 +02:00
Thomas Scholtes
9474686d68 Use indexed format with python26 2014-04-03 14:01:56 +02:00
Thomas Scholtes
863b9fb4af MediaFile can be extended with custom fields 2014-04-03 14:01:55 +02:00
Thomas Scholtes
a2a8b244d7 Add LazySave tests for MediaFile 2014-04-03 14:01:55 +02:00
Thomas Scholtes
5b6305b610 Compute ITEM_KEYS_WRITABLE
See 65d64a7d50612df4ee6127ff05e591ae6fcceac0 why this is possible.
2014-04-03 14:01:55 +02:00
Thomas Scholtes
bedad53c27 Test that we can migrate ITEM_KEYS_WRITABLE
The test show that we can replace the hard-coded `ITEM_KEYS_WRITABLE` constant
with the computed value derived from `MediaField.fields()` and ITEM_KEYS. This
will be done in the next commit.
2014-04-03 14:01:55 +02:00
Thomas Scholtes
bcb72becf8 Add MediaFile.update() method to supersede save() 2014-04-03 14:01:55 +02:00
Thomas Scholtes
b026d60c31 Add MediaFile.fields() method 2014-04-03 14:01:55 +02:00
Adrian Sampson
d116e03bed ensure lists of paths are passed to ImportTask
Also change the variable name from `path` to `paths` to reflect this.
2014-04-02 21:57:30 -07:00
Adrian Sampson
c6abfa57c7 docs: link to beets-check plugin 2014-04-02 21:20:03 -07:00
Adrian Sampson
b683f239f0 some style tweaks for #638 2014-04-02 21:18:41 -07:00
Adrian Sampson
0c049f2e5c tox: restore pypy/py26 configs, sphinx -q (#643) 2014-04-02 20:47:04 -07:00
Adrian Sampson
c4be9c273f Merge pull request #643 from geigerzaehler/tox-flake8-travis
Use tox to test on travis and add docs and flake8
2014-04-02 20:39:22 -07:00
Adrian Sampson
c9141a6adf import single files and one-track albums
An alternate proposal for what's being discussed in #640.
2014-04-02 17:14:48 -07:00
Thomas Scholtes
9fab6e7ca3 Use coverage only with py27 2014-04-03 01:52:21 +02:00
Thomas Scholtes
8488f665fc Add sphinx dependency to tox virtual environment 2014-04-03 01:41:18 +02:00
Thomas Scholtes
7927146f12 We need sphinx before installing the tox environment 2014-04-03 00:58:57 +02:00
Kyle Konrad
142374925f add util test file with tests for enumerations. fix super() bug 2014-04-02 15:31:28 -07:00
Thomas Scholtes
2ff7735f89 Sphinx is required to build the package 2014-04-02 23:49:35 +02:00
Thomas Scholtes
fdd2849fec Ignore generated man pages 2014-04-02 22:56:24 +02:00
Thomas Scholtes
bee80c4c49 Use tox to test on travis and add docs and flake8
Travis CI now also confirm that the docs build correctly and the flake8 runs
succesfully. Tox also has the advantage that it tests that beets installs
correctly.

Currently flake8 does not run succesfully so it is configured to not fail the
build on Travis.
2014-04-02 22:48:53 +02:00
Thomas Scholtes
100b3d4d65 Make mediafile tests independent of image order
For MP3s mutagen stores image tags in a hash with the `APIC:...` key. The order
of the images is therefore not well defined. A similar issue occurs with WMAs.
2014-04-02 22:15:00 +02:00
Kyle Konrad
64da4985b0 add enum34 to install_requirments 2014-04-02 10:39:34 -07:00
Kyle Konrad
c4e6f38963 use the new python enum instead of hand-rolled version 2014-04-02 10:23:48 -07:00
brilnius
d02e02fe20 Merge pull request #638 from brilnius/ui_del_attr2
Modify command: ability to delete/reset an attribute (beet modify field!)
2014-04-01 22:47:03 +02:00
Bruno Tournay
cd70e92b7f Modify command: ability to delete/reset an attribute (beet modify field!) 2014-04-01 22:38:33 +02:00
Adrian Sampson
0118ef336d Merge pull request #636 from skeuomorf/notifications
Add irc notifications by travis
2014-04-01 11:01:01 -07:00
Adrian Sampson
1f5717ca97 Merge pull request #635 from skeuomorf/badges
Add badges of travis and coverage to README
2014-04-01 11:00:27 -07:00
Mohammed Attia
0ef5ce2847 Add irc notifications by travis 2014-04-01 08:18:05 +02:00
Mohammed Attia
975e010e18 Add badges of travis and coverage to README 2014-04-01 08:12:08 +02:00
Adrian Sampson
8d196a8c01 changelog for #632 2014-03-26 13:39:12 -07:00