Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2025-12-16 05:34:47 +01:00
Code Issues Projects Releases Wiki Activity

Read custom fields into database

Browse source
This commit is contained in:
Thomas Scholtes 2014-04-03 14:00:11 +02:00
parent b262edd972
commit c4f0928bf5
3 changed files with 18 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
beets/library.py
View file

@ -397,7 +397,7 @@ class Item(LibModel):
except (OSError, IOError) as exc:
raise ReadError(read_path, exc)
for key in ITEM_KEYS_META:
for key in list(ITEM_KEYS_META) + MediaFile.custom_fields:
value = getattr(f, key)
if isinstance(value, (int, long)):
# Filter values wider than 64 bits (in signed

3
beets/mediafile.py
View file

@ -1276,6 +1276,8 @@ class MediaFile(object):
'channels', 'format']:
yield property
custom_fields = []
@classmethod
def add_field(cls, name, descriptor):
"""Add a field to store custom tags.
@ -1293,6 +1295,7 @@ class MediaFile(object):
if name in cls.__dict__:
raise ValueError(
u'property "{0}" already exists on MediaField'.format(name))
cls.custom_fields.append(name)
setattr(cls, name, descriptor)
def update(self, dict, id3v23=False):

14
test/test_mediafile.py
View file

@ -272,6 +272,7 @@ class ExtendedFieldTestMixin(object):
mediafile = MediaFile(mediafile.path)
self.assertEqual(mediafile.initialkey, 'F#')
delattr(MediaFile, 'initialkey')
MediaFile.custom_fields = []
def test_extended_attribute_from_item(self):
MediaFile.add_field('initialkey', field_extension)
@ -284,6 +285,19 @@ class ExtendedFieldTestMixin(object):
mediafile = MediaFile(mediafile.path)
self.assertEqual(mediafile.initialkey, 'Gb')
delattr(MediaFile, 'initialkey')
MediaFile.custom_fields = []
def test_flexible_attribute_from_file(self):
MediaFile.add_field('initialkey', field_extension)
mediafile = self._mediafile_fixture('empty')
mediafile.update({'initialkey': 'F#'})
item = Item.from_path(mediafile.path)
self.assertEqual(item['initialkey'], 'F#')
delattr(MediaFile, 'initialkey')
MediaFile.custom_fields = []
def test_invalid_descriptor(self):
with self.assertRaises(ValueError) as cm: