Adrian Sampson
e235cb7c42
Remove vestiges of diff_method option
2015-11-14 12:56:53 -08:00
Adrian Sampson
d7d609442e
Remove diff_method option
...
Our built-in "diff"-like functionality is pretty good because it's aware of
beets' data structures and types. This makes it more legible, in my opinion,
than an ordinary textual diff. So for now, I'm making this the only option (in
the spirit of making the plugin as straightforward as humanly possible).
2015-11-14 12:53:45 -08:00
Adrian Sampson
71e1547291
Remove some communication through fields
...
This is the first of many changes to reduce the use of `self.x` where plain
parameter passing can make things more clear.
2015-11-14 12:50:53 -08:00
Adrian Sampson
54b61ee2d4
Merge pull request #1717 from jmwatte/editor
...
change opts.extra to type choice
2015-11-13 13:20:58 -08:00
jmwatte
5eca75321e
simplify by removing sum-option and renaming for clarity
2015-11-13 17:56:03 +01:00
jmwatte
024ab0159b
remove webbrowser for opening default editor/browser
2015-11-13 15:03:27 +01:00
jmwatte
386578d69c
change opts.extra to type choice
2015-11-13 11:24:19 +01:00
Diego Moreda
d9ebb3409a
edit: add album query tests, revise failing ones
...
* Add tests for executing the command with album queries (-a), testing the edit
of album and albumartist fields.
* Revise invalid and malformed yaml tests so they return a failure instead of
an error.
2015-11-11 15:50:32 +01:00
Diego Moreda
6e6aa9700d
edit: more assertions on existing tests, new tests
...
* Modify existing tests in order to explicitely check for differences (or lack
of) in the items fields, with the intention to ensure that no unintended changes
slip through.
* Added tests for modifying a single item from a list of items, and for editing
the album field of the items (stub for discussing whether the actual album
should be updated, etc).
2015-11-10 19:16:04 +01:00
Adrian Sampson
66a22dffd9
Merge pull request #1711 from diego-plan9/editor
...
editor: add unit tests, minor changes
2015-11-09 17:11:04 -08:00
Diego Moreda
41b4987990
edit: add initial black-box tests
...
* Add tests for the edit plugin, including a helper for bypassing the manual
yaml editing. Tests are focused on "black-box" functionality, running the
command and making assertions on the changes made to the library.
2015-11-09 21:51:14 +01:00
Diego Moreda
1c09eeb714
edit: delete temporary files, minor style fixes
...
* Delete NamedTemporaryFiles once they are not needed on several functions
(change_objs(), vimdiff(), html()).
* Fix use of reserved word "id" on same_format().
* Colorize "really modify" prompt with action_default.
2015-11-08 19:37:10 +01:00
Diego Moreda
a71b2e1046
editor: update plugin name on examples on docs
2015-11-08 16:09:41 +01:00
Adrian Sampson
331ced3cca
Use existing query mechanism
2015-11-07 12:51:22 -08:00
Adrian Sampson
417eb5e588
Remove use of nonexistent option
2015-11-07 12:46:35 -08:00
Adrian Sampson
519df6da04
Use standard output format for confirmation
2015-11-07 12:45:39 -08:00
Adrian Sampson
7de33c83c4
Remove an unused parameter
2015-11-07 12:39:31 -08:00
Adrian Sampson
fefb2e9914
A little cleanup for legibility and style
2015-11-07 12:36:22 -08:00
jmwatte
f95611dde4
fixed albumid needs to be int
2015-11-05 16:51:33 +01:00
jmwatte
17a32e33c5
added grouping of fields and "$BROWSER" and "$EDITOR"
2015-11-05 15:41:33 +01:00
jmwatte
51658a7ea6
Merge branch 'editor' of https://github.com/jmwatte/beets into editor
2015-11-05 15:18:46 +01:00
jmwatte
ab3bc356b2
updateMerge branch 'master' of https://github.com/sampsyo/beets into editor
2015-11-05 15:13:07 +01:00
Adrian Sampson
7d52fa72ae
Fix #1699 : Outdated API call
...
get_fields() was removed in 5420599839
2015-11-04 20:25:17 -08:00
Adrian Sampson
19cf37263d
Fix #1700 : Tolerate missing Location in iTunes
2015-11-04 20:11:58 -08:00
Adrian Sampson
be49955884
metasync: More precise exception catching ( #1700 )
2015-11-04 20:07:49 -08:00
reiv
a7952b1b1d
Merge pull request #1681 from sampsyo/314-reimport-art
...
Fix #314 : Delete old album art during re-import
2015-11-04 18:46:45 +01:00
reiv
81a72f74c9
Merge branch 'master' into 314-reimport-art
2015-11-04 18:37:06 +01:00
reiv
e32dda78b8
Changelog for #1681
2015-11-04 18:33:52 +01:00
reiv
0ebc4c799d
fetchart: in auto, ignore albums with art
...
When re-importing an album, we don't want fetchart to interfere
with any existing album art.
2015-11-04 15:08:42 +01:00
jmwatte
afedfbf2aa
Update index.rst
...
added the edit plugin
2015-11-04 09:11:46 +01:00
Adrian Sampson
a735a6b4a2
discogs: Better exception logging
...
Might have helped diagnose #1669 more easily.
2015-11-03 22:38:31 -08:00
Adrian Sampson
023a33ca31
Revert "Fix #1656 , maybe: encode Discogs token strings"
...
This reverts commit f784cd1a22
2015-11-03 22:29:33 -08:00
reiv
314dd0e6bc
Update re-import test to leave no orphaned art
...
Make sure that when an album is re-imported and its files are
moved, the artwork isn't left behind in the old folder.
2015-11-03 23:10:01 +01:00
reiv
32934bd16a
Preserve album art on re-import ( fixes #314 )
...
Copy the replaced album's artpath attribute to the new album. This
causes the image file to be moved along with the music files.
2015-11-03 22:43:05 +01:00
reiv
21f926fb89
Add test for #314
...
Ensure that album art is preserved when an album is re-imported.
2015-11-03 22:38:13 +01:00
jmwatte
67a46b6e08
Update changelog.rst
...
change name from yamleditor to edit
2015-11-03 15:13:01 +01:00
jmwatte
8b23c89318
Update edit.rst
...
polishing
2015-11-03 15:03:14 +01:00
jmwatte
1f3a42faf0
Update edit.py
2015-11-03 14:57:07 +01:00
jmwatte
76509e1682
Update edit.rst
...
polishing
2015-11-03 14:37:34 +01:00
jmwatte
5a8a534a3f
Delete yamleditor.py
2015-11-03 14:05:06 +01:00
jmwatte
91f67146f9
Delete yamleditor.rst
2015-11-03 14:04:39 +01:00
jmwatte
00b21dfa51
Merge branch 'editor' of https://github.com/jmwatte/beets into editor
2015-11-03 13:59:38 +01:00
jmwatte
2d77861e4d
renamed and updated editplugin
2015-11-03 13:55:08 +01:00
reiv
33ea9f1c10
Revert all changes on this branch thus far
...
Revert "PEP8 amendments"
This reverts commit 413fe6bbfd629a80a1d1
2015-11-03 11:33:35 +01:00
Adrian Sampson
38edb18a74
Merge pull request #1683 from sampsyo/1264-unnecessary-resize
...
Fix #1264 : Avoid unnecessary art resizes
2015-11-02 22:39:06 -08:00
reiv
1625dfc17e
Merge branch 'master' into 1264-unnecessary-resize
2015-11-03 02:46:33 +01:00
reiv
5d0048c03d
Changelog for #1683
2015-11-03 02:38:02 +01:00
reiv
19dcc25a93
fetchart: Improve validation of image dimensions
...
This avoids images being resized unnecessarily if the dimensions
are correct.
2015-11-03 02:19:47 +01:00
reiv
93009911e0
fetchart: Add test for image resizing
...
This test ensures that images are resized if and only if they are
wider than the maxwidth setting.
2015-11-03 02:17:21 +01:00
Adrian Sampson
bfa2fbf6af
Changelog for #1675
2015-11-02 16:46:32 -08:00
