Bruno Cauet
e1e46df1b3
Fix path truncation test: really use bytes
...
Test is to use bytes but because of __future__.unicode_literals it used
unicode.
2015-02-12 11:56:54 +01:00
Bruno Cauet
54abd1a510
Merge branch 'invalidqueryerror'
2015-02-09 21:29:01 +01:00
Bruno Cauet
7476d6be46
InvalidQuery*Error extend ParsingError
...
And InvalidQueryArgumentTypeError does not extend TypeError anymore.
2015-02-09 19:25:23 +01:00
Bruno Cauet
f443e0bfc5
InvalidQueryArgumentTypeError does not extend InvalidQueryError
...
Places where InvalidQueryArgumentTypeError may be raised (i.e. all
current ones) may not know the query therefore it cannot be an
InvalidQueryError. The InvalidQueryArgumentTypeError is caught in
beets.library.Library._fetch() and an InvalidQueryError is then raised.
Improve #1290 .
2015-02-09 15:44:49 +01:00
Bruno Cauet
54887e7655
Widen usage of InvalidQueryError
...
Replace previous InvalidQueryError with InvalidQueryArgumentTypeError
which extends the former as TypeError. However they lack context: the
query that caused the error.
Raise an InvalidQueryError when a shell-like expression cannot be parsed
by shlex.
Improve #1290 .
2015-02-09 15:28:06 +01:00
Tom Jaspers
6572e1bf5a
Fetchart: add empty album check to iTunes art
...
Was causing some tests to fail in test_art.py:CombinedTest
2015-02-09 14:59:56 +01:00
Tom Jaspers
bbc6d0906b
Merge pull request #1312 from tomjaspers/album-path-queries
...
Album path queries get constructed properly
Fix #1307
2015-02-08 16:43:55 +01:00
Tom Jaspers
0a81aae142
PathQueryTest: rename assert_matched for items
2015-02-08 16:34:28 +01:00
Adrian Sampson
66b7e4cd39
Merge branch 'master' of github.com:sampsyo/beets
2015-02-07 12:52:20 -08:00
Adrian Sampson
e7f8a627e9
Style fixes for pep8 1.6
2015-02-07 12:51:54 -08:00
David Logie
9b9c033df6
importfeeds: Fix Unicode error when writing files.
2015-02-07 15:13:01 +00:00
Tom Jaspers
3ec44aab3e
Update _types field instead of assigning it
...
Assigning it would override our pre-defined types
(such as `path` in Album._types)
2015-02-06 10:42:46 +01:00
Tom Jaspers
049aa2f297
Album path queries get constructed automatically
...
Ensures that relative path queries also work for -a mode
2015-02-06 10:38:41 +01:00
Tom Jaspers
f4d971d3a8
PathQueryTest now also tests Album queries
2015-02-06 10:36:23 +01:00
Tom Jaspers
80c96d98de
Oops, flake8 formatting
2015-02-05 10:54:42 +01:00
Tom Jaspers
d8ebc71f98
Auto path detection: use clearer variable name
...
Per sampsyo's suggestion
See #1302
2015-02-05 09:47:30 +01:00
Adrian Sampson
f1ce37e20e
Update Python download link
2015-02-04 09:34:41 -08:00
Tom Jaspers
5d49b24ea1
Automatic path query detection on album queries
...
- Path detection happens regardless of the model class
- PathQuery can now match flexattr (in fast-mode)
Fix #1302
2015-02-04 12:55:55 +01:00
Adrian Sampson
0247785440
discogs: Catch JSON decode errors
...
Fix #1305 *again*.
2015-02-03 23:42:47 -08:00
Adrian Sampson
cc01d87209
discogs: Catch *another* exception ( fix #1305 )
...
Everything but requests is a travesty.
2015-02-03 23:04:14 -08:00
Adrian Sampson
a7878b0eba
A couple of explanatory comments for #1292
2015-02-03 09:50:36 -08:00
Adrian Sampson
82e89b8960
Merge pull request #1292 from mried/import-autosingleton
...
Allow plugins to change the created import tasks
2015-02-03 09:49:13 -08:00
Tom Jaspers
50dbd18493
Duplicates: fix error caused by formatting
...
Function arguement `format` was shadowing the built-in format function
Fix #1300
2015-02-03 13:31:54 +01:00
Malte Ried
11b446e7df
Simplified the flattening for the lists returned by plugins on the import_task_created event.
2015-02-03 12:15:17 +01:00
Tom Jaspers
1341ad9b1d
Importer UI: Display number of missing/unmatched tracks
...
Fix #1088
2015-02-03 10:23:52 +01:00
Adrian Sampson
9dc123a665
Changelog for filesize field
...
See #1291 . Feature in commit 6ed0b2e
2015-02-02 22:48:19 -08:00
Adrian Sampson
77833f6c05
Oops 😳 #1299
2015-02-02 22:34:22 -08:00
Adrian Sampson
8151a40f1f
discogs: Catch socket errors ( #1299 )
...
See also:
https://github.com/discogs/discogs_client/issues/44
2015-02-02 22:27:14 -08:00
Adrian Sampson
bb967dd629
Merge branch 'master' of github.com:sampsyo/beets
2015-02-02 15:29:52 -08:00
Adrian Sampson
1b22f122a8
Binary literals in unique_path ( fix #1298 )
2015-02-02 15:28:44 -08:00
Tom Jaspers
6ed0b2e0f3
Expose an Item's filesize as a field
...
- Update test-case for info to make sure the item's path is pointing to an actual file.
See #1291
2015-02-02 21:52:23 +01:00
Adrian Sampson
313c3807aa
scrub: Use syspath in beet scrub ( #1297 )
2015-02-02 10:42:31 -08:00
Adrian Sampson
465719a208
scrub: Catch IOErrors in command ( fix #1297 )
2015-02-02 10:13:48 -08:00
geigerzaehler
46ba99ce79
Merge pull request #1295 from sampsyo/more-info
...
Info plugin can filter properties in output
2015-02-01 21:19:24 +00:00
Thomas Scholtes
482008bf1d
Info plugin can filter properties in output
...
Resolves #1287
2015-02-01 21:51:26 +01:00
Thomas Scholtes
b150d40394
Changelog for #1294
2015-02-01 21:49:49 +01:00
Adrian Sampson
f0faf5c26b
Merge pull request #1294 from sampsyo/write-tags
...
Extend item.write() to embed images without changing item
2015-02-01 12:35:09 -08:00
Adrian Sampson
b68708f81e
Installation instructions for Fedora ( fix #375 )
2015-02-01 12:22:24 -08:00
Tom Jaspers
a2b00a8408
Changelog entry for #1291
2015-02-01 20:32:28 +01:00
Malte Ried
e681449785
Added documentation
...
FileFilterPlugin uses the new return value feature
Some tweaks to get the code more readable
2015-02-01 17:01:06 +01:00
Malte Ried
754a90dc90
Merge branch 'master' into import-autosingleton
2015-02-01 16:12:59 +01:00
Thomas Scholtes
51ab099145
Extend item.write() to embed images without changing item
...
Fixes #1241 and geigerzaehler/beets-check#14
Before, `embed_item` would add the images to the item and then call
`item.write()` to write the item data, including the image, to the
file. This would trigger `item.store()` in the `after_write` hook of
the check plugin. This would in turn try to persist the temporary
`images` attribute of the item, resulting in an SQL error.
2015-02-01 15:35:24 +01:00
Tom Jaspers
43e9044843
Duplicate album-import summary shows old/new filesize
...
E.g.:
Old: 13 items, MP3, 256kbps, 44:32, 101MB
New: 13 items, MP3, 320kbps, 44:31, 128MB
Fix #1291
2015-01-31 22:11:43 +01:00
Adrian Sampson
336bb9255c
chroma: Fix refactored beet submit
...
Fix #1293 .
2015-01-31 13:04:11 -08:00
Adrian Sampson
14ce6a557e
Merge pull request #1183 from marcaddeo/refactor-ftintitle
...
Refactor ftintitle
Conflicts:
beetsplug/ftintitle.py
2015-01-31 12:51:15 -08:00
Adrian Sampson
8b5d43b32e
Merge branch 'master' of github.com:sampsyo/beets
2015-01-31 11:56:39 -08:00
Adrian Sampson
3f0dbb876d
Tests for #1285 : normalize Unicode filenames
2015-01-31 11:54:32 -08:00
Adrian Sampson
9de9d2497f
Unicode tests for #1285
2015-01-31 11:29:32 -08:00
Adrian Sampson
614fbf20ca
Tests for #1285 : parameterize tests
...
Also remove an errant `print` and use `rb''` literals for regexes.
2015-01-31 11:24:27 -08:00
Bruno Cauet
f284d8fad5
Handle shlex parse errors in query strings
...
Provide context: offending query string.
Update changelog.
Fix #1290 .
2015-01-31 19:54:07 +01:00
