Bruno Cauet
e00d7b7ddc
PathQuery: simple utf8 comparison
...
Test usqge of SQL's substr() with a UTF8 example. The ideal would be to
test with non-UTF8 code points, however it is impossible to perform such
a query: queries can only be unicode or utf8.
2015-02-18 19:28:03 +01:00
Bruno Cauet
6fc678e947
PathQuery: use substr() instead of instr()
...
substr() is only available in SQLite 3.7.15+, which is not available yet
on Debian stable, CentOS & co. Use substr() instead.
2015-02-18 18:52:22 +01:00
Bruno Cauet
83e34322e9
Update changelog & docs
2015-02-17 13:14:29 +01:00
Bruno Cauet
eae98aff0e
PathQuery is case-{,in}sensitive on {UNIX,Windows}
...
PathQuery use LIKE on Windows and instr() = 1 on UNIX.
Fix #1165 .
2015-02-17 13:09:04 +01:00
Adrian Sampson
04333e3915
Merge branch 'master' of github.com:sampsyo/beets
2015-02-16 22:18:25 -05:00
Tom Jaspers
12ecb2ce35
Fix formatting to new PEP8 version (1.6.2)
...
PEP8 1.6.2 (2015-02-15):
- added check for breaking around a binary operator
This caused Travis to fail on "W503 line break before binary operator"
2015-02-16 18:21:56 +01:00
Tom Jaspers
d70a82449e
Fields: show computed and flexible fields
...
- Computed fields from the _getters
- Flexible fields for which a type is defined
(in _types or in a plugins' item_types/album_types)
Fix #1030
2015-02-16 10:34:35 +01:00
Adrian Sampson
494990a7a2
Merge pull request #1322 from tomjaspers/import-metadata-source
...
Set importer metadata source as field
2015-02-15 09:45:12 -08:00
Tom Jaspers
1555d3fe17
Importer metadata source is saved as flex attr
...
Saving a file "as is" keeps the data_source attribute unset
2015-02-15 17:46:00 +01:00
Bruno Cauet
13e47472ac
Play plugin: byte newlines in files written
...
Avoid unicode errors when writing '\n' around file paths.
2015-02-15 15:49:46 +01:00
Adrian Sampson
296c2fc3de
Merge pull request #1325 from brunal/master
...
Delete 'format' variables that shadow the built-in
2015-02-13 17:50:46 -08:00
Adrian Sampson
8f7f7b92b8
play: unicode_literals fix
2015-02-13 17:40:32 -08:00
Adrian Sampson
b80713ce5b
Lambda-free reference to instance method
...
Amends 9cdd541943 , the fix for #1326 .
2015-02-13 17:37:55 -08:00
Tom Jaspers
9cdd541943
Error handling for 'filesize' field
...
- Logs a warning and returns 0 if getsize fails
- Add tests for this
Fix #1326
2015-02-13 12:24:21 +01:00
Bruno Cauet
e1e46df1b3
Fix path truncation test: really use bytes
...
Test is to use bytes but because of __future__.unicode_literals it used
unicode.
2015-02-12 11:56:54 +01:00
Bruno Cauet
d267741ff3
Delete 'format' variables that shadow the built-in
...
Also cleanup the 'the' plugin a bit: delete unused variables.
Relates to #1300 .
2015-02-11 16:26:16 +01:00
Tom Jaspers
c286ea38de
Importer metadata source is set as a field: docs
...
docs + changelog
See #1311
2015-02-11 10:29:13 +01:00
Tom Jaspers
20ae26dd77
Importer metadata source is set as a field: tests
...
See #1311
2015-02-11 10:14:56 +01:00
Tom Jaspers
228e5c0432
Importer metadata source is set as a field
...
TrackInfo and AlbumInfo were already keeping track of this,
so just had to add it as an actual field to Item and Album
See #1311
2015-02-10 18:17:37 +01:00
Bruno Cauet
54abd1a510
Merge branch 'invalidqueryerror'
2015-02-09 21:29:01 +01:00
Bruno Cauet
7476d6be46
InvalidQuery*Error extend ParsingError
...
And InvalidQueryArgumentTypeError does not extend TypeError anymore.
2015-02-09 19:25:23 +01:00
Bruno Cauet
f443e0bfc5
InvalidQueryArgumentTypeError does not extend InvalidQueryError
...
Places where InvalidQueryArgumentTypeError may be raised (i.e. all
current ones) may not know the query therefore it cannot be an
InvalidQueryError. The InvalidQueryArgumentTypeError is caught in
beets.library.Library._fetch() and an InvalidQueryError is then raised.
Improve #1290 .
2015-02-09 15:44:49 +01:00
Bruno Cauet
54887e7655
Widen usage of InvalidQueryError
...
Replace previous InvalidQueryError with InvalidQueryArgumentTypeError
which extends the former as TypeError. However they lack context: the
query that caused the error.
Raise an InvalidQueryError when a shell-like expression cannot be parsed
by shlex.
Improve #1290 .
2015-02-09 15:28:06 +01:00
Tom Jaspers
6572e1bf5a
Fetchart: add empty album check to iTunes art
...
Was causing some tests to fail in test_art.py:CombinedTest
2015-02-09 14:59:56 +01:00
Tom Jaspers
bbc6d0906b
Merge pull request #1312 from tomjaspers/album-path-queries
...
Album path queries get constructed properly
Fix #1307
2015-02-08 16:43:55 +01:00
Tom Jaspers
0a81aae142
PathQueryTest: rename assert_matched for items
2015-02-08 16:34:28 +01:00
Adrian Sampson
66b7e4cd39
Merge branch 'master' of github.com:sampsyo/beets
2015-02-07 12:52:20 -08:00
Adrian Sampson
e7f8a627e9
Style fixes for pep8 1.6
2015-02-07 12:51:54 -08:00
David Logie
9b9c033df6
importfeeds: Fix Unicode error when writing files.
2015-02-07 15:13:01 +00:00
Tom Jaspers
3ec44aab3e
Update _types field instead of assigning it
...
Assigning it would override our pre-defined types
(such as `path` in Album._types)
2015-02-06 10:42:46 +01:00
Tom Jaspers
049aa2f297
Album path queries get constructed automatically
...
Ensures that relative path queries also work for -a mode
2015-02-06 10:38:41 +01:00
Tom Jaspers
f4d971d3a8
PathQueryTest now also tests Album queries
2015-02-06 10:36:23 +01:00
Tom Jaspers
80c96d98de
Oops, flake8 formatting
2015-02-05 10:54:42 +01:00
Tom Jaspers
d8ebc71f98
Auto path detection: use clearer variable name
...
Per sampsyo's suggestion
See #1302
2015-02-05 09:47:30 +01:00
Adrian Sampson
f1ce37e20e
Update Python download link
2015-02-04 09:34:41 -08:00
Tom Jaspers
5d49b24ea1
Automatic path query detection on album queries
...
- Path detection happens regardless of the model class
- PathQuery can now match flexattr (in fast-mode)
Fix #1302
2015-02-04 12:55:55 +01:00
Adrian Sampson
0247785440
discogs: Catch JSON decode errors
...
Fix #1305 *again*.
2015-02-03 23:42:47 -08:00
Adrian Sampson
cc01d87209
discogs: Catch *another* exception ( fix #1305 )
...
Everything but requests is a travesty.
2015-02-03 23:04:14 -08:00
Adrian Sampson
a7878b0eba
A couple of explanatory comments for #1292
2015-02-03 09:50:36 -08:00
Adrian Sampson
82e89b8960
Merge pull request #1292 from mried/import-autosingleton
...
Allow plugins to change the created import tasks
2015-02-03 09:49:13 -08:00
Tom Jaspers
50dbd18493
Duplicates: fix error caused by formatting
...
Function arguement `format` was shadowing the built-in format function
Fix #1300
2015-02-03 13:31:54 +01:00
Malte Ried
11b446e7df
Simplified the flattening for the lists returned by plugins on the import_task_created event.
2015-02-03 12:15:17 +01:00
Tom Jaspers
1341ad9b1d
Importer UI: Display number of missing/unmatched tracks
...
Fix #1088
2015-02-03 10:23:52 +01:00
Adrian Sampson
9dc123a665
Changelog for filesize field
...
See #1291 . Feature in commit 6ed0b2e .
2015-02-02 22:48:19 -08:00
Adrian Sampson
77833f6c05
Oops 😳 #1299
2015-02-02 22:34:22 -08:00
Adrian Sampson
8151a40f1f
discogs: Catch socket errors ( #1299 )
...
See also:
https://github.com/discogs/discogs_client/issues/44
2015-02-02 22:27:14 -08:00
Adrian Sampson
bb967dd629
Merge branch 'master' of github.com:sampsyo/beets
2015-02-02 15:29:52 -08:00
Adrian Sampson
1b22f122a8
Binary literals in unique_path ( fix #1298 )
2015-02-02 15:28:44 -08:00
Tom Jaspers
6ed0b2e0f3
Expose an Item's filesize as a field
...
- Update test-case for info to make sure the item's path is pointing to an actual file.
See #1291
2015-02-02 21:52:23 +01:00
Adrian Sampson
313c3807aa
scrub: Use syspath in beet scrub ( #1297 )
2015-02-02 10:42:31 -08:00