Commit graph

2891 commits

Author SHA1 Message Date
Pedro Silva
dc4624c1b3 specialize exception handling when doing checksums 2014-03-02 20:56:56 +01:00
Pedro Silva
5cc7cac2e7 clarify that keys are not necessarily mbids 2014-03-02 20:43:17 +01:00
Pedro Silva
6d283ecafa fix checksum problem where key was unintentionally hard-coded 2014-03-02 20:39:42 +01:00
Adrian Sampson
bb6372abfd changelog/thanks for #562 2014-03-02 09:38:17 -08:00
Pedro Silva
bf7e04af0f fix #562: fail on empty code and handle analyze exceptions 2014-03-02 14:10:52 +01:00
Adrian Sampson
057ff66ad6 show_model_changes: special display for new fields
c.f. #560
2014-03-01 09:57:53 -08:00
Adrian Sampson
ecace62e14 changelog/thanks for #560 2014-03-01 09:55:04 -08:00
Adrian Sampson
e2908017a4 Merge pull request #560 from brilnius/fix_modify_with_new_field
Fixed ignored new fields when showing/detecting a model change
2014-03-01 09:50:29 -08:00
Bruno Tournay
8b35ec9d95 Fixed ignored new fields when showing/detecting a model change 2014-02-28 23:45:35 +01:00
Adrian Sampson
86bf8b65ba beet config (#552): show non-existent user path
This makes sure to print out the user's configuration path location even if no
user config file exists. (This makes "BEETSCONFIG=xxx beet config -p" behave
as expected, for instance.) It's a little hacky. Does the approach make sense
to you, @geigerzaehler?
2014-02-28 14:31:38 -08:00
Adrian Sampson
f0c0b5c54b config.dump: new approach to excluding defaults
This uses a lot less code (and actually works).
2014-02-28 10:40:35 -08:00
Adrian Sampson
26d9e0b7b7 config.dump: no filename parameter
It's bad style, in my opinion, to provide a file-writing option when the
client code could just as easily write the string to the file. (It implies
we're doing some sort of streaming, which we're obviously not.)
2014-02-28 09:50:08 -08:00
Adrian Sampson
3b2d51e018 backport YAML dumping from Confit (#552)
We actually added more full-blown YAML dumping to the Confit library a while
back but it looks like it never made it into beets. It offers a few benefits
over the hand-rolled flattening that the `config` command was previously
using, including printing ordered dicts in the right order. But it also
appears to have broken logic when attempting to hide defaults. I'll fix this
right quick.
2014-02-28 09:49:29 -08:00
Adrian Sampson
692645466e documentation expansion for config command (#552) 2014-02-28 09:31:10 -08:00
Thomas Scholtes
91bba13acb Changelog for config command 2014-02-28 16:53:19 +01:00
Thomas Scholtes
c345df9155 Merge branch 'config_command'
Conflicts:
	beets/ui/commands.py
	docs/reference/config.rst
	test/_common.py
2014-02-28 16:50:06 +01:00
Thomas Scholtes
8ffee6c027 Remove duplicate code 2014-02-28 15:19:51 +01:00
Thomas Scholtes
d3777745fc Extract slashed packing storage style 2014-02-28 15:19:21 +01:00
Thomas Scholtes
00903ed6c4 Extract tuple storage style 2014-02-28 15:00:10 +01:00
Thomas Scholtes
c51459b6ad Decouple StorageStyles and MediaFile
Storage styles interact only with Mutagen files—they don't need to know about
MediaFile. Also made some variable names more verbose.
2014-02-28 14:30:00 +01:00
Thomas Scholtes
4ca3c8764e Test mediafile with unicode strings 2014-02-28 14:04:41 +01:00
Adrian Sampson
cd7b74271a avoid repr() on paths in filesystem errors 2014-02-27 19:47:03 -08:00
Adrian Sampson
d9435552d3 changelog and style/docs for #527 2014-02-27 19:25:54 -08:00
Adrian Sampson
5ccd9674a6 Merge branch 'mediafile_multiple_values' of https://github.com/geigerzaehler/beets into geigerzaehler-mediafile_multiple_values
Conflicts:
	beets/mediafile.py
2014-02-27 19:12:53 -08:00
Adrian Sampson
982ccce02e version bump: 1.3.4 2014-02-27 10:55:46 -08:00
Adrian Sampson
f9a820d303 summarize changelog for 1.3.3 release 2014-02-26 20:31:06 -08:00
Adrian Sampson
472571a4c6 web: fix typo in albums endpoint 2014-02-26 20:08:22 -08:00
Thomas Scholtes
4228628f84 Force utf8 encoding on new id3_desc tags 2014-02-26 22:48:41 +01:00
Adrian Sampson
5606e60e72 changelog/thanks for #554 2014-02-23 12:14:32 -08:00
Adrian Sampson
6ab2dc4940 Merge branch 'master' of https://github.com/jlefley/beets into jlefley-master 2014-02-23 12:11:00 -08:00
Thomas Scholtes
c73ada92c8 Ensure we go back to default path implementation
If an error is raised within the mock path context and catched upstream the
rest of the tests will run with the mocked path and fail horribly.
2014-02-23 16:38:41 +01:00
Adrian Sampson
1253cb695d move show_model_changes to ui package
This makes it more naturally reusable for plugins.
2014-02-22 15:06:16 -08:00
Adrian Sampson
b383ce3450 comment out some skipped tests
The *only reason* I'm doing this is so that the unittest output looks
prettier. I am pretty sure I have actual OCD. 😳
2014-02-22 14:59:22 -08:00
Adrian Sampson
645279e022 remove old _showdiff
Totally replaced now, including tests! Woohoo.
2014-02-22 14:52:33 -08:00
Adrian Sampson
58dd5f47f5 use _show_model_changes in mbsync 2014-02-22 14:37:04 -08:00
Adrian Sampson
ace34a8654 _show_model_changes: silence by default
This lets the first line of output be suppressed (as it was previously in
update and write) when no changes at all need to be printed.
2014-02-22 14:32:34 -08:00
Adrian Sampson
1413a842f7 update: restore "deleted" indication 2014-02-22 00:51:05 -05:00
Adrian Sampson
52682a0777 changelog for better difference formatting 2014-02-22 00:48:27 -05:00
Adrian Sampson
e42fcd973c use _show_model_change in update 2014-02-22 00:41:28 -05:00
Adrian Sampson
f6c19adc55 use _show_model_changes for write command 2014-02-22 00:24:43 -05:00
Adrian Sampson
8303c71b38 robust difference display for modify
This new alternative to _showdiff takes care of formatting and is better at
highlighting differences for non-string fields. This takes care of the issue
where "True -> False" would have everything but the "e" highlighted.
2014-02-22 00:14:18 -05:00
Adrian Sampson
8ddf04e711 refine config location discussion (#513) 2014-02-21 21:22:55 -05:00
Adrian Sampson
b2aee7b805 create BEETSDIR directory (#513)
The directory returned by config_dir() must exist. That was not being enforced
in the BEETSDIR case.
2014-02-21 21:08:49 -05:00
Adrian Sampson
0ead6ee8cc don't relativize command-line paths (#513)
Paths given on the command line (e.g., with the --library option) need to be
relative to the working directory, not the config file.
2014-02-21 21:04:03 -05:00
Adrian Sampson
622ca2b244 Unixy location is fallback on OS X
This is mainly for backwards compatibility. It's also an effort to reduce the
support burden; this way, I can say "your config directory is ~/.config/beets"
without needing to ascertain whether someone is on a Mac.
2014-02-21 20:57:06 -05:00
Adrian Sampson
129575178c docstring/style fixups for #513 2014-02-21 20:52:21 -05:00
Adrian Sampson
a630c61340 Merge branch 'geigerzaehler-remove_cascading_config' 2014-02-21 20:31:05 -05:00
Adrian Sampson
a06500fb42 style tweaks in date queries (#551; fixes #542)
The microseconds were being ignored anyway due to the int conversion, so we
might as well not use them here.
2014-02-21 20:17:57 -05:00
Thomas Scholtes
979dcfea98 Front cover type for flac images 2014-02-22 01:32:23 +01:00
Jason Lefley
c0f97bdc06 Set album art type attribute to front cover for FLAC 2014-02-21 16:09:41 -08:00