Commit graph

7314 commits

Author SHA1 Message Date
Adrian Sampson
da86a410fe A little more detail in the changelog 2017-01-10 21:04:51 -05:00
Adrian Sampson
703f47ae97 Use flexible attribute for track_alt
No need for a built-in field for a simple string-type optional field like
this.
2017-01-10 21:01:36 -05:00
Mike Cameron
5250ba8020 Added changelog entry of new rack_alt path template value and updated changelog with description of change. 2017-01-10 19:40:23 -05:00
Mike Cameron
0dd763c5ef Fixed flake8 warning W292 for Python 3.4 about missing newline at end of file. 2017-01-10 19:19:09 -05:00
Mike Cameron
bba5a7c712 Fixed (?) failing test where
umber was 	rack_alt was missing during import.
2017-01-10 19:08:18 -05:00
Mike Cameron
3cd4f1c091 Fixed failing test where track number was missing from mocked data. 2017-01-10 18:57:42 -05:00
Mike Cameron
c58c49d77f Fixed trailing whitespace issue. Changed alternate track property name. 2017-01-10 18:39:01 -05:00
Mike Cameron
3f67a27989 Fixed failing test because mocked data was missing property
umber.
2017-01-10 18:21:28 -05:00
Mike Cameron
24b02e8215 Merge remote-tracking branch 'upstream/master' 2017-01-10 17:33:45 -05:00
Adrian Sampson
998e6ac1c7 Remove unused import 2017-01-10 14:54:17 -05:00
Adrian Sampson
bc93a11141 Fix #2382: replaygain backend parsing on Python 3 2017-01-10 14:45:57 -05:00
Adrian Sampson
153b01e5a6 replaygain: Don't muck with logging level
This is now handled by the central logging infrastructure; no need to change
it here. I think this must be a leftover from the era when plugins had to
explicitly muck with their verbosity level, but even still it doesn't make
sense to do set the level to INFO unconditionally...
2017-01-10 14:24:18 -05:00
Adrian Sampson
f7ebf5524f flake8 fix for #2379 2017-01-10 13:25:24 -05:00
Adrian Sampson
f137f87878 More test docs about the image.* mixin 2017-01-10 12:41:34 -05:00
Adrian Sampson
5863859a5d Remove image tests for DSF (#2379)
There isn't currently an `image.dsf`, so those tests fail.
2017-01-10 12:38:44 -05:00
Adrian Sampson
5e20cfd26e flake8 fixes for 2379 2017-01-10 12:33:23 -05:00
Adrian Sampson
da89be81fc Changelog for #2379 2017-01-10 12:30:48 -05:00
Adrian Sampson
96350ab7db Merge pull request #2379 from docbobo/feature/dsf-support
Support for DSF files
2017-01-10 12:28:29 -05:00
Adrian Sampson
2706339a83 Fix #2381: mpdupdate on Python 3
Communicate bytes over the socket, obvi.
2017-01-10 12:22:30 -05:00
Boris Pruessmann
e0a4dc67a8 Test improvements for DSF.
- Fixed unparseable.dsf
- Added DSF feature detection to test_mediafile.py
2017-01-10 11:21:40 +01:00
Adrian Sampson
a2d37dd588 Document how to add tests for a new format (#2379) 2017-01-09 13:02:28 -05:00
Boris Pruessmann
1e10e62d82 Added DSF to test_mediafile 2017-01-09 18:54:30 +01:00
Boris Pruessmann
f7742939ef Support for DSF files 2017-01-09 18:54:30 +01:00
Adrian Sampson
b9500c379e Remove some unnecessary imports in mediafile.py 2017-01-09 12:44:53 -05:00
Adrian Sampson
0bd6062ee9 Version bump: 1.4.4 2017-01-09 10:40:06 -05:00
Adrian Sampson
497c3076d2 Add 1.4.3 release date 2017-01-09 10:38:06 -05:00
Adrian Sampson
2cef4703f8 Prepare 1.4.3 changelog for release 2017-01-09 10:37:37 -05:00
Adrian Sampson
e5e710033c Remove old test for misspelled config option
See 6b9d766, which removed the option.
2017-01-07 17:19:02 -05:00
Adrian Sampson
0b5b20d799 Robust import of distutils submodule (fix #2376)
This would fail if the `spawn` module in the `distutils` package was not
already imported somewhere else.
2017-01-07 17:15:13 -05:00
Adrian Sampson
6b9d766082 Remove compatibility with misspelled config option
This has been hanging around long enough; it's about time to drop the old
name.
2017-01-07 17:09:51 -05:00
Adrian Sampson
c9ec5e411c A little fiddling with embyupdate
Clean up some wording w/r/t efbd58cd55.
2017-01-07 17:07:01 -05:00
Adrian Sampson
d992221853 Changelog for #2360 (fix #2008) 2017-01-07 17:03:30 -05:00
Adrian Sampson
ffa22d6ce1 Merge pull request #2360 from diomekes/importer-play
play: Add prompt choice to importer
2017-01-07 17:02:22 -05:00
Adrian Sampson
1801663de8 Merge pull request #2375 from diomekes/sort-album-typo
Change "items" to "albums" in config docs for sort_album
2017-01-07 16:45:48 -05:00
diomekes
5ee89666b6 fix typo in config docs 2017-01-07 09:54:54 -05:00
diomekes
8d613425fd small docstring rewrite 2017-01-06 23:46:16 -05:00
Marvin Steadfast
efbd58cd55 embyupdate: fix bug that config for password and api is needed
even if it only used api key it needed the password key. this is fixed
now.
2017-01-06 11:52:53 +01:00
diomekes
8d97257647 use shlex_split, clean up code and docs 2017-01-03 22:10:35 -05:00
Adrian Sampson
d389ac15e1 Use HTTPS for MS translator API (from #2247) 2017-01-02 21:00:01 -05:00
Adrian Sampson
9e76c839f6 Changelog for #2307
Close #2247, close #2243, close #2245, close #2244, close #2248.
2017-01-02 20:58:18 -05:00
Adrian Sampson
fbc0f322f6 Merge branch 'tigranl-https_fix' 2017-01-02 20:54:17 -05:00
Adrian Sampson
33a8e81f08 Simplify test changes
We don't need quite so many checks now that SSL isn't conditional most of the
time.
2017-01-02 20:49:12 -05:00
Adrian Sampson
f941fd42de Always use SSL on servers that don't require SNI
I did a little audit using the `openssl` command-line tool to find the servers
that don't require SNI. Here's what I found:

icbrainz.org: SNI
images.weserv.nl: inconclusive, but docs say yes SNI
coverartarchive.org: SNI
webservice.fanart.tv: *no* SNI
dbpedia.org: *no* SNI
en.wikipedia.org: *no* SNI
ws.audioscrobbler.com: *no* SNI
api.microsofttranslator.com: *no* SNI

In summary, *only* MusicBrainz and CoverArtArchive were found to require SNI.
So I'm using SSL unconditionally on all the other sites.
2017-01-02 20:39:10 -05:00
Johnny Robeson
bd340b2910 Replace Python 3.4 with 3.6 on Appveyor (#2358)
Python 3.4 is quite old and offers little value on Windows.

Closes #2344
2017-01-02 19:06:49 -05:00
Adrian Sampson
2fcde98d4b Merge pull request #2367 from beetbox/timestamp-36
Use a new stdlib method for dbcore.query._to_epoch_time on Python 3
2017-01-02 18:45:36 -05:00
Adrian Sampson
3acd4480ff Use a stdlib method for _to_epoch_time on py3
This also works around a bug in Python 3.6.0 on Windows: see #2358.
2017-01-02 18:29:37 -05:00
Adrian Sampson
4711bf708b Docs tweaks for #2365 2017-01-02 15:59:14 -05:00
Adrian Sampson
7f73711d2f Merge pull request #2365 from inytar/absubmit_skip_doc
Absubmit add section in the documentation on skipped file by the plugin
2017-01-02 15:57:18 -05:00
Pieter Mulder
869d0781d5 Absubmit add section on skipped file by the plugin
Add a section to the absubmit plugin documentation about files that are skipped by this plugin.
2017-01-02 14:34:00 -05:00
Adrian Sampson
b95c01fbea Improve absumbit docs (c.f. #2364) 2017-01-02 13:41:48 -05:00