Commit graph

5117 commits

Author SHA1 Message Date
Adrian Sampson
d8cc2588cd Changelog for #1470 2015-05-23 18:20:48 -07:00
Adrian Sampson
d4b07446ce Merge pull request #1470 from oldtopman/master
Fix beet web search with non-ascii characters
2015-05-23 18:19:36 -07:00
Old T. Man
acd0a902bb Fix search term encoding. 2015-05-23 13:19:28 -06:00
Adrian Sampson
9597a900e7 Changelog whitespace & expansion 2015-05-20 21:42:08 -07:00
Adrian Sampson
061f0f71bf Merge pull request #1466 from tomjaspers/move-pretend-option
Implement `--pretend` option for the move command
2015-05-20 21:41:15 -07:00
Adrian Sampson
66c9090285 Merge pull request #1468 from swt30/beet-update-doc
File modification note in docs
2015-05-20 20:35:02 -07:00
Scott Thomas
07e352143e File modification note in docs
I couldn't get beet update to read metadata changes - turns out that puddletag
doesn't touch the file modification time by default. It's a perfectly sensible
behaviour but I thought I'd add a note in the `beet update` section in case
anyone else has this problem.
2015-05-21 00:45:20 +01:00
Tom Jaspers
be484f2af0 Implement --pretend option for the move command
The method `show_path_changes` takes a list of tuples (source, destination)
that will be printed on either single / double line, as proposed in #1405.
2015-05-20 13:03:18 +02:00
Adrian Sampson
adebb850b5 Tests: fix a leaky error message
Caused by inadvertently executing too much at module-import time. By
materializing ArtResizer in a global definition, we triggered a debug log
before the test harness had a chance to capture the logging.
2015-05-19 16:50:05 -07:00
Adrian Sampson
07242f65e2 Convert always uses bytestring args (#1461) 2015-05-19 16:38:08 -07:00
Adrian Sampson
36c2241a34 Use bytestring filenames in embedart tests
First step on #1461.
2015-05-19 16:09:39 -07:00
Tom Jaspers
a7eace81d4 fetchart: improve Wikipedia art source
Artists with non-typical casing (e.g., alt-J, dEUS) would not get matched on
DBPedia, as the RDFS:label uses arbitrary casing, and SPARQL provides only exact
matches. The FOAF:name attribute is always title-cased (e.g., Alt-J, Deus).

Due to a bug in DBPedia, the cover filename is truncated when it contains
parentheses, (e.g., 'Foo bar (band).jpg' gets truncated to 'Foo bar .jpg').
To work around this, an additional Wikipedia call gets made for all its
images, in which we try to match our truncated image.

The Wikipedia art source now catches the correct exceptions, instead of
a broad catch-all.

Wikipedia album images can be gifs, so these are now added to the list of
accepted content types.
2015-05-19 09:57:54 +02:00
Tom Jaspers
a82dee35cb fetchart complains if no imaging backend available
The `enforce_ratio` and `minwidth` options depend on PIL or ImageMagick.
Previously it silently fails. Now it will log a warning, and accept the
image.

Tests concerning these options are skipped when no imaging backend is available.

Fix #1460
2015-05-18 19:44:40 +02:00
Pedro Silva
0377510522 handle albums during default attribute set completeness sorting 2015-05-17 23:56:10 +02:00
Pedro Silva
bc6f5869b4 patially revert #132dc4c:
Removing overloaded __dir__ on LibModel. This was making me
unconfortable, as I don't know that it will not break something else.
2015-05-17 23:47:59 +02:00
Pedro Silva
684f4deadc fix typo during tagging: option -t now actually works 2015-05-17 15:01:48 +02:00
Pedro Silva
6be98b0a36 add tiebreaking facility 2015-05-16 19:25:47 +02:00
Pedro Silva
132dc4c617 refactor fields_func logic into Item/Album __dir__ 2015-05-16 15:49:42 +02:00
Pedro Silva
834418de6d fix #1457: enforce correct config typing 2015-05-15 11:48:27 +02:00
Adrian Sampson
d6348a4da2 tests: Use bytes for mock responses
Also, require a newer version of responses that is less sensitive to this.
2015-05-13 18:09:35 -07:00
Adrian Sampson
71d7c0b004 Merge pull request #1450 from tomjaspers/metasync-itunes
MetaSync: more OO structure +  iTunes support
2015-05-13 15:04:36 -07:00
Tom Jaspers
94edc7a2a4 MetaSync: minor improvements for iTunes source
- Use path as an key to find items (over artist/title/album tuples)
- Sensible default library location
2015-05-13 20:02:34 +02:00
Tom Jaspers
02bec1bdd7 MetaSync: Remove auto-discovery of sources
In favor of simpler, hard-coded, list of sources, to avoid unneccesary magic.

Also: check to see if query has results before instantiating the meta sources
2015-05-13 11:01:52 +02:00
Adrian Sampson
dff4feaec2 embedart: Preempt wrong-type error in AAC files 2015-05-11 17:46:21 -07:00
David
36bf49aa8d typo: thumnails -> thumbnails 2015-05-11 14:26:49 -04:00
Tom Jaspers
16531b6cf8 MetaSync: fix tests for Windows 2015-05-11 17:42:52 +02:00
Tom Jaspers
7fb1914baf Merge pull request #1456 from GuilhermeHideki/patch-1
Some typos fixes
2015-05-10 22:31:35 +02:00
Guilherme Danno
403f7e1ba5 Typo: afinity → affinity 2015-05-10 16:02:23 -03:00
Guilherme Danno
e789b3b94c Typo: conveniencies → conveniences 2015-05-10 15:59:35 -03:00
Guilherme Danno
9b85f88928 Typo: Strucuture / descritpion / arguemnt
Strucuture → Structure
descritpion → description
arguemnt → argument
2015-05-10 15:54:41 -03:00
Guilherme Danno
dc809e3be6 Typo: exectuted → executed 2015-05-10 15:48:08 -03:00
Guilherme Danno
d57317f2fc Typo: formated → formatted 2015-05-10 15:45:12 -03:00
Guilherme Danno
5456704c26 Typo: beetween / wirte / Paramaterize
beetween → between
wirte → write
Paramaterize → Parametrize
2015-05-10 15:41:36 -03:00
Guilherme Danno
06ecea8e7a Typo: qualitiy → quality 2015-05-10 15:35:42 -03:00
Tom Jaspers
afeedd2e70 MetaSync: basic tests
No tests for Amarok, unfortunately
2015-05-10 14:46:59 +02:00
Tom Jaspers
abd02052b9 MetaSync: small refactoring + enhancements
- `sync_data` -> `sync_from_source`
- properly catch ConfigValueError
- avoiding iterating through library if we couldn't instantiate any meta sources
- fix create_temporary_copy to actually make a tempdir
2015-05-10 14:44:37 +02:00
Tom Jaspers
bba8647bac MetaSync: rename 'cls' variable to '_cls' 2015-05-09 12:22:51 +02:00
Tom Jaspers
cb13d21ad6 MetaSync: automatic load of sources and item_types
- MetaSources get loaded from the modules automatically
- The MetaSources can define their own item_types, that get loaded for the plugin
- __init__ doesn't need any changes to accept new metasources
- Fix the --sources option to actually accept sources
  (it was being interpreted as boolean flag before, crashing the plugin)
- More safety w.r.t. external dependencies
2015-05-09 11:31:39 +02:00
Tom Jaspers
de5db7068b MetaSync: sources need to subclass MetaSource
- allows for the logging to integrate better
- renamed `get_data` to `sync_data`, to better reflect that its not returning anything,
  but that the item's data is being set by the function
2015-05-08 16:48:38 +02:00
Tom Jaspers
27aef76ae5 MetaSync: update changelog & fix typo in doc 2015-05-08 16:43:02 +02:00
Lucas Duailibe
f497bf849b Merge pull request #1451 from duailibe/path-sort
Fix sort by path when case insenstive (fix #1451)
2015-05-07 23:47:06 -03:00
Lucas Duailibe
df89a68a99 Fixing sort by path (fix #1451) 2015-05-07 23:45:26 -03:00
Tom Jaspers
04d7c883d1 MetaSync: docs for itunes synchronization
changelog & metasync plugin documentation
2015-05-07 10:28:41 +02:00
Adrian Sampson
c856326865 Fix #1449: Unicode paths in permissions 2015-05-06 22:23:18 -07:00
Tom Jaspers
3dc2beda41 MetaSync: add iTunes synchronization
Uses plistlib to read a temp copy of `iTunes Library.xml`
2015-05-06 22:01:00 +02:00
Tom Jaspers
c108447bb4 Changelog for #1448 (PIL import fix) 2015-05-04 08:30:38 +02:00
Tom Jaspers
f4ae1d5ae7 __import__ requires string when importing PIL
Fix #1448
2015-05-03 17:21:15 +02:00
Adrian Sampson
076e77711f Changelog for #1443 2015-04-29 14:53:57 -07:00
Adrian Sampson
494d32833f Merge pull request #1443 from CodyReichert/master
MPDStats Plugin: handle update_rating when item is None / start tests for mpdstats
2015-04-29 14:53:01 -07:00
Cody Reichert
b776a71a8c handle mpdstats update_rating when item is None / add appropriate tests 2015-04-28 23:23:27 -05:00