Commit graph

10776 commits

Author SHA1 Message Date
wisp3rwind
d24cf69269 remove old Python: remove util.text_string
This was a helper for situations when Python 2 and 3 APIs returned bytes
and unicode, respectively. In these situation, we should nowadays know
which of the two we receive, so there's no need to wrap & hide the
`bytes.decode()` anymore (when it is still required).

Detailed justification:

beets/ui/__init__.py:
- command line options are always parsed to str

beets/ui/commands.py:
- confuse's config.dump always returns str
- open(...) defaults to text mode, read()ing str

beetsplug/keyfinder.py:
- ...

beetsplug/web/__init__.py:
- internally, paths are always bytestrings
- additionally, I took the liberty to slighlty re-arrange the code: it
  makes sense to split off the basename first, since we're only
  interested in the unicode conversion of that part.

test/helper.py:
- capture_stdout() gives a StringIO, which yields str

test/test_ui.py:
- self.io, from _common.TestCase, ultimately contains a
  _common.DummyOut, which appears to be dealing with str (cf.
  DummyOut.get)
2022-12-24 13:09:26 +01:00
wisp3rwind
3510e6311d web: slight refactor to make path handling more readable
(at least, more readable to me)
2022-12-24 13:09:26 +01:00
wisp3rwind
35e167f75e remove old Python: in logging, update comments and support new kwargs
We still need these custom Logger modifications, but the precise
reasoning as given in the comments didn't quite apply anymore.
Also, `stack_info` and `stacklevel` arguments have been added in recent
Python, which we now support.
2022-12-24 13:09:26 +01:00
wisp3rwind
7c2aa02de2 remove old Python: in logging, rm workarounds for broken string conversions 2022-12-24 13:09:26 +01:00
wisp3rwind
9f58673433 drop old Python: update a bunch of comments, removing Python 2 details
These didn't match the code anymore (which had already been changes
manually or automatically as part of the 2->3 transition).
2022-12-24 13:09:26 +01:00
wisp3rwind
c816b2953d drop old Python: remove obsolete exception handling for Windows symlinks
when symlinks aren't supported, recent python will only raise
NotImplementedError (or might even support symlinks), ending up in the
other except arm
2022-12-24 13:09:26 +01:00
wisp3rwind
22826c6d36 drop old Python: remove obsolete custom string formatter in hooks plugin 2022-12-24 13:09:26 +01:00
wisp3rwind
67f0c73eec drop old Python: don't handle obsolte exception in keyfinder plugin 2022-12-24 13:09:26 +01:00
wisp3rwind
5cdb0c5c5c drop old Python: rm python 2 leftovers in library.FileOperationError.__str__ 2022-12-24 13:07:48 +01:00
wisp3rwind
632698680f drop old Python: simplify datetime usage 2022-12-18 09:20:04 +01:00
wisp3rwind
bd09cc90b6 drop Python 3.6: docs, a few safe simplifications 2022-12-18 09:20:04 +01:00
wisp3rwind
f419543f07 docs: remove unused link target, update links to python docs 2022-12-18 09:20:04 +01:00
Benedikt
195ef6c78a
Merge pull request #4593 from wisp3rwind/pr_fix_mediafile_tests
tests: fix assertions for empty MediaFile.images
2022-12-18 08:51:11 +01:00
wisp3rwind
d5f998b312 tests: fix assertions for empty MediaFile.images
used to work due to inconsistent mediafile implementation, but with
https://github.com/beetbox/mediafile/pull/64 (in mediafile >= 0.11.0)
list fields are None if non-existent, not the empty list
2022-12-18 08:41:42 +01:00
Adrian Sampson
d7273bddb3
Merge pull request #4563 from JOJ0/playlist_docs
Improve playlist plugin docs
2022-11-29 16:41:18 -08:00
J0J0 Todos
6b06344662 Further improve playlist plugin docs
Incorporate wording suggestions and add links to query sections.
2022-11-29 08:27:35 +01:00
Adrian Sampson
3077a3a32d
Merge pull request #4564 from beetbox/flake8-config
Fix some CI breakage due to backwards-incompatible flake8 changes
2022-11-28 08:46:28 -08:00
Adrian Sampson
e88745833b
Remove the last from _ import * errors
This was a special case for our `logging` shim that is not truly
necessary.
2022-11-28 08:01:23 -08:00
Adrian Sampson
abc3dfbf42
Reformat flake8 config comments
A recent release of flake8 broke the syntax we were using for comments:
https://github.com/pycqa/flake8/issues/1689#issuecomment-1326319235

It requires comments to be on their own lines.
2022-11-28 07:58:01 -08:00
J0J0 Todos
a23e31d1b6 Improve playlist plugin docs 2022-11-28 16:18:30 +01:00
Adrian Sampson
7cfb55b746
Merge pull request #4546 from luharder/master
Force Tekstowo to check result for match, added Tekstowo test suite
2022-11-26 19:17:19 -08:00
Luke Harder
f155d3ba75 bug 4406 fix v5 (tests pass again) 2022-11-22 20:40:13 -05:00
Luke Harder
4a1f25e1b1 bug 4406 fix v4 (added configurable threshold) 2022-11-22 13:25:09 -05:00
Adrian Sampson
dcba529827
Merge pull request #4549 from Bootjewolf/remixerField
Added remixer field
2022-11-19 12:53:16 -08:00
Bootjewolf
2a282116bd Reorder parameters of _make_track function and fix linting errors 2022-11-19 12:39:16 +01:00
Bootjewolf
1be6c22b44 Generalise the function to get the names of related artists 2022-11-19 12:37:51 +01:00
Adrian Sampson
c83c900f95
Merge pull request #4556 from sweist/fix-from_scratch-documentation
The from_scratch flag is called --from-scratch on the command line
2022-11-18 15:27:20 -08:00
Stefan Schweizer
4f51b4af2b The from_scratch option is called --from-scratch on the command line.
Fixed the documentation.
2022-11-18 16:29:26 +01:00
Bootjewolf
ff22d3dc89 Added changelog entry 2022-11-15 17:52:10 +01:00
Bootjewolf
4918ee6457 Added test for the parsing of the remixer field 2022-11-15 17:42:34 +01:00
Bootjewolf
5f74bf4394 Added the remixer field from musicbrainz 2022-11-15 17:41:49 +01:00
Luke Harder
43f1a8412a bug 4406 fix v3 2022-11-10 14:53:50 -05:00
Luke Harder
22a5a7f9f4 bug 4406 fix v2 2022-11-10 14:46:36 -05:00
Luke Harder
252121f537 bug 4406 fix 2022-11-10 12:54:45 -05:00
Adrian Sampson
e201dd4fe5
Merge pull request #4534 from RollingStar/patch-3
Sort and comment "replace"
2022-10-31 09:50:58 -07:00
RollingStar
409f2f85cb
Update config_default.yaml 2022-10-30 20:43:05 -04:00
RollingStar
9757bc0002
Sort and comment "replace" 2022-10-29 03:01:34 -04:00
Adrian Sampson
bcfc86df04
Merge pull request #4525 from phillprice/master
Corrects popularity service from spotify to deezer to match plugin
2022-10-20 17:38:01 -07:00
Phill Price
867656eef7
Update index.rst
Corrects popularity service from spotify to deezer to match plugin
2022-10-20 23:05:33 +01:00
Adrian Sampson
e9576e6c57
Merge pull request #4521 from aereaux/patch-1
Fix recent bug that would not transcode when format was wrong
2022-10-19 09:46:02 -07:00
Aidan Epstein
c906e55ba9 Fix recent bug that would not transcode when format was wrong
Bug introduced in c6d623241b, should_transcode would return False even when the format was different.

Also fix up tests and documentation.
2022-10-19 08:55:51 -07:00
Adrian Sampson
407b1fd013
Merge pull request #4510 from KucharczykL/KucharczykL-remove-duplicate-triphop
Remove duplicate "Trip-hop" genre
2022-10-03 11:13:06 -07:00
Adrian Sampson
e7290c3469
Merge pull request #4504 from Tomasito665/fix_max_bitrate_default
Fix #4472 - set 'max_bitrate' default param to none
2022-10-03 11:11:08 -07:00
Adrian Sampson
ad1f57f8bb
Changelog for #4510 2022-10-03 11:03:55 -07:00
Adrian Sampson
1ebcbf6944
Merge branch 'master' into fix_max_bitrate_default 2022-10-03 11:02:07 -07:00
Lukáš Kucharczyk
a41a9b7aa1
Remove duplicate "Trip-hop" genre 2022-10-03 19:58:23 +02:00
Adrian Sampson
7db020961d
Merge pull request #4496 from beetbox/ignored_alias_types
Add a `import.ignored_alias_types` option to ignore alias types.
2022-10-03 10:52:37 -07:00
Adrian Sampson
a86476c78b
Merge pull request #4502 from beetbox/aura-cors-docs
AURA: document cors for local browser clients
2022-10-03 10:49:47 -07:00
Adrian Sampson
04ad5a0f5a
Merge branch 'master' into ignored_alias_types 2022-10-03 10:44:21 -07:00
Adrian Sampson
4a9e7c1d33
Merge pull request #4507 from beetbox/arg-encoding-experiment
Use Python's standard filesystem encoding for command-line arguments
2022-10-03 10:44:01 -07:00