Commit graph

7574 commits

Author SHA1 Message Date
discopatrick
d24b373c87 Adjust indentation to pass flake8 tests 2017-04-22 18:23:33 +01:00
discopatrick
63cd799e8d Raise the correct error type
The incorrect error type was reintroduced in the previous merge commit.
2017-04-22 18:13:26 +01:00
discopatrick
bd48559b0a Merge branch 'master' into rename-error
# Conflicts:
#	beets/dbcore/query.py
2017-04-22 18:13:03 +01:00
discopatrick
58417526cb Rename InvalidQueryArgumentTypeError to InvalidQueryArgumentValueError
The way we use `InvalidQueryArgumentTypeError` is more akin to a `ValueError` than a `TypeError`. For example, we try to parse a string as an int, float, or date, but the parsing fails - there was nothing wrong with the type of the variable (string), but its contents were not parseable into the type we wanted - there was a problem with the value of the string.
2017-04-22 18:07:30 +01:00
Adrian Sampson
80f77aea4d Merge pull request #2522 from discopatrick/date-value-field-validation-method
Date value field validation method
2017-04-21 08:48:52 -04:00
discopatrick
4dbc4134b3 consolidates the declaration and incrementing of ordinal into one line 2017-04-21 12:55:44 +01:00
discopatrick
85adbd1383 gives variable the better name of ‘ordinal’ 2017-04-20 13:36:31 +01:00
discopatrick
713c00aea7 reverts order of precisions from broadest to narrowest 2017-04-20 13:20:22 +01:00
discopatrick
ab7cc8f1ab Merge branch 'master' into date-value-field-validation-method
# Conflicts:
#	beets/dbcore/query.py
2017-04-20 13:03:25 +01:00
Adrian Sampson
fae8fcc932 ftintitle: Clarify indexing
This can only be a two-element array, so just use the index 1. This matches
better with the comments, that say "right-hand side" instead of "the last
value in the list."
2017-04-19 19:08:15 -04:00
Adrian Sampson
9d42728f7f ftintitle: Clarify control flow
Assigning to this variable made it hard to tell what the function was actually
returning.
2017-04-19 19:07:29 -04:00
Adrian Sampson
78f19db511 Merge pull request #2521 from tweitzel/master
add --yes argument to play command
2017-04-19 18:59:50 -04:00
xarph
02aa6191c1 rename --force to --yes in play plugin
fix some pep8 goo
2017-04-19 10:51:44 -07:00
Adrian Sampson
18127ce6bf Merge branch 'master' of github.com:beetbox/beets 2017-04-19 11:37:36 -04:00
Adrian Sampson
29b57fb5a7 Changelog for #2517 2017-04-19 11:36:58 -04:00
Adrian Sampson
31c7330de4 Merge pull request #2517 from discopatrick/date-value-field-validation
Date value field validation
2017-04-19 11:36:18 -04:00
Adrian Sampson
21c59bfcdd Merge pull request #2508 from Mary011196/master
OperationalError from SQlite that indicates a permissions problem.
2017-04-19 11:25:37 -04:00
discopatrick
18c512893e more flake8 updates 2017-04-19 14:10:04 +01:00
xarph
ffcaf33845 add -f argument to play command 2017-04-18 15:30:24 -07:00
Adrian Sampson
7eaaa99566 Changelog entry for #2508 2017-04-18 17:59:12 -04:00
Adrian Sampson
906bd97d46 Hint about database access errors 2017-04-18 17:57:13 -04:00
Adrian Sampson
19e09585d8 Re-raise other errors
And re-use the SQLite error string instead of a hand-written one for now.
2017-04-18 10:32:44 -04:00
Adrian Sampson
621427fa63 Reformat a docstring 2017-04-18 10:31:09 -04:00
Mary011196
e756f98845 Correcting the mistakes that Travis CI showed me 2017-04-16 17:24:48 +03:00
Adrian Sampson
512031a099 Revise changelog for #2509 2017-04-16 08:57:52 -04:00
Adrian Sampson
8a99eea146 Merge pull request #2509 from mattmurch/Issue549
Add default replace for - to _
2017-04-16 08:56:22 -04:00
Mary011196
0492741bf7 Error check with if statemetnt 2017-04-16 15:18:40 +03:00
Mary011196
f7a58447f0 Change the error name to DBAccessError 2017-04-16 15:15:45 +03:00
Adrian Sampson
346ecbc6d4 Slightly more verbose config overlay description 2017-04-15 15:43:26 -04:00
Adrian Sampson
8e58a61eb4 Remove one blank line 2017-04-15 15:34:09 -04:00
Adrian Sampson
560d003375 Merge pull request #2514 from MolarAmbiguity/master
Add info about overlaying configs, Resolves #2084
2017-04-15 15:34:00 -04:00
Adrian Sampson
a2eb6fae0b Merge pull request #2518 from jwilk/re.sub
Fix misuse of flags in re.sub() calls
2017-04-15 12:00:09 -04:00
Adrian Sampson
419d9a0667 Remove an accidentally-committed config 2017-04-15 11:52:09 -04:00
Adrian Sampson
0cbb40869a Merge pull request #2403 from antlarr/master
Run python2 or python3 depending on what's being used
2017-04-15 11:28:45 -04:00
Adrian Sampson
fb7296711c Fix Windows encoding in convert stub (#2516) 2017-04-15 11:27:19 -04:00
Adrian Sampson
e709ae6dd5 Changelog for #2516 2017-04-15 11:13:47 -04:00
Jakub Wilk
d3664ad5db Fix misuse of flags in re.sub() calls
The 4th argument of re.sub() is maximum number of substitutions,
not flags.
2017-04-15 14:44:19 +02:00
MolarAmbiguity
a526eb7222 Implement feedback from sampsyo 2017-04-15 09:23:35 +10:00
Mary Koliopoulou
cf744eb1f7 Update db.py 2017-04-14 19:42:23 +03:00
discopatrick
6515f9c55a changes date validation method to try each format until a match is found 2017-04-14 15:25:03 +01:00
discopatrick
d466f8802c passes flake8 2017-04-14 14:45:51 +01:00
Adrian Sampson
c7801d4cc0 Attempted fix for #2515 (convert on Windows)
On Python 3, this tries to pass through the Unicode filename representation
for paths to the Windows API.
2017-04-14 09:31:30 -04:00
discopatrick
ff4c0abcf1 tests ‘added’ instead of ‘mtime’ , and uses a correct date format 2017-04-14 13:05:13 +01:00
Mary Koliopoulou
cb2f47d8d9 Update db.py 2017-04-14 09:41:24 +03:00
Mary011196
bccfcb6b4f handlinig AccessFileError in main 2017-04-14 09:33:23 +03:00
Mary011196
3fd04ad642 adding AccessFileError as new class error excpetion 2017-04-14 09:28:13 +03:00
MolarAmbiguity
94b75e8fb4 Fix bulleted list 2017-04-14 12:57:42 +10:00
MolarAmbiguity
ad87d2af92 Add info about overlaying configs 2017-04-14 12:40:32 +10:00
discopatrick
ed0ea1dee5 tests more invalid date queries 2017-04-14 01:49:58 +01:00
discopatrick
1ac3872293 updates documentation 2017-04-14 01:40:06 +01:00