Commit graph

4702 commits

Author SHA1 Message Date
Adrian Sampson
cc01d87209 discogs: Catch *another* exception (fix #1305)
Everything but requests is a travesty.
2015-02-03 23:04:14 -08:00
Adrian Sampson
a7878b0eba A couple of explanatory comments for #1292 2015-02-03 09:50:36 -08:00
Adrian Sampson
82e89b8960 Merge pull request #1292 from mried/import-autosingleton
Allow plugins to change the created import tasks
2015-02-03 09:49:13 -08:00
Tom Jaspers
50dbd18493 Duplicates: fix error caused by formatting
Function arguement `format` was shadowing the built-in format function

Fix #1300
2015-02-03 13:31:54 +01:00
Malte Ried
11b446e7df Simplified the flattening for the lists returned by plugins on the import_task_created event. 2015-02-03 12:15:17 +01:00
Tom Jaspers
1341ad9b1d Importer UI: Display number of missing/unmatched tracks
Fix #1088
2015-02-03 10:23:52 +01:00
Adrian Sampson
9dc123a665 Changelog for filesize field
See #1291. Feature in commit 6ed0b2e.
2015-02-02 22:48:19 -08:00
Adrian Sampson
77833f6c05 Oops 😳 #1299 2015-02-02 22:34:22 -08:00
Adrian Sampson
8151a40f1f discogs: Catch socket errors (#1299)
See also:

https://github.com/discogs/discogs_client/issues/44
2015-02-02 22:27:14 -08:00
Adrian Sampson
bb967dd629 Merge branch 'master' of github.com:sampsyo/beets 2015-02-02 15:29:52 -08:00
Adrian Sampson
1b22f122a8 Binary literals in unique_path (fix #1298) 2015-02-02 15:28:44 -08:00
Tom Jaspers
6ed0b2e0f3 Expose an Item's filesize as a field
- Update test-case for info to make sure the item's path is pointing to an actual file.

See #1291
2015-02-02 21:52:23 +01:00
Adrian Sampson
313c3807aa scrub: Use syspath in beet scrub (#1297) 2015-02-02 10:42:31 -08:00
Adrian Sampson
465719a208 scrub: Catch IOErrors in command (fix #1297) 2015-02-02 10:13:48 -08:00
geigerzaehler
46ba99ce79 Merge pull request #1295 from sampsyo/more-info
Info plugin can filter properties in output
2015-02-01 21:19:24 +00:00
Thomas Scholtes
482008bf1d Info plugin can filter properties in output
Resolves #1287
2015-02-01 21:51:26 +01:00
Thomas Scholtes
b150d40394 Changelog for #1294 2015-02-01 21:49:49 +01:00
Adrian Sampson
f0faf5c26b Merge pull request #1294 from sampsyo/write-tags
Extend item.write() to embed images without changing item
2015-02-01 12:35:09 -08:00
Adrian Sampson
b68708f81e Installation instructions for Fedora (fix #375) 2015-02-01 12:22:24 -08:00
Tom Jaspers
a2b00a8408 Changelog entry for #1291 2015-02-01 20:32:28 +01:00
Malte Ried
e681449785 Added documentation
FileFilterPlugin uses the new return value feature
Some tweaks to get the code more readable
2015-02-01 17:01:06 +01:00
Malte Ried
754a90dc90 Merge branch 'master' into import-autosingleton 2015-02-01 16:12:59 +01:00
Thomas Scholtes
51ab099145 Extend item.write() to embed images without changing item
Fixes #1241 and geigerzaehler/beets-check#14

Before, `embed_item` would add the images to the item and then call
`item.write()` to write the item data, including the image, to the
file. This would trigger `item.store()` in the `after_write` hook of
the check plugin. This would in turn try to persist the temporary
`images` attribute of the item, resulting in an SQL error.
2015-02-01 15:35:24 +01:00
Tom Jaspers
43e9044843 Duplicate album-import summary shows old/new filesize
E.g.:
Old: 13 items, MP3, 256kbps, 44:32, 101MB
New: 13 items, MP3, 320kbps, 44:31, 128MB

Fix #1291
2015-01-31 22:11:43 +01:00
Adrian Sampson
336bb9255c chroma: Fix refactored beet submit
Fix #1293.
2015-01-31 13:04:11 -08:00
Adrian Sampson
14ce6a557e Merge pull request #1183 from marcaddeo/refactor-ftintitle
Refactor ftintitle

Conflicts:
	beetsplug/ftintitle.py
2015-01-31 12:51:15 -08:00
Adrian Sampson
8b5d43b32e Merge branch 'master' of github.com:sampsyo/beets 2015-01-31 11:56:39 -08:00
Adrian Sampson
3f0dbb876d Tests for #1285: normalize Unicode filenames 2015-01-31 11:54:32 -08:00
Adrian Sampson
9de9d2497f Unicode tests for #1285 2015-01-31 11:29:32 -08:00
Adrian Sampson
614fbf20ca Tests for #1285: parameterize tests
Also remove an errant `print` and use `rb''` literals for regexes.
2015-01-31 11:24:27 -08:00
Bruno Cauet
f284d8fad5 Handle shlex parse errors in query strings
Provide context: offending query string.
Update changelog.
Fix #1290.
2015-01-31 19:54:07 +01:00
Bruno Cauet
e99adddb11 Importer: byte strings for multi-disc directories
Make regexes from raw byte strings and not unicode.
Update the tests.

Fix #1285
2015-01-31 15:40:49 +01:00
Bruno Cauet
557330e994 Fix open numeric ranges
Also improve InvalidQueryError message and update
NumericQuery._convert() docstring.

Fix #1288.
2015-01-31 14:21:32 +01:00
Malte Ried
a608a5fc36 Plugins are able to return a list of import tasks to create instead of the original import task using the import_task_created event. Needed for #1167 2015-01-31 12:41:01 +01:00
Tom Jaspers
927a53d59b Merge pull request #1281 from tomjaspers/configurable-colors
Colors are now user configurable.

Conflicts:
	beets/ui/__init__.py
	beets/ui/commands.py
2015-01-30 13:48:19 +01:00
Tom Jaspers
0947b8f286 Move color-lookup from config in to the colorize function
The mapping occurs lazily (and only once); now in a more pythonic style
2015-01-30 13:40:55 +01:00
Tom Jaspers
f483012183 Colorize is now to be called with the abstract color_name instead of the color.
E.g., `colorize('text_success', 'hello world')`

To ensure compatibility with 3rd party plugins, a valid color ('red') can still be passed,
but it will be logged.
2015-01-29 14:33:57 +01:00
Tom Jaspers
ea687baebd Configurable colors: update documentation and changelog 2015-01-29 14:05:00 +01:00
Tom Jaspers
e7378c77a7 Fix tests to use config['ui']['color'] instead of top-level color 2015-01-29 14:04:37 +01:00
Adrian Sampson
fc82f2bb89 Changelog for #1190/#1272 2015-01-28 11:43:35 -08:00
Adrian Sampson
2496867daf Merge pull request #1272 from tomjaspers/master
Display clear error message when MusicBrainz is unreachable
2015-01-28 11:42:40 -08:00
mried
d73a55cf19 Merge pull request #1267 from mried/extractart-for-albums
Extractart for albums
2015-01-28 17:23:42 +01:00
Malte Ried
67ecf32671 Fixed typos. 2015-01-28 15:46:16 +01:00
Malte Ried
e2a7f7c153 Merge branch 'master' into extractart-for-albums 2015-01-28 15:44:36 +01:00
Bruno Cauet
61c7c837ec Fix byte string management in ui.print_()
Joining byte strings → prefix ' ' with b
2015-01-28 11:13:54 +01:00
Adrian Sampson
790c41a73d write: Do not try to write non-writable fields
Fix #1268.
2015-01-27 15:03:19 -08:00
Adrian Sampson
84b42b6f1e Tox: Do not conflate 2.6 with setup.py test
It was confusing to have different ways of running the tests for the two
versions. This also reduced the verbosity, making Travis' web interface more
useful.
2015-01-27 14:04:12 -08:00
Adrian Sampson
ac3ea16656 Fix for unicode_literals in scrub
Here's an example where unicode_literals may not be a great idea: these should
probably be "native" strings, i.e., bytes on 2.x and unicode on 3.x.
2015-01-27 13:48:13 -08:00
Malte Ried
2c75d0567f Made the new functionality the default behaviour. 2015-01-27 19:59:49 +01:00
Malte Ried
07cea16492 Changed the interface of extractart to make it easier to understand what it does. 2015-01-27 19:41:25 +01:00