Commit graph

7367 commits

Author SHA1 Message Date
Adrian Sampson
cb7c6bfb69 Use free-form MP4 tag for album gain (#2426)
I'm not sure how this got messed up, but this was:
- Trying to store album gain in the track peak part of the SoundCheck tag!
- Not writing the album gain to the non-SC free-form RG tag!

Together, this led to serious weirdness when writing these fields on AAC
files.

To be clear, we currently *only* support track-level data for SoundCheck. We
also record album-level RG information in non-iTunes tags, but that's
separate. A little googling suggests that SoundCheck now has album-level data,
but supporting that is a separate issue.
2017-02-04 14:16:11 -06:00
Adrian Sampson
0216ef294a badfiles: Python 3 compatibility
Discovered while working on #2428 that we were using an implicit bytes-to-str
conversion on the extension. This broke dict lookup on Python 3.
2017-02-04 13:43:23 -06:00
Adrian Sampson
0131ce263d badfiles: Better logging and error handling (#2428) 2017-02-04 13:42:24 -06:00
Adrian Sampson
c09a3379cf Merge branch 'master' of github.com:beetbox/beets 2017-02-01 00:37:27 -05:00
Adrian Sampson
707796e609 Update Windows registry file for Python 3.6
Closes #2424.
2017-02-01 00:36:37 -05:00
Frederik “Freso” S. Olesen
7c07d8add7 Merge pull request #2421 from jaylesworth/master
Change license and email address in mbcollection plugin.
2017-01-31 10:43:46 +01:00
Jeffrey Aylesworth
8638157e17 Change license and email address in mbcollection plugin. 2017-01-30 23:37:01 -05:00
wordofglass
c252b9256b Merge pull request #2415 from beetbox/fetchart_cleanup
fetchart: Clean-up data structures
2017-01-30 10:18:33 +01:00
wordofglass
7c79d8ce89 fetchart: minor restructuring of tests. 2017-01-30 10:01:19 +01:00
Adrian Sampson
0a13240b22 Merge pull request #2417 from bartkl/patch-1
Update config.rst: see issue #2410
2017-01-28 15:50:09 -05:00
Adrian Sampson
48337870cc Bump the required discogs-client version (#2387) 2017-01-28 15:21:10 -05:00
A.L. Kleijngeld
24027d1bf8 Update config.rst: see issue #2410
`When a match is above the *medium* recommendation threshold`
->
`When a match is below the *medium* recommendation threshold`

As discussed in issue #2410, which is fixed by this edit.
2017-01-27 21:48:46 +01:00
Adrian Sampson
0be4dc722f Merge pull request #2408 from beetbox/standalone-convert-stub
Remove dependencies from convert_stub.py
2017-01-25 15:31:34 -05:00
wordofglass
bc582701ff fetchart: Internally pass settings in a cleaner way.
Dump the 'extra' dictionary which only duplicated attributes of the
plugin onject in favor of passing a reference to the plugin directly.
2017-01-25 00:01:05 +01:00
Adrian Sampson
2a33db3bb6 Merge pull request #2412 from artemutin/mpdstats_on_play
mpdstats: More general approach to multiple on_play calls for the same song
2017-01-23 19:14:56 -08:00
Artem Utin
40eef2056c Add changelog entry, wrap long comment lines. 2017-01-24 11:41:55 +10:00
Artem Utin
2ab1f3ae89 More general approach to multiple on_play calls for the same song - now it ignores such calls, if time between calls was below threshold 2017-01-23 23:15:14 +10:00
Adrian Sampson
3a6967eb7a Remove dependencies from convert_stub.py
See: https://github.com/beetbox/beets/pull/2403#issuecomment-274358494
2017-01-22 12:59:04 -08:00
Adrian Sampson
44963598e8 Remove unused import 2017-01-21 23:32:36 -08:00
Adrian Sampson
ca904a9d0c mpdstats: Fix Python 3 compatibility (fix #2405)
We previously needed a hack to get the client to consume and produce Unicode strings. The library has since added Unicode support, behind a constructor flag. We can remove the hack now, which was causing a crash on Python 3 because the library uses Unicode by default there, and instead use its built-in support.
2017-01-21 23:21:11 -08:00
Adrian Sampson
c21f456f03 tox: Use Python 3.6 in default tests
Just typing `tox` should use the most relevant Python versions.
2017-01-20 20:53:05 -08:00
Adrian Sampson
c2b6623aac Remove an unnecessary list conversion (#2399)
Indexing a string works just fine.
2017-01-20 20:52:58 -08:00
Adrian Sampson
ad957b51d8 Merge pull request #2399 from diomekes/aunique-bracket
Add bracket argument to aunique
2017-01-20 20:52:49 -08:00
diomekes
672fc36cc8 fix docstring for aunique empty bracket 2017-01-20 23:08:36 -05:00
diomekes
04f7915d41 change no-bracket argument from white space to empty 2017-01-20 22:47:47 -05:00
diomekes
eaa2161a90 fix empty disambig string test 2017-01-20 19:40:09 -05:00
diomekes
d10df34c65 add test for aunique without brackets 2017-01-20 09:06:38 -05:00
diomekes
3a967df396 simplify check for empty disam_val, update changelog and docs, add change bracket test 2017-01-19 20:41:44 -05:00
diomekes
377a2a6964 add bracket argument to aunique 2017-01-19 20:39:12 -05:00
Adrian Sampson
958ad430fc bpd: Use integers for time values (fix 2394) 2017-01-17 11:37:10 -08:00
Adrian Sampson
23e05fe0b1 Merge pull request #2389 from irskep/pr/web-features
A new 'beet web' endpoint and configuration option, with docs
2017-01-16 08:43:57 -08:00
Steve Johnson
926dce241c Use util.displayable_path instead of naive .decode() 2017-01-15 11:25:03 -08:00
Steve Johnson
1426aea4a2 Update docs 2017-01-15 11:21:59 -08:00
Steve Johnson
e3707e45f3 Maybe fix code and tests for Windows 2017-01-15 11:21:59 -08:00
Steve Johnson
e2be6ba781 Query path with bytestring. Might fix tests. 2017-01-15 11:21:59 -08:00
Steve Johnson
6b7a6baaf2 Add test for /item/path/ endpoint 2017-01-15 11:21:59 -08:00
Steve Johnson
d8fbdbc16a Update changelog 2017-01-15 11:21:59 -08:00
Steve Johnson
4434569ddc beets.library.Library adds custom bytelower function to all connections, not just one 2017-01-15 11:21:59 -08:00
Steve Johnson
866a650bc0 Rename /item/by_path to /item/path and use PathQuery instead of direct file access 2017-01-15 11:21:33 -08:00
Steve Johnson
05bc4996a8 Rename and invert new config option 2017-01-15 11:21:33 -08:00
Steve Johnson
a994df6aa6 Fix bad doc formatting 2017-01-15 11:21:33 -08:00
Steve Johnson
c409a71ea1 Add missing plus signs to web.rst 2017-01-15 11:21:33 -08:00
Steve Johnson
cedd93b778 Add tests for exclude_paths_from_items 2017-01-15 11:21:33 -08:00
Steve Johnson
50ea74635b Fix tests I broke 2017-01-15 11:21:33 -08:00
Steve Johnson
f6cb46d490 Fix broken tests (no new ones yet) 2017-01-15 11:21:33 -08:00
Steve Johnson
43936cd84c /item/at_path/ endpoint
More at_path

/item/by_path docs
2017-01-15 11:21:33 -08:00
Steve Johnson
29d61ca634 web.exclude_paths_from_items option
More exclude_paths_from_items
2017-01-15 11:21:33 -08:00
Adrian Sampson
dd7f8a3a6f Tiny docstring tweak for #2390 2017-01-15 10:12:49 -08:00
Adrian Sampson
9564efc87e Merge pull request #2390 from irskep/pr/fix-bytelower
beets.library.Library adds custom bytelower function to all connections, not just one
2017-01-15 10:10:43 -08:00
Steve Johnson
31c49a6216 beets.library.Library adds custom bytelower function to all connections, not just one 2017-01-14 19:35:00 -08:00