Commit graph

7351 commits

Author SHA1 Message Date
Adrian Sampson
079822b893 Importer: no separate stage for applying metadata
It's cheaper and easier to just apply metadata in the UI thread. The
advantage, then, is that we no longer need to keep track of anything in-memory
to enumerate data that has been seen by the user but not added to the database
yet!

In the next step, I'll remove `seen_idents` altogether.
2015-10-24 13:03:26 -07:00
Adrian Sampson
cc5aba8294 Roll back PR #1358: regression on recent duplicate
This should fix #1652, which found that this code did the wrong thing when
there were *no* `found_duplicates`: that is, when the duplicate actually came
from the `seen_keys` list, so the album is not in the database yet. This
handling was confusing "no non-empty duplicates" with "no in-database
duplicates", and incorrectly bypassing the duplicates prompt.

Since having empty albums in the database is a rare case (it should be
impossible!), and we should no longer *crash* when it happens, I am
considering it unnecessary to handle it specially. The user will now just see
"Old: 0 items" and that's that.
2015-10-24 12:46:27 -07:00
Adrian Sampson
15190794dc Log more details about duplicates
Part of the investigation into #1652.
2015-10-24 12:39:27 -07:00
Adrian Sampson
f784cd1a22 Fix #1656, maybe: encode Discogs token strings 2015-10-24 12:07:40 -07:00
Adrian Sampson
f4a617e641 Move color option in config example (fix #1653) 2015-10-19 13:44:52 -07:00
Adrian Sampson
10dc42d1d2 Changelog for #1649 2015-10-19 13:27:29 -07:00
Adrian Sampson
3503e6d1b2 Merge branch 'master' of github.com:sampsyo/beets 2015-10-19 11:40:59 -07:00
Adrian Sampson
e937ca5c15 Fix grammar in a docstring 2015-10-19 11:12:36 -07:00
Adrian Sampson
b4ecef9d47 Merge pull request #1650 from Nerten/master
Update plexupdate.py
2015-10-19 11:00:40 -07:00
Alex Nerten
a4ae7fa891 Update plexupdate.py
Fix #1649
2015-10-19 15:24:59 +03:00
Jack Wilsdon
0a7eb9e884 Merge pull request #1648 from Kernald/patch-1
Fix example of Types plugin documentation
2015-10-18 13:29:17 +01:00
Marc Plano-Lesay
054b9728b5 Fix example of Types plugin documentation 2015-10-18 13:46:39 +02:00
Adrian Sampson
ef26d4c926 Version bump for 1.3.16 2015-10-17 17:45:46 -07:00
Adrian Sampson
60e5e388cc Add date for 1.3.15 release 2015-10-17 17:45:21 -07:00
Adrian Sampson
9524ddcfe3 Clean up changelog for 1.3.15 release 2015-10-17 17:44:34 -07:00
Adrian Sampson
0b3ecfc6e8 Doc tweaks for #1639 2015-10-17 14:52:29 -07:00
Adrian Sampson
000487c757 Merge pull request #1639 from sadatay/genius_lyrics
Add Genius as a lyric source
2015-10-17 14:51:01 -07:00
Adrian Sampson
7c6f7b2fa7 Doc tweaks and changelog for #1641 (fix #1621) 2015-10-17 14:43:16 -07:00
Adrian Sampson
8c35a24073 zero: Check for conflicts only once (#1641)
The old version would trigger the warning twice.
2015-10-17 14:39:53 -07:00
Adrian Sampson
71acf93ef3 Merge pull request #1641 from adkow/zero-whitelist
Add whitelist feature to zero plugin
2015-10-17 13:18:56 -07:00
Joe LaSala
3ab9932059 Add Genius as a lyric source
Makes use of the Genius API and genius-api.com, a separate resource that
provides readable lyrics.
2015-10-13 19:14:08 -05:00
Adrian Kowalski
d180d42ddb Fix flake8 complaint about line length 2015-10-12 09:50:12 +02:00
Adrian Kowalski
da655534ae Change function name and correct documentation style 2015-10-12 09:39:20 +02:00
Adrian Kowalski
84da4b89a5 Update documentation for zero plugin 2015-10-09 21:38:38 +02:00
Adrian Kowalski
158486319f Improve code quality, separate shared logic into functions 2015-10-09 21:23:59 +02:00
Adrian Kowalski
9f51e46bae Add whitelist feature to zero plugin 2015-10-09 18:41:42 +02:00
Adrian Sampson
13fede597f Fix my fix for #1586: iterate over views 2015-10-08 10:40:18 -07:00
Adrian Sampson
3c8823db96 Run case sensitivity check (#1586) on bytestring
This should avoid problems when querying for Unicode paths.
2015-10-07 16:38:27 -07:00
Adrian Sampson
d29cc7b2c0 Refine docs for #1586 2015-10-07 16:36:12 -07:00
Adrian Sampson
a0a9af261c Use syspath in case sensitivity check (#1586) 2015-10-07 16:33:29 -07:00
Adrian Sampson
4677903844 Reorganize case sensitivity check function
Just a little readability enhancement.
2015-10-07 16:31:59 -07:00
Adrian Sampson
9e5e9a23ab Query case sensitivity depends on the query (#1586)
This could match intuition a little more closely and also avoids a coupling
with the configuration.
2015-10-07 15:53:26 -07:00
Adrian Sampson
9bf95bf634 Some test code cleanup for #1586 2015-10-07 15:50:32 -07:00
Adrian Sampson
3b604c7ff9 Merge pull request #1586 from mried/RobustCaseSensitiveDetection
A robust way to check for a case sensitive file system
2015-10-07 15:43:38 -07:00
Adrian Sampson
9f1c113476 For #1617: Use Confit's built-in path resolution
Has the side effect of raising more reasonable errors when the type is wrong.
2015-10-07 15:36:31 -07:00
Adrian Sampson
fe1fab9aee For #1617, fix laziness with a new subclass 2015-10-07 15:32:07 -07:00
Adrian Sampson
41c5f57339 Merge pull request #1637 from pferdefleisch/fix-genre-yaml
Remove yaml keys without sublists
2015-10-07 09:21:04 -07:00
Aaron Cruz
5fd836b173 Remove yaml keys without sublists 2015-10-07 12:15:09 +02:00
David Logie
168a1645e0 Move the included file loading out of confit.py. 2015-10-05 14:01:26 +01:00
David Logie
bfc5a1b803 Add new `include` config option.
This new option allows users to provide a list of external config files
which will be evaluated when beets starts.

This is useful for keeping private settings (e.g. API keys) out of the
main configuration file.
2015-10-05 14:01:26 +01:00
Peter Kessen
60e225deae corrected test for logging see #1627 2015-09-30 20:02:32 +02:00
Peter Kessen
0a5d9c28db added changelog entry for PR #1623 2015-09-30 19:48:42 +02:00
Adrian Sampson
3475b91c00 Remove unused import
Oops. I was trying to use shlex.quote, but that's Python 3.3+.
2015-09-30 10:32:37 -07:00
Adrian Sampson
2607bee997 Tiny fixes for play 2015-09-30 10:11:17 -07:00
Adrian Sampson
092472d750 Merge pull request #1623 from pkess/test_init
New tests for human readable values
2015-09-30 09:18:32 -07:00
Adrian Sampson
d370aa0791 Merge pull request #1630 from pkess/remove_mtime
removed deprecated checko for mtime!=None
2015-09-30 09:15:56 -07:00
Peter Kessen
6993449602 removed deprecated checko for mtime!=None 2015-09-30 16:40:30 +02:00
Peter Kessen
b980c60941 corrected another testcase for previous commit 2015-09-29 17:40:57 +02:00
Peter Kessen
fffb727033 corrected output of file size
using unit e.g. 5.4 KiB instead of 5.4 KB now
2015-09-29 17:33:54 +02:00
Adrian Sampson
f98dc8a432 Merge pull request #1627 from pkess/addLoggingTest
added test for logging
2015-09-28 08:24:46 -07:00