Commit graph

7351 commits

Author SHA1 Message Date
jmwatte
5a8a534a3f Delete yamleditor.py 2015-11-03 14:05:06 +01:00
jmwatte
91f67146f9 Delete yamleditor.rst 2015-11-03 14:04:39 +01:00
jmwatte
00b21dfa51 Merge branch 'editor' of https://github.com/jmwatte/beets into editor 2015-11-03 13:59:38 +01:00
jmwatte
2d77861e4d renamed and updated editplugin 2015-11-03 13:55:08 +01:00
reiv
33ea9f1c10 Revert all changes on this branch thus far
Revert "PEP8 amendments"

This reverts commit 413fe6bbfd.

Revert "Importer: Delete orphaned album art on..."

This reverts commit 629a80a1d1.
2015-11-03 11:33:35 +01:00
Adrian Sampson
38edb18a74 Merge pull request #1683 from sampsyo/1264-unnecessary-resize
Fix #1264: Avoid unnecessary art resizes
2015-11-02 22:39:06 -08:00
reiv
1625dfc17e Merge branch 'master' into 1264-unnecessary-resize 2015-11-03 02:46:33 +01:00
reiv
5d0048c03d Changelog for #1683 2015-11-03 02:38:02 +01:00
reiv
19dcc25a93 fetchart: Improve validation of image dimensions
This avoids images being resized unnecessarily if the dimensions
are correct.
2015-11-03 02:19:47 +01:00
reiv
93009911e0 fetchart: Add test for image resizing
This test ensures that images are resized if and only if they are
wider than the maxwidth setting.
2015-11-03 02:17:21 +01:00
Adrian Sampson
bfa2fbf6af Changelog for #1675 2015-11-02 16:46:32 -08:00
Adrian Sampson
d79d11fb15 Docstring and rewrap for #1675 2015-11-02 16:45:45 -08:00
Adrian Sampson
e84414c822 Fix syntax (and unused variable) in #1675 2015-11-02 16:44:02 -08:00
Adrian Sampson
efcea9a57f Merge pull request #1675 from kooimens/patch-1
Embedart: remove_art_file on import
2015-11-02 16:42:59 -08:00
jmwatte
f0040370ec Update yamleditor.rst
polishing
2015-11-02 23:57:11 +01:00
kooimens
bcef3a7123 Create function remove_artfile
Damn it, that was really hard for me:D. First time seriously using python. Please review it carefuly.
2015-11-02 23:56:38 +01:00
Adrian Sampson
69b0ae9745 Add an FAQ about changing music directories 2015-11-02 14:40:00 -08:00
jmwatte
3741e28947 Update yamleditor.rst
polishing
2015-11-02 23:23:57 +01:00
jmwatte
fdbf9e59e7 Update yamleditor.py
polishing
2015-11-02 23:11:42 +01:00
jmwatte
149dd8676a Update yamleditor.rst
polishing
2015-11-02 23:09:50 +01:00
jmwatte
151c1f3fbd Update yamleditor.rst
polishing
2015-11-02 23:00:02 +01:00
jmwatte
a3ee1d0d37 Update yamleditor.rst
more polishing
2015-11-02 22:21:03 +01:00
jmwatte
e3e8150277 Update yamleditor.rst
polishing
2015-11-02 22:07:59 +01:00
jmwatte
d5c9be44d4 Update changelog.rst 2015-11-02 22:02:20 +01:00
jmwatte
6c08aae3a4 Update changelog.rst
added yamleditor(a new plugin) entry
2015-11-02 21:42:58 +01:00
jmwatte
fe012eae77 new plugin yamleditor 2015-11-02 21:13:58 +01:00
Adrian Sampson
a18506f471 Fix #1686: thumbnails using unicode paths 2015-11-02 11:03:43 -08:00
reiv
f891184f0a Merge pull request #1682 from sampsyo/1126-deleted-art
Fix #1126: Check if album art file actually exists
2015-11-02 03:07:06 +01:00
reiv
db08896d8c fetchart: add docstring to helper function
_is_valid_image_candidate() now has three different return values.
These are documented here.
2015-11-02 03:04:45 +01:00
reiv
b76597bc43 Changelog for #1126 2015-11-02 02:36:15 +01:00
reiv
d0cfb3e990 fetchart: add test for re-fetching deleted art
This test addresses #1126.
2015-11-02 02:20:09 +01:00
reiv
9182fd8f04 PEP8 amendments 2015-11-01 16:20:48 -08:00
reiv
3250fa80ae fetchart: Only resize when necessary
Fixes #1264: When a re-import triggers fetchart, the existing album art is no
longer resized if it already has the correct dimensions. This avoids creating
new album art files with unique filenames ("cover.n.jpg").
2015-11-01 16:20:18 -08:00
reiv
269d0e5403 fetchart: Check if album art file actually exists
Fixes #1126.
2015-11-01 16:14:51 -08:00
reiv
413fe6bbfd PEP8 amendments 2015-11-01 16:12:25 -08:00
reiv
629a80a1d1 Importer: Delete orphaned album art on re-imports
First step towards fixing #314.
2015-11-01 16:10:56 -08:00
Adrian Sampson
c617033476 convert: Add some comments 2015-11-01 11:01:40 -08:00
Adrian Sampson
5f5a8946c3 convert: Debug log when embedding images
To help diagnose #1671.
2015-10-30 15:25:01 -04:00
kooimens
0257b1077f Simplify some code 2015-10-30 17:49:57 +01:00
kooimens
0ed98515ad Embedart: remove_art_file on import
Should fix #1662.

I think the fix is easy. Don't know if it's clean though. Did some tests (+/- 10 albums), all successful. This is the first time I'm using python so please let me know what I should improve:)
2015-10-30 17:04:11 +01:00
Adrian Sampson
16ad174d29 A debug message for ReplayGain 2015-10-29 17:43:31 -04:00
Frederik “Freso” S. Olesen
0fbd8d2dfb lastgenre: Clean up of the reggae related genres.
Fixes #1661.
2015-10-29 05:06:40 +01:00
Frederik “Freso” S. Olesen
41cbb47918 Add changelog entry for #1661. 2015-10-29 05:04:59 +01:00
Frederik “Freso” S. Olesen
5f5365021d lastgenre: Clean up Spanish reggae in the genre list.
* Add missing subgenres to whitelist and tree.
* Use proper terminology.
  * Add English term as child of Spanish one.

Source: https://en.wikipedia.org/wiki/Reggae_en_Espa%C3%B1ol
2015-10-29 05:00:33 +01:00
Frederik “Freso” S. Olesen
1aa808f37b lastgenre: Add raggamuffin.
Already recognised by the genres.txt whitelist, and is a more proper
term for `ragga`.

https://en.wikipedia.org/wiki/Ragga
2015-10-29 04:58:44 +01:00
Frederik “Freso” S. Olesen
1678c1d847 lastgenre: Replace top-level genre ska with reggae
… and move relevant genres from the tree to be children of the `reggae`
top-level genre as well as add `roots reggae` to the list.

See discussion at https://github.com/sampsyo/beets/issues/1661
2015-10-29 04:55:57 +01:00
Frederik “Freso” S. Olesen
b187251a7e lastgenre: Remove dance hall and polish reggae.
Neither of the two are recognised in the genres.txt whitelist.
2015-10-29 04:53:14 +01:00
Frederik “Freso” S. Olesen
004fb7d1c8 lastgenre: Fix up ragga jungle.
* Move `ragga jungle` to beneath `oldschool jungle`.
* Remove `ragga-jungle` which isn't recognised by the genre whitelist.

https://en.wikipedia.org/wiki/Ragga_jungle
2015-10-29 04:44:15 +01:00
Adrian Sampson
2537c06ac7 Changelog for #1652 fix 2015-10-24 13:09:15 -07:00
Adrian Sampson
4c6dbe6780 Remove seen_idents set
This was used since time immemorial to keep track of recently-imported music
that hasn't hit the database yet. I created it when the importer only added
music to the database at the end of the pipeline, after doing all the work to
manipulate the metadata. Now, for several reasons, we add the music
immediately after the user sees it and then manipulate the records *in the
database*. With the latest change, which gets rid of the last separation
between UI and database-adding, we no longer need to do this.
2015-10-24 13:06:16 -07:00