Commit graph

3955 commits

Author SHA1 Message Date
Adrian Sampson
c5293df963 replaygain: More descriptive backend errors
This avoids a bare `except:` to catch specific errors and give better messages
when they fail. Should provide more insight to this trouble:
https://groups.google.com/d/msg/beets-users/6d-TOg0SuPY/iL39tmo3rqUJ

Also related to #874.

Feedback from @yevgenybezman or others more familiar with the backend would be
welcome.
2014-10-09 12:26:53 -07:00
Adrian Sampson
983aac287b Add a displayable_path call in embedart (fix #995) 2014-10-09 11:13:39 -07:00
Fabrice L.
18ee57085d Merge pull request #993 from KraYmer/lastgenre_coverage
Lastgenre coverage (mocking galore)
2014-10-09 06:54:26 +02:00
Fabrice Laporte
b32838b519 fix flake8 2014-10-09 06:47:23 +02:00
Fabrice Laporte
2b908b48bc lastgenre: use an ordinary Item instead of a Mock 2014-10-09 06:38:40 +02:00
Fabrice Laporte
b95990ee9c lastgenre: add unit tests 2014-10-09 00:00:26 +02:00
Fabrice L.
cf6a15df95 revert 0f5c2a4 2014-10-08 14:27:13 +02:00
Fabrice L.
0f5c2a41b2 tox: add bs4 dependency
bs4 is required by few test_lyrics.py tests
2014-10-08 13:34:05 +02:00
Fabrice L.
abe7a2cd20 Update embedart.rst 2014-10-05 21:22:22 +02:00
Adrian Sampson
2b1353a4f1 Malformed date queries no longer crash 2014-10-04 16:50:50 -07:00
Adrian Sampson
44ff3f782a Remove prefix diff highlighting
This was well-intentioned but ended up being more confusing than it was worth.
It's always confused me when one digit gets un-highlighted in one of these
displays. The straw that broke the camel's back was when I got a "#1 -> #16"
change where the numeral "1" was un-highlighted. To fix this right would be
way more trouble than it's worth; I'm glad to be rid of this detail.

Conflicts:
	docs/changelog.rst
2014-10-04 16:47:00 -07:00
Lucas Duailibe
9b03c46702 play: removing tmp file (changelog) 2014-10-04 14:50:17 -03:00
Lucas Duailibe
17dbf2a22d play: remove temporary m3u file 2014-10-03 12:49:06 -03:00
Adrian Sampson
ae09f14615 Changelog for #985 2014-09-30 11:30:45 -07:00
Adrian Sampson
5c2ca2ba59 Merge pull request #985 from IndiGit/master
added bpd option for initial volume setting
2014-09-30 11:28:01 -07:00
Ralf Sieger
2ead4d352a Added documentation about the new volume option 2014-09-30 19:14:33 +02:00
Ralf Sieger
ab5c5dcfd5 added option for initial volume setting 2014-09-30 09:34:04 +02:00
Adrian Sampson
6348164e9a Merge pull request #984 from sampsyo/reimport-metadata
Re-imports: preserve added dates and flexible attributes
2014-09-29 10:32:18 -07:00
Adrian Sampson
f88a960a63 Changelog for #984
[ci skip]
2014-09-28 11:50:05 -07:00
Adrian Sampson
06b4730105 Re-import tests: stub out *_for_id functions
Currently, these just return no results. (For our testing purposes, the
matches we get from the ordinary metadata search suffice just fine.)
2014-09-28 11:39:04 -07:00
Adrian Sampson
e69ee5136a Fix "X of Y items replaced" log message
This was erroneous before: it always said "N of N" due to the presence of
empty lists.
2014-09-28 11:22:27 -07:00
Adrian Sampson
a3eef35ba8 Test singleton re-imports 2014-09-28 11:16:38 -07:00
Adrian Sampson
f367a0971c Re-import test: check item-level data preserved 2014-09-28 11:04:25 -07:00
Adrian Sampson
e8d2ade167 Basic re-import tests 2014-09-28 10:58:43 -07:00
Adrian Sampson
d13d6ed1c1 Modernize logging
Unicode strings, .format() templating, and displayable_path sanitation. Really
makes me wish for automatic formatting stuff in the logger...
2014-09-28 10:31:23 -07:00
Adrian Sampson
0bbf027a4d Standardize docstring style 2014-09-28 10:22:31 -07:00
Adrian Sampson
1ce3b9b064 Merge branch 'master' into reimport-metadata
Conflicts:
	beets/importer.py
2014-09-28 10:21:44 -07:00
Adrian Sampson
582dbf6b34 Fix ArtResizer.local property (fix #983) 2014-09-27 11:29:38 -07:00
Adrian Sampson
a29b5fd750 Slight docs rewording 2014-09-27 11:24:52 -07:00
Stig Inge Lea Bjørnsen
62f63e5c32 Comply with PEP8. 2014-09-27 18:47:42 +02:00
Stig Inge Lea Bjørnsen
020e8e27d8 Fix for import and reimport of singleton items. 2014-09-27 18:19:04 +02:00
Stig Inge Lea Bjørnsen
6eb4afb35f Remove unnecessary database queries during reimport. 2014-09-27 18:11:49 +02:00
Fabrice L.
54c9761135 Merge pull request #981 from KraYmer/lyrics-enh
Lyrics scraping code refactored
2014-09-27 11:25:06 +02:00
Fabrice L.
d2db6ae88b Update embedart.rst
add info about threshold for similarity
2014-09-27 11:23:46 +02:00
Fabrice Laporte
3ef52e8ead lyrics.py: remove unnecessary re compile step 2014-09-26 07:08:54 +02:00
Adrian Sampson
d17c148e52 Minor fixes, changelog for #974 2014-09-25 15:33:52 -07:00
Adrian Sampson
4f2d7e0aaa Merge pull request #974 from KraYmer/fetchart_issue848_2
embedart: write candidate image only if it is "similar" to already embedded one (suite)
2014-09-25 15:25:46 -07:00
Fabrice Laporte
3a748f3294 add test_is_page_candidate() 2014-09-25 00:05:29 +02:00
Fabrice Laporte
a6a83be434 fix flake8 2014-09-24 23:30:38 +02:00
Stig Inge Lea Bjørnsen
c6a08a08a5 Add support for reimporting flexible attributes.
Move the reimport and replaced item logic into separate methods:

* ImportTask.record_replaced()
* ImportTask.remove_replaced()
* ImportTask.reimport_metadata()
2014-09-24 22:02:29 +02:00
Fabrice Laporte
879fc8d3ca add LyricsGooglePluginTest to test_lyrics.py 2014-09-24 18:04:37 +02:00
Fabrice Laporte
76b658b14a use beautiful soup strainer for a x20 performance gain! 2014-09-24 18:04:16 +02:00
Adrian Sampson
ee9e51d3cc beet convert -y should not need an argument 2014-09-24 08:01:06 -07:00
Fabrice Laporte
8ef7837d22 merge strip_cruft() and _scrape_normalize_eol() into _scrape_strip_cruft 2014-09-24 16:51:54 +02:00
Adrian Sampson
fc2c75ee9c Tests for mkdirall
A red herring. I thought this might be responsible for #969.
2014-09-23 18:49:38 -07:00
Fabrice Laporte
333591fd78 no html entities in _scrape_streamline_soup output 2014-09-24 00:25:50 +02:00
Fabrice Laporte
da6bcda4af add lyrics rsrc files 2014-09-23 18:05:08 +02:00
Fabrice Laporte
7e3676ecc9 sort sources in alphabetical order
remove test_sources_fail() (all sources pass now)
2014-09-23 18:01:05 +02:00
Fabrice Laporte
91a7eb249c add _scrape_merge_paragraphs lyrics scraping step + others scraping enh 2014-09-23 17:58:58 +02:00
Fabrice Laporte
a938e68c98 refactor scrape_lyrics_from_url into smaller functions 2014-09-23 13:21:31 +02:00