Johnny Robeson
be942c4595
complete more bytestrings in test_embedart
2016-06-15 00:10:01 -04:00
Johnny Robeson
4fbad7dd67
bytestringify path in file_filter
2016-06-14 23:17:08 -04:00
Johnny Robeson
a1314b7bda
move spotify test json to json files
2016-06-14 21:51:27 -04:00
Johnny Robeson
ba2cfcd329
bytestringify subdir paths in importer.albums_in_dir
2016-06-14 04:32:54 -04:00
Johnny Robeson
44380db6e8
If the permission is an int, then simply return it
...
It doesn't seem necessary to convert it, and if it does, then
we're missing a test
2016-06-14 03:50:29 -04:00
Johnny Robeson
8e1bc16228
set default perms as strings in perms plugin itself
...
I originally changed them to octal in my py3 branch,
but they are gonna end up as strings anyways, so I figured we should
just use them that way by default.
2016-06-14 03:47:59 -04:00
Johnny Robeson
0a5c6ce4c0
open tempfile in edit plugin in text mode
2016-06-14 03:38:21 -04:00
Johnny Robeson
4413e2ed94
make Distance a hashable object
...
It previously was hashable, until we added `__eq__`, so we must now do
it explicitly
2016-06-14 02:01:58 -04:00
Johnny Robeson
4b2c4ced6c
wrap extra_ops.keys() in a list in ui/commands
2016-06-14 01:55:47 -04:00
Johnny Robeson
ebff5a599c
treat filenames as bytestrings in perm plugin tests
2016-06-14 01:29:35 -04:00
Johnny Robeson
ef727854f1
treat default perms as str in permission plugin tests
2016-06-14 01:28:13 -04:00
Johnny Robeson
3112a18463
treat ctypes .value as bytes in thumbnails plugin
2016-06-14 00:51:12 -04:00
Johnny Robeson
8fa71f78fe
decode bytes from .encode() in lyrics plugin
2016-06-14 00:44:43 -04:00
Johnny Robeson
0f4b907ff5
wrap filter()s in a list() in replaygain plugin
2016-06-14 00:28:46 -04:00
Johnny Robeson
622945e2a9
wrap importer match keys in list() since we need one
2016-06-14 00:28:00 -04:00
Johnny Robeson
bdc0c4e2a7
Merge pull request #2049 from jrobeson/bytestring-normalization-1
...
bytestring normalization
2016-06-13 05:59:09 -04:00
Johnny Robeson
ffa46a185c
bytestring normalization
...
Make sure many/most strings that touch the filesystem are
converted explicitly to bytestrings rather than implictly.
2016-06-13 05:39:09 -04:00
Johnny Robeson
6745759ea5
open even more files in binary mode
...
* play plugin
* smartplaylist plugin
2016-06-13 05:18:33 -04:00
Johnny Robeson
4dd43f1081
write to the m3u file in binary mode in importfeeds
2016-06-12 20:27:01 -04:00
Johnny Robeson
92950ec532
wrap keys() result in a list() in importadded tests
2016-06-12 18:17:27 -04:00
Johnny Robeson
10dda13d2a
remove unneeded bytes casting from test_mb
2016-06-12 18:03:08 -04:00
Johnny Robeson
a76de95183
return a bytestring path from RemoteArtSource
2016-06-12 01:19:39 -04:00
Johnny Robeson
6c969ae58c
remove some incorrect displayable_path in library tests
...
These were noticed by @sampsyo in the review of
daac41668e
2016-06-11 21:29:17 -04:00
Johnny Robeson
fff1458a9e
introduce PATH_SEP attr to beets.util
...
This is needed for various path tests that expect to operate on
bytestrings
2016-06-11 21:26:23 -04:00
Johnny Robeson
2b222d6091
remove outdated ordereddict dep from setup.py
2016-06-11 03:51:23 -04:00
Johnny Robeson
f8bdf7498f
use _common.PLUGINPATH in one more place
...
Not sure how I missed it, but I did
2016-06-11 03:33:50 -04:00
Johnny Robeson
ed4ce6214b
remove pyechonest from tox config
2016-06-11 03:11:34 -04:00
Johnny Robeson
e97d93b8f5
introduce a PLUGINPATH attr to _common test
...
I consider this a test global option. It should help split up the
ui tests a bit
2016-06-11 03:00:43 -04:00
Johnny Robeson
ea7f994839
make the entire RSRC path a bytestring
2016-06-11 02:11:14 -04:00
Adrian Sampson
41d9739323
Enable Windows tests on AppVeyor ( fix #670 )
2016-06-10 15:54:57 -07:00
Adrian Sampson
e346c28886
ImageMagick check uses convert, not identify
...
See #670 for details. This reverts a change from
a0c38a07a6
2016-06-10 15:29:13 -07:00
Adrian Sampson
9204604a7c
Fix path types in albums_in_dir tests
2016-06-10 12:49:08 -07:00
Johnny Robeson
4e4a919895
write to tempfile in binary in embedart test
2016-06-10 04:52:55 -04:00
Johnny Robeson
61695edc3b
write file tags (for tag tests) in binary mode
2016-06-10 04:12:30 -04:00
Johnny Robeson
6eb1de5405
fix linelengths from displayable_path
2016-06-10 04:08:59 -04:00
Johnny Robeson
daac41668e
use util.displayable_path in more tests
2016-06-10 03:54:39 -04:00
Johnny Robeson
9b8913abdf
explicitly decode json responses in web tests
2016-06-10 03:29:51 -04:00
Johnny Robeson
69c9fb8b07
check dirname result against b'' in fetchart
2016-06-10 02:52:58 -04:00
Johnny Robeson
5e62b39f75
replace TEMPORARY with FIXME in discogs plugin
...
We're more likely to search for this later by FIXME.
NOTE: the bug is fixed, but the versions with the fix may not be widely
distributed yet
2016-06-10 02:30:00 -04:00
Johnny Robeson
5485bdb706
add missing b' in discogs query regex
2016-06-10 02:23:14 -04:00
Johnny Robeson
78139e60e8
add missing b's in _unpack_asf_image
2016-06-10 02:18:54 -04:00
Johnny Robeson
a274b4e737
read and write the pickled statefile as binary
...
Pickle files should be treated as binary files
2016-06-10 02:02:28 -04:00
Johnny Robeson
ab67727283
wrap the cover_names map with a list in fetchart
...
most `cover_names` users expect to operate on a list
2016-06-10 00:09:15 -04:00
Johnny Robeson
02165fc3a9
open lastgenre whitelist in binary mode
2016-06-09 23:53:40 -04:00
Jack Wilsdon
26a17a3703
Remove trailing whitespace added in a45dcdc
2016-06-09 19:23:54 +01:00
Adrian Sampson
0f8fc33952
Fix inverted assertion sense
...
I broke this in 2fefd24
2016-06-09 10:23:24 -07:00
Adrian Sampson
a45dcdc674
Fix Windows env vars for config test
2016-06-09 09:58:10 -07:00
Adrian Sampson
e508daea63
Use syspath for existence checks
2016-06-09 09:43:24 -07:00
Adrian Sampson
2fefd2471a
Use our higher-level assertions for files
2016-06-09 09:39:44 -07:00
Adrian Sampson
9717940c9b
Cross-platform relative path in test
2016-06-08 23:03:45 -07:00
