Commit graph

1342 commits

Author SHA1 Message Date
David Logie
08d5b9c138 Fix line length in docstring. 2014-12-29 19:45:33 +00:00
David Logie
f2704461cf Go back to a single lookup with specific Unicode characters replaced. 2014-12-29 19:37:03 +00:00
Malte Ried
7674399a45 Added the import_task_created event
Improved the IHatePlugin to filter files based on file names
2014-12-29 12:03:51 +01:00
Adrian Sampson
d0dcc74c7e Merge pull request #1181 from marcaddeo/fix-ftintitle-duplicate-album-artist
Fix handling of duplicate album artists in ftintitle
2014-12-28 18:58:36 -04:00
Adrian Sampson
375f9259b9 Merge pull request #1176 from Freso/issue-1172-ftintitle-less-import-verbosity
ftintitle: use log.log() for outputting
2014-12-28 18:52:21 -04:00
Marc Addeo
8c484a273c Fix handling of duplicate album artists in ftintitle
The code that determines the featured artist part of the artist only
handles two element lists. When the album artist is duplicated, it
splits into a three element list causing no featured artist to be found.

This ensures the albumartist_split can ever only have 2 elements.

Fixes #1179
2014-12-28 17:51:48 -05:00
Stig Inge Lea Bjørnsen
9227a51588 Add a missing space 2014-12-28 20:40:46 +01:00
Frederik "Freso" S. Olesen
0ec3396d3f ftintitle: Use log.log() instead of ui.print_().
Fixes #1172.
2014-12-28 20:33:56 +01:00
Frederik "Freso" S. Olesen
6182ef1b1e ftintitle: Remove empty ui.print_() call. 2014-12-28 20:33:15 +01:00
David Logie
148d9048d5 Update _cached_lookup() docstring. 2014-12-28 18:38:42 +00:00
David Logie
433d68724a Escape Unicode characters so we don't need the encoding headers. 2014-12-28 18:38:15 +00:00
David Logie
3015c22d40 Fix indent level. 2014-12-26 14:17:49 +00:00
David Logie
d9673ef9b5 lastgenre: Only replace a small set of unicode characters. 2014-12-26 14:08:22 +00:00
Stig Inge Lea Bjørnsen
a2188d475b ImportAdded support for in-place and link imports
Fix for the `ImportAdded` plugin crashing during in-place imports (#1107).

Add support for the new link imports introduced in Beets 1.3.9.

Note that link-imports that preserve file modification times will follow
the links and preserve the mtimes on the link targets. The mtimes on the
links aren't modified.
2014-12-25 21:39:28 +01:00
Michael Ludwig
c76f8bee46 embedart: Added syspath call to art exists check 2014-12-21 13:08:02 -05:00
Adrian Sampson
016c901e6f Fix 2.6 compatibility with subprocess
We can add this back once we go 2.7-only.
2014-12-21 10:09:43 -05:00
Adrian Sampson
e8158194d6 More robust templating (#1157)
Don't require $source and $dest to be bare tokens.
2014-12-21 09:42:58 -05:00
Adrian Sampson
8579412a76 No shell execution (#1157)
Now that we do the proper thing, we do not need shell parsing.
2014-12-21 09:31:41 -05:00
Adrian Sampson
4180f42194 Encoding and other fixes for #1157
Log as one statement. No need to hold the filesystem lock. New variable name.
2014-12-21 09:30:25 -05:00
Adrian Sampson
c4eba5c741 Apply #1157 by @mluds as patch (fix #1158, #1026) 2014-12-21 09:22:56 -05:00
Adrian Sampson
f45d6c2364 Merge pull request #1161 from Kraymer/lyrics_hotfixes_musixmatch
Musixmatch hotfixes
2014-12-21 09:11:45 -05:00
Fabrice Laporte
802d1521ed lyrics: don't throw when extraction fails 2014-12-21 14:38:19 +01:00
Fabrice Laporte
dfc1aa20b3 lyrics: musixmatch, disable https verification 2014-12-21 14:35:16 +01:00
David Logie
c7b6f75ca8 lastgenre: Automatically retry asciified lookups if the initial lookup fails. 2014-12-21 12:58:15 +00:00
Adrian Sampson
02e341cded Fix #1152: mbcollection: choose release collection 2014-12-20 22:21:58 -05:00
Adrian Sampson
021cdb7b4a Fix log statement in inline 2014-12-20 20:06:17 -05:00
David Logie
c227501a5d lastgenre: Optionally replace unicode characters when performing lookups. 2014-12-20 22:13:05 +00:00
Fabrice Laporte
39584a8b69 fix flake8 2014-12-19 00:19:59 +01:00
Fabrice Laporte
c3f82c65a4 fix lyrics.com extraction markers 2014-12-18 23:56:33 +01:00
Adrian Sampson
ba044f8e20 fetchart: Privatize global source list (#1148) 2014-12-18 11:14:22 +00:00
Adrian Sampson
b3bf70c11d Privatize global SOURCES in lyrics 2014-12-18 11:13:02 +00:00
Adrian Sampson
ac3f0824b0 Merge pull request #1148 from Kraymer/lyrics_musixmatch
lyrics: add 'musixmatch' source

Conflicts:
	beetsplug/lyrics.py
2014-12-18 10:36:16 +00:00
Adrian Sampson
20db9bb1a6 lyrics: Connect force option to CLI (#1150) 2014-12-18 04:03:15 +00:00
Fabrice Laporte
544d6dbe47 lyrics: add 'force' option 2014-12-17 22:40:44 +01:00
Fabrice Laporte
474adffe63 move helper functions from utils to plugins 2014-12-17 22:00:00 +01:00
Fabrice Laporte
9d0ca15ace lyrics: preserve default order of sources 2014-12-17 01:05:58 +01:00
Fabrice Laporte
e7a4b92de5 lyrics: add 'sources' option 2014-12-17 00:42:11 +01:00
Fabrice Laporte
0f2f43ca9b lyrics: add musixmatch source 2014-12-17 00:41:21 +01:00
Adrian Sampson
c2184be679 Merge branch '1060_ft_lang_support' 2014-12-16 11:53:59 +00:00
Adrian Sampson
a984c1aa44 Use a non-capturing group by default (#1060)
Now clients don't have to decide whether they need parentheses or not.
2014-12-16 11:37:40 +00:00
Fabrice Laporte
829b623665 remove capturing parentheses 2014-12-15 22:48:01 +01:00
Fabrice Laporte
b62f15d9d9 feat_tokens: change argument name, fix regex flag 2014-12-14 22:46:51 +01:00
Fabrice Laporte
91a998df3c fix #1060 2014-12-13 23:34:50 +01:00
Adrian Sampson
9ce956d648 Accuracy in variable naming (#1138)
That's a Query object, not a string.
2014-12-12 15:41:49 -08:00
David Logie
c09745f75c Remove unused dbcore import. 2014-12-12 23:06:15 +00:00
David Logie
11c60ce101 smartplaylist: Respect sort terms in queries. 2014-12-12 14:38:35 +00:00
Adrian Sampson
165ee80f81 lyrics: Handle requests exceptions (#1136) 2014-12-11 16:03:49 -08:00
Fabrice Laporte
d31a7c6b28 remove str decoding as input sources are unicode 2014-12-11 00:14:43 +01:00
Fabrice Laporte
321f862f23 fix #1135 2014-12-09 23:37:42 +01:00
Adrian Sampson
1448eab642 Parenetheses-less tuples 2014-12-02 18:12:21 -08:00
Thomas Scholtes
66b81ed081 echonest: test conversion failure 2014-12-02 11:54:36 +01:00
Thomas Scholtes
c248a71494 echonest: mock convert and truncate commands 2014-12-02 11:51:18 +01:00
Thomas Scholtes
f4fdd66b81 echonest: truncating a file converts it to OGG
Previously ffmpeg would throw an error because the file extension is
'.ogg' but the codec is 'copy'.
2014-12-02 11:15:46 +01:00
Thomas Scholtes
5633f50f27 echonest: extract logic into prepare_upload method
Also fixes a bug where both converting and truncating would leave a
temporary file.
2014-12-02 09:58:56 +01:00
Adrian Sampson
c41b8acf82 Merge pull request #1129 from geigerzaehler/zero-images
zero: Can delete embedded images

Conflicts:
	docs/changelog.rst
2014-12-01 11:40:48 -08:00
Adrian Sampson
d97b90d363 Merge branch 'master' of github.com:sampsyo/beets 2014-12-01 11:28:57 -08:00
Thomas Scholtes
17117ed4ae echonest: Remove temporary files
Fixes #979.
2014-12-01 17:53:14 +01:00
Thomas Scholtes
e2b2a505fc zero: Can delete embedded images
Fixes #1100.
2014-12-01 17:33:45 +01:00
Thomas Scholtes
9d3729dc5e mediafile: Test deleting images and implement it for MP3s 2014-12-01 17:20:16 +01:00
Adrian Sampson
5fb4003ebe echonest: Fix #896 (handle missing duration) 2014-11-30 12:21:27 -08:00
Adrian Sampson
7c08830113 Remove Echo Nest fingerprinting (fix #1121) 2014-11-30 12:18:43 -08:00
Adrian Sampson
5d37f9a2f0 Remove echonest_tempo (fix #1119) 2014-11-30 12:03:28 -08:00
Adrian Sampson
fe655e4610 discogs: Only authenticate on import (#1123)
No need to authenticate for other commands.
2014-11-30 11:18:32 -08:00
Marvin Steadfast
77f8eff78c Fixed python 2.6 compatibility in the plexupdate plugin. Added requests as dependency in the docs for plexupdate 2014-11-28 14:08:11 +01:00
Marvin Steadfast
b25393151d Added plexupdate plugin for refreshing plex music library after importing music. 2014-11-28 11:19:17 +01:00
Marvin Steadfast
d3b76d83d2 Permissions plugins listens now for album_imported and item_imported 2014-11-24 18:41:50 +01:00
Adrian Sampson
d026e7742b fetchart: Tolerate itunes bugs (fix #1109) 2014-11-22 15:32:52 -08:00
Marvin Steadfast
f8b3b96ff4 the plugin now listens also for item_moved 2014-11-21 14:58:33 +01:00
Marvin Steadfast
8784e8d8ca plugin now listens for item_copied instead of after_write. now the test works 2014-11-20 11:40:02 +01:00
Marvin Steadfast
38c509b092 created a function to convert permissions to oct 2014-11-19 17:26:39 +01:00
Marvin Steadfast
5f03185bdd did even more refactoring with the suggestions of sampsyo. added documentation page 2014-11-18 13:45:55 +01:00
Marvin Steadfast
df1136756a a little refactoring 2014-11-17 16:29:54 +01:00
Marvin Steadfast
e1db3e9f0b Added fix_permissions plugin 2014-11-17 13:42:53 +01:00
Alberto Leal
5883ee0b76 Default value for link title for page searches.
Google API may not return results with a title attribute.
2014-11-16 16:11:25 -05:00
Adrian Sampson
590b106ed0 echonest: Fix #1096: log error on repeated error 2014-11-16 12:08:07 -08:00
Adrian Sampson
d8211f1d76 fetchart: Fix RG MBID field name (fix #1080) 2014-11-12 20:56:18 -08:00
Adrian Sampson
0d529bae16 Docs tweaks for #1078 2014-11-11 11:57:08 -08:00
Francesco Rubino
2a9064ee21 Fixed format of comments and docstrings. 2014-11-11 18:44:09 +00:00
Francesco Rubino
905d76efec Merged from upstream 2014-11-11 18:41:24 +00:00
Francesco Rubino
df1503e2ca Added comments/docstrings to the AudioToolsBackend in the replaygain plugin 2014-11-11 18:11:22 +00:00
Adrian Sampson
d3f0742276 Changelog, tweaks for fetchart sources (#1075) 2014-11-11 10:10:43 -08:00
Adrian Sampson
288fb0da4c Merge pull request #1075 from Kraymer/1066-fetchart_sources
fetchart: add 'sources' option
2014-11-11 10:04:45 -08:00
Adrian Sampson
91ad0d9f58 Merge pull request #1069 from Kraymer/1035_no_copyright
Remove licensed lyrics from tests resources
2014-11-11 09:58:54 -08:00
Fabrice Laporte
ef6d3efe6d fetchart: cover engines yield their results 2014-11-10 22:17:34 +01:00
Adrian Sampson
a2d763b745 Fix ftintitle auto permanence (#485)
Oops. Plugins need to store to the database.
2014-11-09 19:21:09 -08:00
Adrian Sampson
05d5edcd0e Quiet down logging in #1070
This looks mostly helpful for debugging but redundant with the ordinary
logging.
2014-11-09 18:41:54 -08:00
Adrian Sampson
7a9a77b906 Merge pull request #1070 from frubino/master
Added backed audiotools to replaygain module and updated documentation
2014-11-09 18:38:38 -08:00
Adrian Sampson
7e4a0f6211 play: Log a message when no output is produced 2014-11-09 14:23:43 -08:00
Fabrice Laporte
09bea52a41 fetchart: fix flake8 2014-11-09 20:55:53 +01:00
Fabrice Laporte
6170c3a179 fetchart: make test_art.py tests pass 2014-11-09 20:41:21 +01:00
Fabrice Laporte
4d9ce94426 fetchart: import itunes only if necessary 2014-11-09 20:40:45 +01:00
Francesco Rubino
be43f629bf Merge branch 'master' of https://github.com/sampsyo/beets
Conflicts:
	docs/plugins/replaygain.rst
2014-11-09 14:48:32 +00:00
Francesco Rubino
4bf17486eb Fixed line lengths, typo in documentation. 2014-11-09 10:29:46 +00:00
Fabrice Laporte
41d0f4d674 remove comment 2014-11-08 23:28:10 +01:00
Fabrice Laporte
1b694e569e fetchart: add 'sources' option
Fasten cover search by enabling engines selection and prioritisation.
2014-11-08 23:20:44 +01:00
Adrian Sampson
701ed2dae9 Limit result set sizes (fix #1068) 2014-11-08 08:32:31 -08:00
Adrian Sampson
a9981c1dc7 Comment about workaround in #1073 2014-11-07 19:51:38 -08:00
David
5480ceeaf8 Encode to ascii,not utf8.Replace missing chars 2014-11-07 20:46:35 -05:00
Francesco Rubino
8af5b0e6c3 Added backed audiotools to replaygain module and updated documentation 2014-11-07 18:14:56 +00:00
Fabrice Laporte
b143ad7e3e fix #1035 do scraping tests on mock data
don’t store scraped pages with licensed lyrics in repo
2014-11-06 22:10:15 +01:00
Adrian Sampson
fc6664455a fetchart: Move iTunes priority
I like the CAA as a first-priority search because the images are generally
high-quality and there's no metadata ambiguity (we always find the right
release if it's in the catalog).
2014-11-06 10:37:58 -08:00
kerobaros
899eab334b fetchart: add iTunes Store art source; depends on python-itunes 2014-11-05 13:38:39 -06:00
Adrian Sampson
0aeadebcea freedesktop (#1056): Make handler a method
This lets us use `self.config`. The previous version, which checked
`beets.config['auto']`, was looking in the wrong scope.
2014-11-02 21:01:31 -08:00
kerobaros
3516fb67eb Added docstring, copyright and license to plugin. 2014-11-02 22:41:03 -06:00
kerobaros
8daeb7d79e Fixed up config checking to make freedesktop plugin pass flake8. 2014-11-02 22:35:40 -06:00
kerobaros
6ca34632de fd plugin now runs on album_imported hook. also logs when album has no art. 2014-11-02 22:05:37 -06:00
kerobaros
418e7c0d12 Merge remote-tracking branch 'upstream/master' 2014-11-02 21:23:31 -06:00
Angel Alonso
ad9786ce81 convert: update documentation and add a trailing comma. 2014-11-02 10:58:46 +01:00
kerobaros
2d82aa85b5 Starting on freedesktop plugin. 2014-11-01 21:47:55 -05:00
Angel Alonso
94c268d17e convert: copy album art when copying or transcoding.
Only implemented to work when matching albums instead of tracks (-a option).
Disabled by default in the configuration of 'convert'.

fix indentation.

Fix Travis nagging over indentation (hopefully).

Finally pep8 conforming.
2014-11-01 19:09:33 +01:00
Adrian Sampson
683e1a278d Merge branch 'lastimport' 2014-10-30 22:48:14 -07:00
Adrian Sampson
50c7cf0f56 discogs: Fix #1049: intermittent trailing comma 2014-10-30 09:36:39 -07:00
Adrian Sampson
69b7d1f160 Changelog for #1036 (fix #1028) 2014-10-28 11:50:36 -07:00
Adrian Sampson
6d38d9faf4 Merge pull request #1036 from kerobaros/master
Re: issue #1028: "embedart: Resize images only once per album
2014-10-28 11:49:19 -07:00
Adrian Sampson
4f3cd65943 Fix #1045: whitespace-separated queries in web 2014-10-27 23:14:28 -07:00
kerobaros
3a56077b0c Fixed logic error, added a .get(bool). 2014-10-27 21:20:26 -05:00
Adrian Sampson
72db4af7f8 Fix #1041: play unicode logging crash 2014-10-27 09:24:59 -07:00
Thomas Scholtes
464f8cdc04 Types plugin: Field types for albums and documentation example 2014-10-27 10:54:21 +01:00
Adrian Sampson
eb35d7084a Save Discogs token (#1040) 2014-10-26 15:45:34 -07:00
Adrian Sampson
a8a5191cf5 discogs #1040: Standard API key, handle failure 2014-10-26 15:24:17 -07:00
Adrian Sampson
665b4ac50a lastimport: Declare play_count type
Now you can get the fanciness of the numeric field without configuring the
`types` plugin.
2014-10-26 15:06:48 -07:00
David
d9c9e06674 Add authentication to discogs plugin 2014-10-26 16:26:59 -04:00
David
edbb97bd09 Dropping unused argument 2014-10-25 16:16:32 -04:00
kerobaros
81b513c720 Merge remote-tracking branch 'upstream/master' 2014-10-24 23:41:56 -05:00
Adrian Sampson
9137b5c2f3 Fix another lyrics scraper regression (#1034)
Along with a test.
2014-10-24 20:08:32 -07:00
kerobaros
f782dfd376 I'll get used to this git thing one day. Cleaning up. 2014-10-24 21:36:30 -05:00
kerobaros
d06da6381f Updating to master to form a new PR. 2014-10-24 21:33:09 -05:00
Adrian Sampson
0325fe2225 lyrics: Remove script tags (fix #1034) 2014-10-24 17:33:11 -07:00
Adrian Sampson
0bf7cb8657 Merge pull request #1011 from Kraymer/ftintitle_auto
ftintitle: add 'auto' option
2014-10-24 17:16:42 -07:00
Adrian Sampson
a7b7e23436 Minor fixes for #1033 2014-10-24 16:46:55 -07:00
kerobaros
9a191baca4 Working on issue #1028, resize images only once per album. 2014-10-24 15:01:52 -05:00
kerobaros
ca431b0bf8 Seperated some code out from extract() into get_art(item). Cleaner and quicker way to check for embedded art. 2014-10-23 22:37:19 -05:00
kerobaros
7f37514bb9 Whoops, trailing space. Take 2. 2014-10-23 21:17:42 -05:00
kerobaros
9be753736b Slight style tweaks. 2014-10-23 21:13:30 -05:00
kerobaros
e06f492f91 Whoops, take two. 2014-10-23 15:31:38 -05:00
kerobaros
75b62b723f Added "ifempty" config to embedart plugin, re: issue 1020 2014-10-23 15:27:15 -05:00
Fabrice Laporte
343972f5d0 move metadata management in command function 2014-10-18 11:04:10 +02:00
Fabrice Laporte
ac57ef0e67 restore write argument for ft_in_title 2014-10-14 20:58:36 +02:00
Adrian Sampson
7754fe5a40 embedart: Fix logging during import (#1014)
Regression introduced in 2813cd26c1.
2014-10-14 09:42:11 -07:00
Fabrice Laporte
4884ae3c46 register import hook only if needed 2014-10-13 22:25:09 +02:00
Fabrice Laporte
740b510ed7 restoring ft_in_title implementation 2014-10-13 21:21:28 +02:00
Fabrice Laporte
cc6080fa21 ftintitle: add 'auto' option 2014-10-12 22:44:34 +02:00
Adrian Sampson
4a61ce7c6b Use shared Last.fm API key 2014-10-12 13:27:04 -07:00
Adrian Sampson
06cfd4c549 Use MatchQuery for mb_trackid lookup 2014-10-12 13:21:26 -07:00
Adrian Sampson
490f84fc34 Style fixes 2014-10-12 13:19:03 -07:00
Adrian Sampson
a07e20eaf8 Safer GET parameter formulation for AS URL 2014-10-12 13:11:58 -07:00
Adrian Sampson
d6266c2542 Add lastimport plugin by @rafi
From rafi/beets-lastimport at 72c199d599ee76f2a5fa366a032ad33491f2c82c.
2014-10-12 13:00:27 -07:00
Heinz Wiesinger
ec56f2bbd4 Make 'media' an item level field.
Releases can consist of discs of various media types, most typically
CD/DVD combo releases. Having the media value an album level field
forces all discs to be of the same type. Making it an item level
field instead seems to be the proper thing to do here.

Fixes #161
2014-10-12 12:21:13 +02:00
Adrian Sampson
9e3a737b06 Merge pull request #1008 from otakucode/master
Added handler for requests.exceptions.ConnectionError to discogs plugin.
2014-10-11 22:11:01 -07:00
Adrian Sampson
434280f248 A couple of coverage tweaks 2014-10-11 22:05:22 -07:00