J0J0 T
b609047d64
discogs: Add extract_release_id_regex sanity check
...
Check whether any input worth pattern checking was passed.
2022-03-04 08:17:49 +01:00
J0J0 T
76e81199b5
discogs: Changelog entry for #4303 Fix discogs_albumid..
2022-03-04 08:17:49 +01:00
J0J0 T
c9c1123756
discogs: Fix discogs_albumid extraction
...
Use extract_release_id_regex instead of extract_release_id to get the
release ID out ouf the Discogs release URL.
2022-03-04 08:17:49 +01:00
Adrian Sampson
1bc00105bd
Merge pull request #4304 from jdheyburn/jdheyburn-feat-discogs-append-style-to-genre
...
feat: discogs: allow style to be appended to genre
2022-03-03 11:17:40 +01:00
Adrian Sampson
e1d19c3a3f
Docs refinement
2022-03-03 11:17:07 +01:00
Joseph Heyburn
4bde4d082d
discogs: allow style to be appended to genre
...
- Added more verbose documentation to `append_style_genre`
- Refactor based on code review
2022-03-03 10:03:31 +00:00
Joseph Heyburn
55e4917df3
discogs: allow style to be appended to genre
...
- Adds a configuration that, when enabled, will append the style to genre
- Rationale is to have more verbose genres in genre tag of players that only support genre
2022-03-02 22:04:36 +00:00
Adrian Sampson
bd7793211c
Merge pull request #4299 from Neurrone/fix/dont-deduplicate-results-when-musicbrainz-id-is-not-set
...
fix: dont deduplicate matches if musicbrainz ID is not set for album matches
2022-02-27 14:02:27 -05:00
Adrian Sampson
5e057078a6
Slight rewording
2022-02-27 14:01:48 -05:00
Dickson
6d6bb51fde
Update changelog
2022-02-27 13:28:17 +08:00
Dickson
8e40473453
fix: dont deduplicate matches if musicbrainz ID is not set for album candidates
2022-02-26 21:15:28 +08:00
Adrian Sampson
5f45e9e108
Tiny wording tweaks for #4281
2022-02-16 16:34:38 -05:00
Adrian Sampson
5a96037853
Merge pull request #4281 from jaimeMF/fish-completion-output
...
fish plugin: Add --output option
2022-02-16 16:33:14 -05:00
Jaime Marquínez Ferrándiz
8e921e4d74
fish plugin: Style fix
...
Co-authored-by: Adrian Sampson <adrian@radbox.org>
2022-02-16 21:51:19 +01:00
Jaime Marquínez Ferrándiz
fedb8b0b8f
fish plugin: Assign the default output path to the option instead of using None
2022-02-16 21:42:08 +01:00
Jaime Marquínez Ferrándiz
b46b4d2045
fish plugin: Simplify directory creation
2022-02-16 21:34:24 +01:00
Jaime Marquínez Ferrándiz
40fcb25221
fish plugin: Split long line
2022-02-16 08:15:30 +01:00
Jaime Marquínez Ferrándiz
8e5156d01c
fish plugin: Add --output option
2022-02-15 23:11:30 +01:00
Benedikt
6d401343e8
Merge pull request #4275 from wisp3rwind/pr_art_comp_v2
...
Fix embedart with compare_threshold on ImageMagick 7
2022-02-15 22:45:39 +01:00
wisp3rwind
1815d08392
artresizer: fix image comparison test
...
Since the ImageMagick based comparison is now abstracted via ArtResizer,
it becomes a little more involved to mock it for testing.
2022-02-14 22:52:00 +01:00
wisp3rwind
959e24e463
artresizer: whitespace fixes
2022-02-12 23:35:13 +01:00
wisp3rwind
f558c091b4
update changelog
2022-02-12 23:35:13 +01:00
wisp3rwind
8235af9770
art: log errors more explicitly, add some comments
...
error handling was previously implicit in the
`if not check_art_similarity(...)`
check, which is pretty unintuitive
2022-02-12 23:35:13 +01:00
wisp3rwind
03ce35f4d3
art: whitespace/comment improvements
2022-02-12 23:10:22 +01:00
wisp3rwind
2fa37aa22b
artresizer: return None explicitly
...
`None` is used both as a marker when errors occured, and when a function
is not implemented by the backend. That is already confusing enough
without there being implicit `None` return values when falling of the
tail of a method
2022-02-12 22:59:52 +01:00
wisp3rwind
fa967f3efc
artresizer: add a comment
2022-02-12 22:59:25 +01:00
wisp3rwind
0125b1cd42
artresizer: in backends, always use the appropriate ArtResizer instance
...
This didn't cause any issues since we only use the shared instance
anyway, but logically it doesn't make a lot of sense for the backends
always using ArtResizer.shared (which they should be oblivious of).
2022-02-12 22:45:22 +01:00
wisp3rwind
8ca19de6bc
artresizer: switch ImageMagick compare commmand depending on IM version
...
similar to other commands
Fixes #4272
2022-02-12 22:45:22 +01:00
wisp3rwind
a17a5f2fa6
art: move the backend-specific code to util.artresizer
...
all the other backend-specific code is already there.
2022-02-12 22:45:19 +01:00
wisp3rwind
890662f93d
artresizer: don't manually cache can_compare
...
it's only computed once on startup anyway (see the embedart plugin,
which is the only user)
2022-02-12 17:41:47 +01:00
wisp3rwind
497b916062
artresizer: import *path helpers directly
...
shortens lines a bit, and should pose no problem for understanding the
code given the prevalence of these functions in our code
2022-02-12 17:35:18 +01:00
Adrian Sampson
d0a5f812fd
Merge pull request #4273 from afontenot/embed-art-maxsize
...
Resize album art when embedding (convert plugin)
2022-02-10 11:35:49 -05:00
Adam Fontenot
07eb26f276
Resize album art when embedding (convert plugin)
...
Fixes #2116
2022-02-09 23:52:21 -08:00
Adrian Sampson
debbe4efa5
Merge pull request #4263 from wisp3rwind/pr_better_deprecation_warning
...
confit: Improve deprecation warning
2022-02-02 10:38:46 -05:00
Adrian Sampson
85ec22ba16
Merge pull request #4264 from wisp3rwind/pr_fix_reraise_again
...
test_replaygain: fix exception handling again
2022-02-02 10:32:58 -05:00
wisp3rwind
ef59465869
test_replaygain: fix exception handling again
...
This is the same as d26b0bc1
2022-02-01 21:39:42 +01:00
wisp3rwind
cc8c3529fb
confit: Improve deprecation warning
...
Show the actual origin of the import statement, cf. #4024
2022-02-01 19:10:24 +01:00
Benedikt
b37ef0e496
Merge pull request #4262 from wisp3rwind/pr_lyrics_tests
...
Improve lyrics tests
2022-02-01 18:59:19 +01:00
wisp3rwind
0cc4521372
tests: allow passing the INTEGRATION_TEST variable from the commandline
...
this allows to run
INTEGRATION_TEST=1 tox -e <env> test/test_<module>.py
which is very useful when testing locally. Otherwise, tox will clean the
environment, such that INTEGRATION_TEST will not be passed to the test
runner.
2022-01-31 21:07:28 +01:00
wisp3rwind
c86d5d0264
lyrics: Rework lyrics assertions for more useful output on failure
...
Uses a custom assertion to have more detailed output (which should help
with getting an idea what the difference between expected and actual
lyrics is), and use `subTest` to clearly associate test failure to a
backend.
In addition, this strip parenthesis from the lyrics' words. That helps
with the currently failing Tekstowo test, but doesn't entirely fix it.
Requires Python 3.4 for subTest.
2022-01-31 21:07:28 +01:00
Adrian Sampson
51e478ed1d
Merge pull request #4259 from mklein-de/zsh-complete-convert-destination
...
zsh completion: handle destination for "convert"
2022-01-30 16:35:13 -05:00
Michael Klein
a903e6649a
zsh completion: handle destination for "convert"
...
Use directory name completion for -d/--dest option.
2022-01-30 18:22:42 +01:00
Benedikt
10338c2a60
Merge pull request #4258 from beetbox/rectify-4226
...
convert: Revert some recent changes to convert-on-import path
2022-01-30 11:30:48 +01:00
Adrian Sampson
2b51b2443b
Remove a relevant test
2022-01-29 18:35:36 -05:00
Adrian Sampson
0788197c76
Remove a relevant changelog entry
2022-01-29 18:33:10 -05:00
Adrian Sampson
088cdfe995
Revert some of #4226
...
Rectify a couple of things in that PR, pointed out here:
https://github.com/beetbox/beets/pull/4226#issuecomment-1011499620
- Undo the `pretend` sensitivity in the import path, because it's not
clear how this setting could ever be true.
- Preserve the log message in debug mode, even when quiet.
2022-01-29 18:31:48 -05:00
Adrian Sampson
19e4f41a72
Merge pull request #4251 from rcrowell/query_prefixes
...
Add query prefixes :~ and :=
2022-01-26 07:51:23 -05:00
Rob Crowell
2cab2d670a
Fix bug in StringQuery.string_match
2022-01-25 16:24:04 -08:00
Rob Crowell
6457532274
Add query prefixes :~ and :=
2022-01-24 19:19:48 -08:00
Benedikt
404229b845
Merge pull request #3996 from wisp3rwind/pr_rg_restructure
...
Refactoring of the replaygain plugin
2022-01-22 14:45:30 +01:00
