euri10
b2fd274e2c
Added a missing switch to the fetchart command so that only missing albums
...
are displayed
2017-09-05 16:34:26 +02:00
Adrian Sampson
34246a00e7
Fix #2673 : JSON file encoding in absubmit
...
First, it's best to open the file as binary so the JSON module itself
can figure out how to decode it (it will just use UTF-8). Then, we can
use `load` instead of `loads` to avoid needing to read the file
explicitly ourselves.
2017-08-27 10:20:36 -04:00
Adrian Sampson
015aee3662
Fix #2671 : missing syspath on acoustid call
2017-08-26 11:18:27 -04:00
wordofglass
8833fef249
Merge pull request #2668 from wordofglass/edit_logic
...
Edit plugin logic: Regression from previous PR; incorrect diffs
2017-08-25 15:52:40 +02:00
wordofglass
7f12cc0c88
edit, Model.copy: documentation improvements
2017-08-25 15:47:07 +02:00
wordofglass
aa19577464
Merge pull request #2667 from wordofglass/mtime_fixes
...
Mtime fixes
2017-08-25 15:38:44 +02:00
wordofglass
f8a38bd527
Merge branch 'master' into mtime_fixes
2017-08-25 15:38:18 +02:00
wordofglass
024689e781
Changelog entry for the mtime fixes
2017-08-25 15:34:16 +02:00
wordofglass
5f21bd3ccd
test_edit: Add a test for retagging.
2017-08-24 15:03:18 +02:00
wordofglass
352d99cccd
edit: Do not deepcopy objects, finally fixes the regression from #2659
...
Deepcopying fails if a database is attached as Model._db since the
sqlite connection objects it contains are non-copyable
2017-08-24 15:03:18 +02:00
wordofglass
a9a2276774
Implement beets.dbcore.db.Model.copy()
2017-08-24 15:03:01 +02:00
wordofglass
33f7e67943
edit: Fix a regression from #2659 when re-tagging albums
2017-08-24 13:40:50 +02:00
wordofglass
989845199b
edit: Correctly reset the old object, do not reload it from the tags
...
Previously, if continuing to edit (i.e. invoking the $EDITOR) multiple
times in one invocation of EditPlugin.edit_objects, the plugin would
reload the old state from the file tags. The initial 'old state' is
usually only loaded from the database, though. As a consequence, if
database and tags were not in sync, the diffs from first and all
subsequent edits could differ unexpectedly.
2017-08-24 13:40:35 +02:00
wordofglass
c4fb2d1955
Item: Do not reset the mtime in __setitem__ unless the value actually changes
...
Unbreaks the remaining edit plugin tests.
2017-08-22 23:34:35 +02:00
wordofglass
b903b44a0c
test_edit: Fix test that intended to change one item but affected two.
...
This didn't manifest as a testing failure since the plugin (mostly
silently) drops id changes.
2017-08-22 23:34:35 +02:00
wordofglass
c811102eb2
test_edit: Expect mtime to change, unbreaks the multiple-item tests.
2017-08-22 23:34:06 +02:00
wordofglass
18c82cab5f
test_edit: Add a comment explaining why I didn't change the writing behaviour
...
I was midway through writing a test when realizing that it's best
the way it is...
2017-08-22 23:24:33 +02:00
wordofglass
7d4627bb8f
Ensure mtime is non-zero for Items in test fixtures.
...
mtime == 0 is the "this Item contains newer metadata than the file's
tags" marker. Setting this to something else than 0 emulates the state
of Items freshly read from the database.
Breaks 4 of the edit plugin tests.
2017-08-22 23:24:33 +02:00
Adrian Sampson
d87c73efb3
Merge pull request #2662 from natezb/master
...
Fix kodiupdate URL and add better error reporting
2017-08-22 12:59:19 -04:00
Nate Bogdanowicz
9d01ba0af2
Add changelog entry for #2662
2017-08-22 09:56:57 -07:00
Adrian Sampson
e983929e52
Fix a ReST syntax error
2017-08-21 14:30:12 -04:00
Adrian Sampson
2b31b493a6
Refine docs for #2663
2017-08-21 14:29:34 -04:00
Adrian Sampson
40a53513bc
Merge pull request #2663 from tigranl/patch-1
...
Update gmusic.rst
2017-08-21 14:26:30 -04:00
Tigran Kostandyan
bfdcbe2aac
Update gmusic.rst
2017-08-21 11:38:11 +03:00
wordofglass
695c706ae0
Merge pull request #2659 from wordofglass/master
...
Fix the edit plugin displaying bogus data or even crashing on re-imports
2017-08-21 00:36:14 +02:00
wordofglass
109b547f7a
Changelog entry for the edit plugin bugfix
2017-08-21 00:32:46 +02:00
wordofglass
df479d686d
Fix the edit plugin displaying bogus data or even crashing on re-imports
2017-08-21 00:32:03 +02:00
Nate Bogdanowicz
f5dbb7b0c5
Make error handling and logging more detailed
2017-08-20 14:51:03 -07:00
Nate Bogdanowicz
7eb9913391
Fix kodi url
2017-08-20 13:14:48 -07:00
Adrian Sampson
51961bbba2
gmusic: Use Unicode literals ( #2660 )
2017-08-20 13:03:40 -04:00
Adrian Sampson
c89186afac
Changelog for #2467/#2658
2017-08-20 12:52:54 -04:00
David Logie
f909f092fc
Fix importfeeds plugin on Python 3.
2017-08-12 16:45:13 +01:00
Adrian Sampson
598c965b0f
Simplify text for #2653
2017-08-11 14:35:22 -04:00
Adrian Sampson
4fa0827153
Merge pull request #2653 from plittlefield/patch-1
...
Update zero.rst
2017-08-11 14:33:40 -04:00
plittlefield
9e2a71eec3
Update zero.rst
2017-08-11 16:12:29 +01:00
Nathan Dwek
6160fa8851
Merge pull request #2631 from beetbox/Fix-2622
...
Do not warn about a BrokenPipeError we do consider - Fix #2622
2017-07-22 10:49:11 +02:00
Adrian Sampson
c06eca7e58
Merge pull request #2634 from anarcat/musixmatch-block-detect
...
lyrics: detect MusixMatch blocking
2017-07-18 17:13:31 -04:00
Adrian Sampson
6e1d0a8f54
Merge pull request #2633 from anarcat/lyrics-html
...
improvements and fixes to the lyrics RST rendering
2017-07-18 17:08:14 -04:00
Antoine Beaupré
a17974a152
add changelog entry for #2634
2017-07-18 16:36:40 -04:00
Antoine Beaupré
5ef68783a8
strip trailing and leading extra dashes
...
those are introduced if non-word characters are found, and are ugly
2017-07-18 16:33:22 -04:00
Antoine Beaupré
914dba4152
add tests for slug function, failing
2017-07-18 16:32:47 -04:00
Antoine Beaupré
b4b5473093
add pointer to slugify in slug
2017-07-18 16:14:10 -04:00
Antoine Beaupré
a8afabea80
move slug utility function to top-level
...
it's a generic utility function that can be reused, there's nothing
class-specific about it.
2017-07-18 16:12:48 -04:00
Antoine Beaupré
5e8d17a4fc
lyrics: detect MusixMatch blocking
...
we just look for the bad string in the HTML. this has the downside
that we may consider songs that have those exact lyrics (you never
know, really) may trigger this warning as well and we would fail to
fetch those songs.
we also fail if lyrics contain another magic string that seems to come
up when you do fill in the CAPTCHA after being blocked.
2017-07-17 12:21:55 -04:00
Antoine Beaupré
458f3636f4
compare artists based on the slug
...
this is necessary because otherwise artists with different string
representations but the same slug would overwrite one another
this outlines more clearly the code duplication between the rst code
and the slugify function, something which can be fixed later.
2017-07-17 11:59:14 -04:00
Antoine Beaupré
9c36a41ea8
slight refactoring: strip album only once
2017-07-17 11:50:15 -04:00
Antoine Beaupré
9894e8752b
ignore trailing/leading whitespace when comparing artists
2017-07-17 11:49:35 -04:00
Antoine Beaupré
36f84bfedd
add missing trailing newline after lyrics block
...
this would yield a warning for every song
2017-07-17 11:44:06 -04:00
Adrian Sampson
b303d5beb0
Slightly more complete sentences in comments
2017-07-17 10:59:04 -04:00
Adrian Sampson
aefb1c4947
Merge pull request #2628 from anarcat/lyrics-html
...
print lyrics as HTML
2017-07-17 10:56:29 -04:00
