Thomas Scholtes
b2cb87aa6d
Add completion script template to dist
2014-03-26 14:38:21 +01:00
Adrian Sampson
d778443ea0
don't wrap standard errors during Mutagen save()
2014-03-25 22:44:15 -07:00
Adrian Sampson
05ebd6d28e
FileOperationError: also include the file path
...
This makes the errors fully self-descriptive, which simplifies logging them as
errors (you just have to `log.error(exc)` to get a reasonable message). We
also now handle these at the top level in case someone forgets to add a
handler. But in this case, we also send the full traceback to the debug log.
2014-03-25 22:41:28 -07:00
Adrian Sampson
3a26845f5e
FileOperationError: include underlying exception
...
A primitive form of Python 3's "exception chaining", which is what we really
want here. Someday...
2014-03-25 22:14:50 -07:00
Adrian Sampson
3c8decc487
some reorg/docs for FileOperationError
2014-03-24 22:37:15 -07:00
Thomas Scholtes
4a6e3f12f1
Made config.yaml link to config page
...
Cherry picked from e9d7e9469f#626
2014-03-24 17:59:22 +01:00
geigerzaehler
3ac2c7a1d7
Merge pull request #603 from geigerzaehler/write-exception-handling
...
Exception handling for item writes
2014-03-24 17:55:48 +01:00
Thomas Scholtes
86b2c215f2
Remove unused import
2014-03-24 17:55:36 +01:00
geigerzaehler
7cffaf4bb3
Merge pull request #625 from geigerzaehler/nose-capture-log
...
Use nose to capture logs during test
2014-03-24 17:43:16 +01:00
Thomas Scholtes
574903e986
Add FileOperationError and handling in item.write()
2014-03-24 14:22:27 +01:00
Thomas Scholtes
d21406dcb0
Use nose to capture logs during test
...
Set the loglevel of beets to `DEBUG` but capture all logging statements with
nose. The logs are only printed when a test fails. This gives us more
information when tests fail while being completely silent on success.
2014-03-23 21:12:08 +01:00
Adrian Sampson
553d5fb4ca
Merge pull request #624 from thomwiggers/patch-2
...
Removed gbeets
2014-03-23 07:46:44 -07:00
Thom Wiggers
a4c5c575b5
Removed gbeets
...
It's link only lead to a readme on GitHub, not to any code.
2014-03-23 13:13:35 +01:00
Adrian Sampson
99bbecf7f5
add a defensive assertion
2014-03-22 11:00:24 -07:00
Thomas Scholtes
85b16e4e3d
Remove unused code
2014-03-22 13:25:25 +01:00
Thomas Scholtes
a399f294e8
Handle exceptions in item.write and use plugin abort
2014-03-22 13:25:25 +01:00
Thomas Scholtes
a744e8ea59
Fix missing import
2014-03-22 13:25:25 +01:00
Thomas Scholtes
ddf5233daa
Add _item_write method and remove duplicate code
2014-03-22 13:25:25 +01:00
Thomas Scholtes
13cbcad581
Unify exception handling of item.write() in UI
...
Don’t abort the program when there is something wrong with the filesystem.
2014-03-22 13:25:25 +01:00
Thomas Scholtes
92061099fe
Add BeforeWriteError for plugins
...
The idea is that plugins may want to prevent beets from writing a file (for
example if an integrity check failed).
2014-03-22 13:25:25 +01:00
Adrian Sampson
810841ba5a
a couple new extremely basic FAQs
...
These are also very common questions from new users.
2014-03-21 18:04:35 -07:00
Adrian Sampson
882d2305c0
docs: emphasize that you create config.yaml
...
This is, shockingly, the #1 question I get asked. I hope this helps.
2014-03-21 17:55:18 -07:00
Adrian Sampson
ddddbbb919
some more thorough documentation for #614
2014-03-21 17:51:50 -07:00
Adrian Sampson
3b403937d6
Merge pull request #614 from asutherland/survive-bad-dates
...
Return 0 dates instead of throwing on bad dates.
2014-03-21 17:43:30 -07:00
Adrian Sampson
1fb2584a06
avoid crashes on Mutagen bugs in save() ( #622 )
2014-03-20 14:35:45 -07:00
yoasif
0a9b41d984
Fixing last commit
...
b843071100
2014-03-19 23:18:19 -04:00
yoasif
b843071100
Fixed "hacking" link to point to Developers section
2014-03-19 23:01:15 -04:00
brilnius
e1878b34e7
Merge pull request #618 from brilnius/fix615
...
lastgenre plugin: separator in genre lists can now be configured
2014-03-19 22:22:41 +01:00
Bruno Tournay
81b74151ca
Genre separator from config must be unicode string
2014-03-19 22:16:02 +01:00
Bruno Tournay
3348c0e3c2
Typo correction
2014-03-19 22:12:56 +01:00
Adrian Sampson
b0fd64662d
update docs for #619
2014-03-19 10:34:03 -07:00
Thomas Scholtes
51647e6514
Changelog for 0daea144e8
2014-03-19 17:30:15 +01:00
Thomas Scholtes
0daea144e8
Fix album import feed with slashes
...
Makes tests from f2da1922b28571216c7bc0eaa71f56a316dc0d5d pass.
Fixes #610 and supersedes #611 .
2014-03-19 17:26:11 +01:00
Thomas Scholtes
b131922b90
Add failing importfeed tests for albums with slashes
...
Isolates bug in #610
2014-03-19 17:26:11 +01:00
Adrian Sampson
5b42796eea
Merge pull request #619 from brilnius/fix324
...
Replace option: leading whitespaces are also removed by default
2014-03-18 23:22:45 -07:00
Bruno Tournay
41e7611ead
Replace option: leading whitespaces are also removed by default
2014-03-18 22:25:06 +01:00
Bruno Tournay
26abd603c8
Changelog for previous change (lastgenre separator)
2014-03-18 22:12:16 +01:00
Bruno Tournay
618708916b
Separator in genre lists can now be configured
2014-03-18 22:03:11 +01:00
Andrew Sutherland
e290f8dfad
Use _safe_cast to avoid dying on illegal dates.
2014-03-18 01:38:04 -04:00
Adrian Sampson
03fa8d809b
tests: properly install & restore some fixtures
...
Brought up while investigating #612 .
2014-03-15 12:30:06 -07:00
Adrian Sampson
5eb7b4204b
Merge pull request #612 from AgathaTheWitch/test_failures
...
Updated test_importer for Various Artists
2014-03-15 12:22:51 -07:00
Agatha
7f19194403
Updated test_importer for Various Artists
...
All py.test tests should pass now
2014-03-15 14:23:27 -04:00
Adrian Sampson
cc1780f328
changelog for #586
2014-03-14 09:50:41 -07:00
Pedro Silva
e8f6781fa0
fix #568 : ignore items with all keys null
2014-03-14 12:04:43 +01:00
Thomas Scholtes
e2718d792e
Prevent plugin classes from being loaded twice
2014-03-12 14:17:16 +01:00
Thomas Scholtes
2dc0e4998d
Determine StorageStyle from mutagen class
...
Further decouples MediaFile from MediaFiled and StorageStyle. The latter know
only has knowledge of mutagen.
2014-03-12 13:59:39 +01:00
Thomas Scholtes
41045ec33d
Remove tests for editing list of tags by reference
...
See discussion in #605
Commit 3000: Wooho
2014-03-12 13:35:49 +01:00
Adrian Sampson
c64e9ed789
MediaFile: remove out_type from StorageStyle
...
This eliminates a little bit of state redundancy in which StorageStyles needed
to know about their field's externally visible type. Now the MediaField itself
is *solely* responsible for external-type-related conversions; StorageStyles
need only worry about their *internal* types.
(I hope I didn't mess up any essential design decisions, @geigerzaehler.)
2014-03-11 22:09:22 -07:00
Thomas Scholtes
d091c7e5b4
Remove unused plugin configure method
2014-03-11 22:29:44 +01:00
Thomas Scholtes
4205d1a7b9
Plugins can change task.choice_flag in import_task_choice handler
2014-03-11 19:18:19 +01:00
