Commit graph

5543 commits

Author SHA1 Message Date
jmwatte
ab3bc356b2 updateMerge branch 'master' of https://github.com/sampsyo/beets into editor 2015-11-05 15:13:07 +01:00
Adrian Sampson
7d52fa72ae Fix #1699: Outdated API call
get_fields() was removed in 5420599839.
2015-11-04 20:25:17 -08:00
Adrian Sampson
19cf37263d Fix #1700: Tolerate missing Location in iTunes 2015-11-04 20:11:58 -08:00
Adrian Sampson
be49955884 metasync: More precise exception catching (#1700) 2015-11-04 20:07:49 -08:00
reiv
a7952b1b1d Merge pull request #1681 from sampsyo/314-reimport-art
Fix #314: Delete old album art during re-import
2015-11-04 18:46:45 +01:00
reiv
81a72f74c9 Merge branch 'master' into 314-reimport-art 2015-11-04 18:37:06 +01:00
reiv
e32dda78b8 Changelog for #1681 2015-11-04 18:33:52 +01:00
reiv
0ebc4c799d fetchart: in auto, ignore albums with art
When re-importing an album, we don't want fetchart to interfere
with any existing album art.
2015-11-04 15:08:42 +01:00
Adrian Sampson
a735a6b4a2 discogs: Better exception logging
Might have helped diagnose #1669 more easily.
2015-11-03 22:38:31 -08:00
Adrian Sampson
023a33ca31 Revert "Fix #1656, maybe: encode Discogs token strings"
This reverts commit f784cd1a22.
2015-11-03 22:29:33 -08:00
reiv
314dd0e6bc Update re-import test to leave no orphaned art
Make sure that when an album is re-imported and its files are
moved, the artwork isn't left behind in the old folder.
2015-11-03 23:10:01 +01:00
reiv
32934bd16a Preserve album art on re-import (fixes #314)
Copy the replaced album's artpath attribute to the new album. This
causes the image file to be moved along with the music files.
2015-11-03 22:43:05 +01:00
reiv
21f926fb89 Add test for #314
Ensure that album art is preserved when an album is re-imported.
2015-11-03 22:38:13 +01:00
jmwatte
00b21dfa51 Merge branch 'editor' of https://github.com/jmwatte/beets into editor 2015-11-03 13:59:38 +01:00
jmwatte
2d77861e4d renamed and updated editplugin 2015-11-03 13:55:08 +01:00
reiv
33ea9f1c10 Revert all changes on this branch thus far
Revert "PEP8 amendments"

This reverts commit 413fe6bbfd.

Revert "Importer: Delete orphaned album art on..."

This reverts commit 629a80a1d1.
2015-11-03 11:33:35 +01:00
Adrian Sampson
38edb18a74 Merge pull request #1683 from sampsyo/1264-unnecessary-resize
Fix #1264: Avoid unnecessary art resizes
2015-11-02 22:39:06 -08:00
reiv
1625dfc17e Merge branch 'master' into 1264-unnecessary-resize 2015-11-03 02:46:33 +01:00
reiv
5d0048c03d Changelog for #1683 2015-11-03 02:38:02 +01:00
reiv
19dcc25a93 fetchart: Improve validation of image dimensions
This avoids images being resized unnecessarily if the dimensions
are correct.
2015-11-03 02:19:47 +01:00
reiv
93009911e0 fetchart: Add test for image resizing
This test ensures that images are resized if and only if they are
wider than the maxwidth setting.
2015-11-03 02:17:21 +01:00
Adrian Sampson
bfa2fbf6af Changelog for #1675 2015-11-02 16:46:32 -08:00
Adrian Sampson
d79d11fb15 Docstring and rewrap for #1675 2015-11-02 16:45:45 -08:00
Adrian Sampson
e84414c822 Fix syntax (and unused variable) in #1675 2015-11-02 16:44:02 -08:00
Adrian Sampson
efcea9a57f Merge pull request #1675 from kooimens/patch-1
Embedart: remove_art_file on import
2015-11-02 16:42:59 -08:00
jmwatte
f0040370ec Update yamleditor.rst
polishing
2015-11-02 23:57:11 +01:00
kooimens
bcef3a7123 Create function remove_artfile
Damn it, that was really hard for me:D. First time seriously using python. Please review it carefuly.
2015-11-02 23:56:38 +01:00
Adrian Sampson
69b0ae9745 Add an FAQ about changing music directories 2015-11-02 14:40:00 -08:00
jmwatte
3741e28947 Update yamleditor.rst
polishing
2015-11-02 23:23:57 +01:00
jmwatte
fdbf9e59e7 Update yamleditor.py
polishing
2015-11-02 23:11:42 +01:00
jmwatte
149dd8676a Update yamleditor.rst
polishing
2015-11-02 23:09:50 +01:00
jmwatte
151c1f3fbd Update yamleditor.rst
polishing
2015-11-02 23:00:02 +01:00
jmwatte
a3ee1d0d37 Update yamleditor.rst
more polishing
2015-11-02 22:21:03 +01:00
jmwatte
e3e8150277 Update yamleditor.rst
polishing
2015-11-02 22:07:59 +01:00
jmwatte
d5c9be44d4 Update changelog.rst 2015-11-02 22:02:20 +01:00
jmwatte
6c08aae3a4 Update changelog.rst
added yamleditor(a new plugin) entry
2015-11-02 21:42:58 +01:00
jmwatte
fe012eae77 new plugin yamleditor 2015-11-02 21:13:58 +01:00
Adrian Sampson
a18506f471 Fix #1686: thumbnails using unicode paths 2015-11-02 11:03:43 -08:00
reiv
f891184f0a Merge pull request #1682 from sampsyo/1126-deleted-art
Fix #1126: Check if album art file actually exists
2015-11-02 03:07:06 +01:00
reiv
db08896d8c fetchart: add docstring to helper function
_is_valid_image_candidate() now has three different return values.
These are documented here.
2015-11-02 03:04:45 +01:00
reiv
b76597bc43 Changelog for #1126 2015-11-02 02:36:15 +01:00
reiv
d0cfb3e990 fetchart: add test for re-fetching deleted art
This test addresses #1126.
2015-11-02 02:20:09 +01:00
reiv
9182fd8f04 PEP8 amendments 2015-11-01 16:20:48 -08:00
reiv
3250fa80ae fetchart: Only resize when necessary
Fixes #1264: When a re-import triggers fetchart, the existing album art is no
longer resized if it already has the correct dimensions. This avoids creating
new album art files with unique filenames ("cover.n.jpg").
2015-11-01 16:20:18 -08:00
reiv
269d0e5403 fetchart: Check if album art file actually exists
Fixes #1126.
2015-11-01 16:14:51 -08:00
reiv
413fe6bbfd PEP8 amendments 2015-11-01 16:12:25 -08:00
reiv
629a80a1d1 Importer: Delete orphaned album art on re-imports
First step towards fixing #314.
2015-11-01 16:10:56 -08:00
Adrian Sampson
c617033476 convert: Add some comments 2015-11-01 11:01:40 -08:00
Adrian Sampson
5f5a8946c3 convert: Debug log when embedding images
To help diagnose #1671.
2015-10-30 15:25:01 -04:00
kooimens
0257b1077f Simplify some code 2015-10-30 17:49:57 +01:00