Commit graph

7983 commits

Author SHA1 Message Date
Adrian Sampson
e39b6bd3fe Fix in-package version number (fix #2086) 2016-06-28 10:10:03 -07:00
Christoph Reiter
629241efd3 mediafile: Cleanup mutagen error handling
Instead of the individial mutagen format exceptions use the
mutagen.MutagenError exception introduced in 1.25.

Since 1.33 mutagen will only raise MutagenError for load/save/delete
and no longer raise IOError. Translate both errors to UnreadableFileError
to support older and newer mutagen versions. Unify error handling
in __init__(), save() and delete().

Since it's no longer possible to get an IOError from MediaFile, adjust
all callers and tests accordingly.

This was tested with mutagen 1.27 and current mutagen master.
2016-06-28 16:43:34 +02:00
Christoph Reiter
45404bce85 mediafile: Add note about MPEGInfo.channels being available in newer mutagen versions 2016-06-28 16:43:34 +02:00
Christoph Reiter
9f16cfd078 mediafile: Remove alac detection workaround
No longer needed since we depend on mutagen 1.27
2016-06-28 16:43:34 +02:00
Christoph Reiter
3984febf6c mediafile: Add note to ASF.delete that it's fixed in newer mutagen 2016-06-28 16:43:34 +02:00
Adrian Sampson
2515f98dfc Merge pull request #2087 from lazka/fix-setup-py-test
tests: Fix setup.py test
2016-06-27 23:04:20 -07:00
Christoph Reiter
06072c5d7d tests: Fix setup.py test
test_hidden was missing suite() which made testall.suite() fail
2016-06-27 10:23:34 +02:00
Johnny Robeson
74aeb0edbc call is_alive() instead of isAlive() in pipeline 2016-06-26 21:47:49 -04:00
Johnny Robeson
33faa48516 fallthrough to shlex.split on py3 in shlex_split 2016-06-26 16:56:43 -04:00
Johnny Robeson
890102e114 explicitly cast g1, g2, and peak to int in _sc_encode
They seem to have been implicitly forced to int via `%X` format,
but with python 3.5 we must make it explicit.
2016-06-26 16:40:09 -04:00
Adrian Sampson
77a869d290 Merge pull request #2050 from maxammann/master
Add 'expand' flag to the web plugin
2016-06-26 11:21:34 -07:00
Max Ammann
cfd70c2685 Added changelog for beetbox/beets#2050 2016-06-26 20:01:48 +02:00
Max Ammann
5e8ac9e4a5 Expose the relative path to the library instead of omitting the 'path' variable 2016-06-26 19:53:57 +02:00
Max Ammann
2ae26548fc Modified and simplified is_expand(...) method 2016-06-26 19:53:57 +02:00
Max Ammann
619344c813 Added documentation for the expand parameter 2016-06-26 19:53:57 +02:00
Max Ammann
041adf47ac Fixed lines which are mor than 79 characters 2016-06-26 19:53:57 +02:00
Max Ammann
4be45eacc6 Added documentation for the new 'expand' flag 2016-06-26 19:53:57 +02:00
Max Ammann
5831b99b9f Adding 'expand' flag for json requests
This allows you to query the individual items of an album
2016-06-26 19:53:57 +02:00
Johnny Robeson
ce88a78de7 add a __bytes__ method to LibModel
this allows `test_album_and_item_format` in test_library to pass in py3
2016-06-26 04:06:29 -04:00
Adrian Sampson
a8b039da78 Remove a spurious six use
I'm not sure what that `encode` was doing anyway.
2016-06-25 19:24:59 -07:00
Adrian Sampson
5efd5b21c5 Use new as_str method
Instead of `get(six.text_type)`, which was a surprisingly large portion of our
uses of six.
2016-06-25 19:16:14 -07:00
Adrian Sampson
fa7b9999e7 Add as_str shortcut to Confuse 2016-06-25 19:06:01 -07:00
Adrian Sampson
c8816df9fd Walk back small change to Confit path types 2016-06-25 18:54:21 -07:00
Adrian Sampson
f63513c0e0 Simpler string type handling 2016-06-25 18:49:17 -07:00
Adrian Sampson
c9aeac8cca Sync up Confit/Confuse with external repo 2016-06-25 18:46:46 -07:00
Adrian Sampson
de62a59d35 Remove an unnecessary six.range use
Ordinary `range` works fine here.
2016-06-25 18:39:29 -07:00
Adrian Sampson
2e39c79440 Fix redundant six string reference in Confit 2016-06-25 18:32:15 -07:00
Adrian Sampson
e16cc58cb9 Walk back some six.iter* uses
In places where it doesn't much matter whether we use an iterator or the old
Python 2 list way, using the six name just hurts legibility.
2016-06-25 18:29:55 -07:00
Adrian Sampson
349a6e6c1d Fix an erroneous six usage in fuzzy 2016-06-25 18:11:15 -07:00
Adrian Sampson
736ad66518 Merge pull request #2066 from beetbox/use-six
Use the six package to handle py2/p3 compatibility
2016-06-25 18:09:56 -07:00
Adrian Sampson
2b289cd74c Fix setup.py comment about bpd dependencies 2016-06-25 18:04:03 -07:00
Adrian Sampson
035bf96558 Version bump: 1.3.20 2016-06-25 17:53:20 -07:00
Adrian Sampson
9d66e2c306 Add release date for 1.3.19 2016-06-25 17:52:32 -07:00
Adrian Sampson
6d619b67ab Clean up the changelog for release 2016-06-25 17:50:12 -07:00
Adrian Sampson
a7e91593a6 Meantion Beatport in README again 2016-06-25 17:44:13 -07:00
wordofglass
86ed8e9650 Merge pull request #2072 from beetbox/art_rectify_extension_via_imghdr
Rectify artwork extension via imghdr
2016-06-25 22:06:32 +02:00
wordofglass
7bf6554cdc fetchart: update changelog 2016-06-25 21:57:10 +02:00
wordofglass
2db1530ef8 fetchart: flake8 fixes 2016-06-25 21:55:55 +02:00
wordofglass
5d00ca8bda fetchart: do not unnecessarily reset Candidate.path on download failure 2016-06-25 14:10:55 +02:00
wordofglass
697291b04e fetchart: improve error resilience of the Content-Type detection by file magic 2016-06-25 14:10:50 +02:00
wordofglass
9968288358 fetchart: update comments 2016-06-25 13:49:15 +02:00
Johnny Robeson
a1ed78135c mark confit as_*() methods as shortcuts, not deprecated
Fixes #2026
2016-06-25 04:52:11 -04:00
Johnny Robeson
34074b530b check changed text on py >3.5 in RegexpQuery test
See https://bugs.python.org/issue22364 for details
2016-06-24 19:09:29 -04:00
Johnny Robeson
b6678019ea use @six.python_2_unicode_compatible 2016-06-24 05:53:56 -04:00
Johnny Robeson
364d32953e use buffer on py2, memoryview on py3
This wouldn't be necessary if the sqlite module accepted memoryview
instances on py2, but it doesn't.
2016-06-24 05:53:56 -04:00
Johnny Robeson
433ac368df check pull.__next__ on py3 in pipeline tests 2016-06-24 05:53:56 -04:00
Johnny Robeson
8c2809f75c only write StringIO encoding attr on py2 2016-06-24 05:53:56 -04:00
Johnny Robeson
78334876c3 treat HTMLParseError as a noop when missing
Strict mode no longer exists in html.parser on python >= 3.5, and no longer means anything on python >= 3.3
2016-06-24 05:53:56 -04:00
Johnny Robeson
6849ab874e skip pipeline test_constrainted_exception on PY3
This one would make every test run last until the timeout is reached, so
it's necessary skip it until the root cause is found.
2016-06-24 05:53:56 -04:00
Johnny Robeson
fd3f0b5159 disable compiled functemplates if not using PY2
The AST code needs rewritten for PY3. This is tracked in
https://github.com/beetbox/beets/issues/2058
2016-06-24 05:53:56 -04:00