Commit graph

3991 commits

Author SHA1 Message Date
Adrian Sampson
a07e20eaf8 Safer GET parameter formulation for AS URL 2014-10-12 13:11:58 -07:00
Adrian Sampson
d6266c2542 Add lastimport plugin by @rafi
From rafi/beets-lastimport at 72c199d599ee76f2a5fa366a032ad33491f2c82c.
2014-10-12 13:00:27 -07:00
Adrian Sampson
7da6f16052 Expand changelog for #161/#987 2014-10-12 12:46:50 -07:00
Heinz Wiesinger
ec56f2bbd4 Make 'media' an item level field.
Releases can consist of discs of various media types, most typically
CD/DVD combo releases. Having the media value an album level field
forces all discs to be of the same type. Making it an item level
field instead seems to be the proper thing to do here.

Fixes #161
2014-10-12 12:21:13 +02:00
Adrian Sampson
6667ca925d Changelog/thanks (fix #1004, #1008) 2014-10-11 22:12:06 -07:00
Adrian Sampson
9e3a737b06 Merge pull request #1008 from otakucode/master
Added handler for requests.exceptions.ConnectionError to discogs plugin.
2014-10-11 22:11:01 -07:00
Adrian Sampson
c1aa6d6c72 Remove configuration migration code
Finally.
2014-10-11 22:09:14 -07:00
Adrian Sampson
434280f248 A couple of coverage tweaks 2014-10-11 22:05:22 -07:00
Adrian Sampson
9531094f09 Travis: re-enable coverage
Use py27cov instead of py27.
2014-10-11 21:40:52 -07:00
Adrian Sampson
785f084ffc Travis: Require sphinx
Oops. Looks like we need sphinx to run setup.py sdist for tox builds.
2014-10-11 21:35:04 -07:00
Adrian Sampson
fd1817f406 Fiddling with Travis build
- verbose nose mode (easier to tell what's erroneously being skipped, fore
  example)
- less redundant installs
- travis_retry coveralls install
- separate py27cov tox environment; default tox runs will not use coverage,
  which can take a long time; use tox -e py27cov to get coverage numbers
2014-10-11 21:29:19 -07:00
Adrian Sampson
e949fe2d93 A bunch more tests for Results 2014-10-11 20:44:10 -07:00
Adrian Sampson
9d5fdbb37f Fix concurrent iterators in incremental results
Some weird behavior was possible when having two iterators on the same Results
object. May seem far-fetched, but it is possible. As an added bonus, this
saves a little memory by disposing of rows when they have been materialized
into model objects.
2014-10-11 20:30:33 -07:00
Dustin Rodriguez
020c96d99f Added handler for requests.exceptions.ConnectionError to discogs plugin. 2014-10-11 20:50:31 -04:00
Adrian Sampson
b777bde0af Fix #1006: errant info-level log
Introduced in e99df7bc65.
2014-10-11 15:05:01 -07:00
Adrian Sampson
0749d4716c duplicates: Fix #999 (check "checksum" type) 2014-10-11 12:28:41 -07:00
Adrian Sampson
61e43787d2 Second-order optimizations to Results getters
Fix #997. This provides shortcuts for len() and subscripting in certain
situations. There are of course more shortcuts that are possible, but this
will do for now!
2014-10-11 12:18:12 -07:00
Adrian Sampson
ea94ce5eef dbcore.Results: Avoid duplicate construction
Iterating over a results set multiple times should not take the same amount
each time. We now keep around the materialized objects and re-use them with
iteration. This solves a performance problem in the `play` plugin, which uses
len(results) multiple times and was therefore taking an unnecessary
performance hit when the query was slow.
2014-10-11 12:08:27 -07:00
Adrian Sampson
a2ce367c64 Simplify Results.__iter__
Deduplicate some copypasta from the sorting feature.
2014-10-11 11:47:22 -07:00
Fabrice Laporte
ee3f7b8c3e fix artresizer resize() method 2014-10-11 17:35:29 +02:00
Stig Inge Lea Bjørnsen
6f9abf4340 Merge pull request #925 from silb/bug-911-importadded-reimport
Fixes bug #911
2014-10-11 15:53:03 +02:00
Stig Inge Lea Bjørnsen
79a9593cb9 Add quoting and use displayable paths in log messages 2014-10-10 22:52:54 +02:00
Adrian Sampson
67b7b87d82 Fix #1001: plugin conflict error message printing 2014-10-10 10:55:40 -07:00
Adrian Sampson
dfb7cc25f5 Merge pull request #996 from benlumley/patch-1
Trivial typo fix
2014-10-10 09:32:59 -07:00
Ben Lumley
10d05a32be Trivial typo fix 2014-10-10 09:57:32 +01:00
Fabrice L.
e6bf8c21d8 Merge pull request #992 from KraYmer/lyrics-coverage
Improve lyrics coverage
2014-10-09 22:11:28 +02:00
Adrian Sampson
c5293df963 replaygain: More descriptive backend errors
This avoids a bare `except:` to catch specific errors and give better messages
when they fail. Should provide more insight to this trouble:
https://groups.google.com/d/msg/beets-users/6d-TOg0SuPY/iL39tmo3rqUJ

Also related to #874.

Feedback from @yevgenybezman or others more familiar with the backend would be
welcome.
2014-10-09 12:26:53 -07:00
Adrian Sampson
983aac287b Add a displayable_path call in embedart (fix #995) 2014-10-09 11:13:39 -07:00
Fabrice Laporte
4386d9d4df skip test involving bs4 if python version too low 2014-10-09 08:23:20 +02:00
Fabrice Laporte
a6f0649c40 return no lyrics when HtmlParseError occured 2014-10-09 08:22:51 +02:00
Fabrice L.
18ee57085d Merge pull request #993 from KraYmer/lastgenre_coverage
Lastgenre coverage (mocking galore)
2014-10-09 06:54:26 +02:00
Fabrice Laporte
b32838b519 fix flake8 2014-10-09 06:47:23 +02:00
Fabrice Laporte
2b908b48bc lastgenre: use an ordinary Item instead of a Mock 2014-10-09 06:38:40 +02:00
Fabrice Laporte
b95990ee9c lastgenre: add unit tests 2014-10-09 00:00:26 +02:00
Fabrice Laporte
546d17f52f fix flake8 2014-10-08 20:55:00 +02:00
Fabrice Laporte
4600727e17 fix building of lyrics file paths 2014-10-08 20:32:30 +02:00
Fabrice Laporte
edbbadaf4f add test to check lyrics title match in url title 2014-10-08 14:49:59 +02:00
Fabrice Laporte
c0c474b20f lyrics: strip title excerpt before matching
improve the extraction of lyrics title from url title and increase the
matching threshold as a consequence.
2014-10-08 14:49:09 +02:00
Fabrice Laporte
9992d65366 test_lyrics: add onelyrics.net source 2014-10-08 14:44:43 +02:00
Fabrice Laporte
f122e2a966 add bs4 dependency
and reorder reps list alphabetically for readability
2014-10-08 14:43:55 +02:00
Fabrice L.
cf6a15df95 revert 0f5c2a4 2014-10-08 14:27:13 +02:00
Fabrice L.
0f5c2a41b2 tox: add bs4 dependency
bs4 is required by few test_lyrics.py tests
2014-10-08 13:34:05 +02:00
Stig Inge Lea Bjørnsen
3bd3a817de Comply with PEP8. 2014-10-07 22:05:44 +02:00
Stig Inge Lea Bjørnsen
125f6422d7 Bug #911 reimport detection for the importadded plugin
Reimports are now detected by inspecting the fields for reimported items
and replaced albums in ImportTask.

Reimported albums and items are skipped.
2014-10-07 21:05:43 +02:00
Fabrice L.
abe7a2cd20 Update embedart.rst 2014-10-05 21:22:22 +02:00
Adrian Sampson
2b1353a4f1 Malformed date queries no longer crash 2014-10-04 16:50:50 -07:00
Adrian Sampson
44ff3f782a Remove prefix diff highlighting
This was well-intentioned but ended up being more confusing than it was worth.
It's always confused me when one digit gets un-highlighted in one of these
displays. The straw that broke the camel's back was when I got a "#1 -> #16"
change where the numeral "1" was un-highlighted. To fix this right would be
way more trouble than it's worth; I'm glad to be rid of this detail.

Conflicts:
	docs/changelog.rst
2014-10-04 16:47:00 -07:00
Lucas Duailibe
9b03c46702 play: removing tmp file (changelog) 2014-10-04 14:50:17 -03:00
Lucas Duailibe
17dbf2a22d play: remove temporary m3u file 2014-10-03 12:49:06 -03:00
Adrian Sampson
ae09f14615 Changelog for #985 2014-09-30 11:30:45 -07:00