Thomas Scholtes
650b49795b
Add keyfinder plugin
...
Closes #662 and #279 .
2014-04-12 18:44:38 +02:00
Thomas Scholtes
0f689d344a
Fix errors in key normalization
2014-04-12 17:51:22 +02:00
Thomas Scholtes
d014b802aa
Log debug message for configuration location
...
Helps with issues like #682 .
2014-04-12 17:08:17 +02:00
Thomas Scholtes
e5104784c6
Add captureStdout helper and mocks to some tests
2014-04-12 16:49:54 +02:00
Thomas Scholtes
65fcb8a28c
Allow CLI tests to use :memory: db
...
This significantly increases performance
2014-04-12 16:08:57 +02:00
Fabrice L.
8f43b38586
Update changelog.rst
2014-04-12 13:01:06 +02:00
Fabrice Laporte
8a66efd2e8
update changelog
2014-04-12 12:41:10 +02:00
Fabrice Laporte
9a32ed5864
add lyrics plugin unit tests file
2014-04-12 12:30:15 +02:00
Fabrice Laporte
42747797cd
better handling of songs with featuring artists, songs variants versions (live
...
etc), and songs combinations (lyrics are then appended)
2014-04-12 12:29:20 +02:00
Kyle Konrad
d044e1773a
Replace SingletonQuery with BooleanQuery on computed singleton field.
...
Updated use in command parsing and mbsync plugin.
2014-04-11 22:20:04 -07:00
Adrian Sampson
271a1627a5
mbsync: call album.save()
...
This must have been broken as long as album.save() was a necessary call (i.e.,
since the introduction of the dbcore base classes).
2014-04-11 19:50:13 -07:00
Thomas Scholtes
c01fc542ed
Support for initial_key with EchoNest
2014-04-11 21:03:11 +02:00
Thomas Scholtes
1670cb4565
Flake8 fixes
2014-04-11 16:05:08 +02:00
Thomas Scholtes
6705c123cf
Use helper for replaygain tests
2014-04-11 15:14:13 +02:00
Thomas Scholtes
75da27729c
Zero also tests deleting rg_track_gain
2014-04-11 15:12:47 +02:00
Thomas Scholtes
9c8b639644
{posargs} for tox
2014-04-11 15:10:59 +02:00
Thomas Scholtes
a09b092c78
Don't accidentaly delete fallback id3 frame
2014-04-11 15:10:35 +02:00
Thomas Scholtes
287428e805
Use only valid media files as fixtures
2014-04-11 00:06:59 +02:00
Adrian Sampson
6989d77a7a
"invalid MBID" messages are now debug logs ( #616 )
2014-04-10 14:46:26 -07:00
Adrian Sampson
ca6653fde8
Merge pull request #616 from krig/mbids
...
Log release ID for invalid MBIDs
2014-04-10 14:43:47 -07:00
Thomas Scholtes
7b954d9999
Remove null normalization for replaygain.
...
A `None` value for replagain fields is different from a `0.0` value [1].
[1]: https://github.com/sampsyo/beets/issues/157#issuecomment-39521322
2014-04-10 22:02:24 +02:00
Thomas Scholtes
c27d26ddbf
Refactor zero plugin
2014-04-10 22:01:04 +02:00
Adrian Sampson
b322e3dda7
fix Sphinx complaint
...
Apparently, the ReST syntax doesn't like letters appearing after a
`backticked` phrase. That's sorta annoying.
2014-04-10 11:51:21 -07:00
Adrian Sampson
6b0c03db9d
info: don't print out album art blobs
2014-04-10 11:50:59 -07:00
geigerzaehler
2be1bdeb1f
Merge pull request #660 from geigerzaehler/mediafile-delete-tags
...
Delete and handle nonexistant tags
2014-04-10 20:35:19 +02:00
Adrian Sampson
4c9daa12cc
Merge pull request #676 from geigerzaehler/item-try-write
...
Add item.try_write() to log errors
2014-04-10 11:33:06 -07:00
Adrian Sampson
b79a1199ad
remove stray ITEM_FIELDS reference ( #650 )
2014-04-10 11:31:51 -07:00
Adrian Sampson
33b44717ab
embedart: catch log errors ( fix #678 )
2014-04-10 11:24:59 -07:00
Thomas Scholtes
db7588021b
Move log handler to beets.ui
2014-04-10 17:47:49 +02:00
Thomas Scholtes
5d753b4f38
Remove ALBUM_* constants. Closes #650
2014-04-10 17:44:39 +02:00
Thomas Scholtes
f6f974ec87
Remove ITEM_* constants
...
We might consider renaming `Item._fields` to `Item.fields` since other parts of
beets use it as a replacement for `ITEM_KEYS`.
See also #650 .
2014-04-10 17:11:21 +02:00
Thomas Scholtes
883e3b3bc7
Flake8 fixes
2014-04-10 15:56:50 +02:00
Thomas Scholtes
c3ea1ded30
Add item.try_write() to log errors
...
Many commands and plugins use `item.write()` to update tags. Since the success
of the call is not critical to the functionality of most consumers we want to
catch any exceptions, log an error and continue with our task. The new method
encapsulates this logic.
This fixes #675 .
2014-04-10 15:26:05 +02:00
Thomas Scholtes
d44adea9d3
Delete 'None' properties from media file
2014-04-10 14:35:37 +02:00
Thomas Scholtes
90dbefabd3
flake8 fixes
2014-04-10 01:17:29 +02:00
Thomas Scholtes
52dc84f43a
Set literal not available in py26
2014-04-09 23:28:11 +02:00
Thomas Scholtes
a6839603cd
Return None for missing tags.
...
Instead of returning a special "None value" if a tag does not exist, we return
none directly.
2014-04-09 23:28:11 +02:00
Thomas Scholtes
a114b67974
Remove all tags from empty.wma
2014-04-09 23:28:11 +02:00
Thomas Scholtes
663d91c4b2
Delete tags from media files
2014-04-09 23:28:11 +02:00
Thomas Scholtes
9d9f1b539f
More robust tests for converted files
2014-04-09 20:41:58 +02:00
Thomas Scholtes
b7a26811ef
Add "shell" keyword for commands and use it in convert
...
Convert used to split the user command at whitespaces and pass it to `Popen`.
This approach is to naive, it also was not consistent with output from the
logs. Instead we pass the whole command to a subshell.
2014-04-09 20:41:30 +02:00
Thomas Scholtes
b9dca9b43e
Make flake8 mandatory on travis
...
The travis build will fail if flake8 finds errors. Since not all code is
cleaned yet we ignore a couple of files in `setup.cfg`.
We'll gradualy clean the code remove the excluded files from `setup.cfg`.
See #669 .
2014-04-09 19:20:01 +02:00
Thomas Scholtes
bc55747abc
More flake fixes
2014-04-09 19:16:38 +02:00
Thomas Scholtes
4a2f0d11b8
Flake fixes
2014-04-09 18:22:02 +02:00
Thomas Scholtes
b88319da05
type_index for mediafile images defaults to "other"
...
The `Image.type_index` property is only used for tags that require an integer
to store the cover type like ID3v2. If the type of an image is not set we let
`type_index` return the integer for an "other" image. Other than a default
"front" value, this makes sure we do not inadvertidly add an image that will
be displayed in a player.
2014-04-09 18:12:47 +02:00
Thomas Scholtes
d164d514d9
Remove tox's system site packages
2014-04-09 18:11:18 +02:00
Adrian Sampson
323be89d4d
fold OrderedEnum into autotag module
...
This puts the OrderedEnum generic class next to where it is actually used. It
also refers to the recipe it is taken from on docs.python.org. I also took the
opportunity to give this a capitalized name (since it's a proper type).
2014-04-08 17:10:50 -07:00
Adrian Sampson
443b8089d5
remove unnecessary IndexableEnum
...
This is not really critical since list(Type)[i] works just as well. This fixes
a couple other problems from the enum transition:
- The name of TYPES was not really consistent with its new role as an enum
type. Renamed this ImageType.
- Fix a rather egregious bug in embedart (undefined reference to Image).
2014-04-08 16:59:50 -07:00
Adrian Sampson
9ad5e323e4
changelog note for #642
2014-04-08 15:27:10 -07:00
Adrian Sampson
1eb6ccf0ab
Merge pull request #642 from ktkonrad/enum34
...
use the new python enum instead of hand-rolled version
2014-04-08 15:24:04 -07:00
