Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2025-12-15 04:55:10 +01:00
Code Issues Projects Releases Wiki Activity

type_index for mediafile images defaults to "other"

Browse source 
The `Image.type_index` property is only used for tags that require an integer
to store the cover type like ID3v2. If the type of an image is not set we let
`type_index` return the integer for an "other" image. Other than a default
"front" value, this makes sure we do not inadvertidly add an image that will
be displayed in a player.
This commit is contained in:
Thomas Scholtes 2014-04-09 18:04:29 +02:00
parent d164d514d9
commit b88319da05
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
beets/mediafile.py
View file

@ -335,7 +335,9 @@ class Image(object):
@property
def type_index(self):
if self.type is None:
return None
# This method is used when a tag format requires the type
# index to be set, so we return "other" as the default value.
return 0
return self.type.value
@ -788,7 +790,7 @@ class MP3ImageStorageStyle(ListStorageStyle, MP3StorageStyle):
frame.mime = image.mime_type
frame.desc = (image.desc or u'').encode('utf8')
frame.encoding = 3 # UTF-8 encoding of desc
frame.type = image.type_index or 3 # front cover
frame.type = image.type_index
return frame
@ -815,7 +817,7 @@ class ASFImageStorageStyle(ListStorageStyle):
def serialize(self, image):
pic = mutagen.asf.ASFByteArrayAttribute()
pic.value = _pack_asf_image(image.mime_type, image.data,
type=image.type_index or 3,
type=image.type_index,
description=image.desc or u'')
return pic
@ -863,7 +865,7 @@ class VorbisImageStorageStyle(ListStorageStyle):
"""
pic = mutagen.flac.Picture()
pic.data = image.data
pic.type = image.type_index or 3 # Front cover
pic.type = image.type_index
pic.mime = image.mime_type
pic.desc = image.desc or u''
return base64.b64encode(pic.write())
@ -896,7 +898,7 @@ class FlacImageStorageStyle(ListStorageStyle):
"""
pic = mutagen.flac.Picture()
pic.data = image.data
pic.type = image.type_index or 3 # Front cover
pic.type = image.type_index
pic.mime = image.mime_type
pic.desc = image.desc or u''
return pic